9
0
Fork 0

ping: do not return -1 in command

Also, print usage if not enough arguments given.

Signed-off-by: Sascha Hauer <sha@pengutronix.de>
This commit is contained in:
Sascha Hauer 2009-10-17 09:42:13 +02:00 committed by Sascha Hauer
parent feb58df760
commit 3701ed81ec
1 changed files with 2 additions and 5 deletions

View File

@ -83,12 +83,9 @@ PingHandler (uchar * pkt, unsigned dest, unsigned src, unsigned len)
int do_ping (cmd_tbl_t *cmdtp, int argc, char *argv[])
{
if (argc < 2)
return -1;
if (string_to_ip(argv[1], &NetPingIP)) {
if (argc < 2 || string_to_ip(argv[1], &NetPingIP)) {
printf ("Usage:\n%s\n", cmdtp->usage);
return -1;
return 1;
}
if (NetLoopInit(PING) < 0)