ping: do not return -1 in command
Also, print usage if not enough arguments given. Signed-off-by: Sascha Hauer <sha@pengutronix.de>
This commit is contained in:
parent
feb58df760
commit
3701ed81ec
|
@ -83,12 +83,9 @@ PingHandler (uchar * pkt, unsigned dest, unsigned src, unsigned len)
|
||||||
|
|
||||||
int do_ping (cmd_tbl_t *cmdtp, int argc, char *argv[])
|
int do_ping (cmd_tbl_t *cmdtp, int argc, char *argv[])
|
||||||
{
|
{
|
||||||
if (argc < 2)
|
if (argc < 2 || string_to_ip(argv[1], &NetPingIP)) {
|
||||||
return -1;
|
|
||||||
|
|
||||||
if (string_to_ip(argv[1], &NetPingIP)) {
|
|
||||||
printf ("Usage:\n%s\n", cmdtp->usage);
|
printf ("Usage:\n%s\n", cmdtp->usage);
|
||||||
return -1;
|
return 1;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (NetLoopInit(PING) < 0)
|
if (NetLoopInit(PING) < 0)
|
||||||
|
|
Loading…
Reference in New Issue