sysmo-bts
/
barebox
9
0
Fork 0
Code Releases Activity

param: make return value of param getter function const 

The string returned by the getter function should not be
changed. Make it const.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
This commit is contained in:
Sascha Hauer 2012-04-23 13:01:00 +02:00
parent 80b5293bca
commit 51f2ded17c
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
include/param.h
View File

@ -10,7 +10,7 @@ struct device_d;
typedef unsigned long IPaddr_t;
struct param_d {
char* (*get)(struct device_d *, struct param_d *param);
const char* (*get)(struct device_d *, struct param_d *param);
int (*set)(struct device_d *, struct param_d *param, const char *val);
unsigned int flags;
char *name;
@ -24,9 +24,9 @@ const char *dev_get_param(struct device_d *dev, const char *name);
int dev_set_param(struct device_d *dev, const char *name, const char *val);
struct param_d *get_param_by_name(struct device_d *dev, const char *name);
int dev_add_param(struct device_d *dev, char *name,
int dev_add_param(struct device_d *dev, const char *name,
int (*set)(struct device_d *dev, struct param_d *p, const char *val),
char *(*get)(struct device_d *, struct param_d *p),
const char *(*get)(struct device_d *, struct param_d *p),
unsigned long flags);
int dev_add_param_fixed(struct device_d *dev, char *name, char *value);

10
lib/parameter.c
View File

@ -133,14 +133,14 @@ int dev_param_set_generic(struct device_d *dev, struct param_d *p,
return 0;
}
static char *param_get_generic(struct device_d *dev, struct param_d *p)
static const char *param_get_generic(struct device_d *dev, struct param_d *p)
{
return p->value;
}
static struct param_d *__dev_add_param(struct device_d *dev, char *name,
static struct param_d *__dev_add_param(struct device_d *dev, const char *name,
int (*set)(struct device_d *dev, struct param_d *p, const char *val),
char *(*get)(struct device_d *dev, struct param_d *p),
const char *(*get)(struct device_d *dev, struct param_d *p),
unsigned long flags)
{
struct param_d *param;
@ -176,9 +176,9 @@ static struct param_d *__dev_add_param(struct device_d *dev, char *name,
* expect the parameter value to be a string which can be freed with free(). Do
* not use static arrays when using the generic functions.
*/
int dev_add_param(struct device_d *dev, char *name,
int dev_add_param(struct device_d *dev, const char *name,
int (*set)(struct device_d *dev, struct param_d *p, const char *val),
char *(*get)(struct device_d *dev, struct param_d *param),
const char *(*get)(struct device_d *dev, struct param_d *param),
unsigned long flags)
{
struct param_d *param;