sysmo-bts
/
barebox
9
0
Fork 0
Code Releases Activity

ubiattach command: Properly check return values 

- print error when ioctl fails, not a combined message when one of
  ioctl or ubi_attach_mtd_dev failed.
- ubi_attach_mtd_dev() returns the ubi number for success, not 0, so
  check for ret < 0 to detect errors.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
This commit is contained in:
Sascha Hauer 2013-07-23 11:29:34 +02:00
parent 675ef4770f
commit 56ac905457
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
commands/ubi.c
View File

@ -71,12 +71,17 @@ static int do_ubiattach(int argc, char *argv[])
}
ret = ioctl(fd, MEMGETINFO, &user);
if (!ret)
ret = ubi_attach_mtd_dev(user.mtd, UBI_DEV_NUM_AUTO, 0);
if (ret) {
printf("MEMGETINFO failed: %s\n", strerror(-ret));
goto err;
}
if (ret)
ret = ubi_attach_mtd_dev(user.mtd, UBI_DEV_NUM_AUTO, 0);
if (ret < 0)
printf("failed to attach: %s\n", strerror(-ret));
else
ret = 0;
err:
close(fd);
return ret ? 1 : 0;