From 71791bd2cbbd7f8f91600a0e299fcae56eeeaa51 Mon Sep 17 00:00:00 2001 From: Richard Weinberger Date: Sat, 28 Sep 2013 15:55:15 +0200 Subject: [PATCH] UBI: Fix memory leak in ubi_attach_fastmap() error path On error we have to free all three temporary lists. Reported-by: Richard Genoud Signed-off-by: Richard Weinberger Signed-off-by: Sascha Hauer --- drivers/mtd/ubi/fastmap.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c index 8963e0670..aaa9f55ad 100644 --- a/drivers/mtd/ubi/fastmap.c +++ b/drivers/mtd/ubi/fastmap.c @@ -830,6 +830,19 @@ static int ubi_attach_fastmap(struct ubi_device *ubi, fail_bad: ret = UBI_BAD_FASTMAP; fail: + list_for_each_entry_safe(tmp_aeb, _tmp_aeb, &used, u.list) { + free(tmp_aeb); + list_del(&tmp_aeb->u.list); + } + list_for_each_entry_safe(tmp_aeb, _tmp_aeb, &eba_orphans, u.list) { + free(tmp_aeb); + list_del(&tmp_aeb->u.list); + } + list_for_each_entry_safe(tmp_aeb, _tmp_aeb, &lfree, u.list) { + free(tmp_aeb); + list_del(&tmp_aeb->u.list); + } + return ret; }