9
0
Fork 0

fix brown paper bag bug introduced with compile time loglevel

__dev_printf is a define which uses a local variable 'ret'. This
means that whenever someone does a dev_*(dev, "ret: %d\n", ret);
ret will be 0.

Fix this by writing this without a local variable.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
This commit is contained in:
Sascha Hauer 2013-02-15 16:26:38 +01:00
parent a40e76cebc
commit 941aa21f26
1 changed files with 1 additions and 4 deletions

View File

@ -23,10 +23,7 @@ int dev_printf(const struct device_d *dev, const char *format, ...)
#define __dev_printf(level, dev, format, args...) \
({ \
int ret = 0; \
if (level <= LOGLEVEL) \
ret = dev_printf(dev, format, ##args); \
ret; \
(level) <= LOGLEVEL ? dev_printf((dev), (format), ##args) : 0; \
})