sysmo-bts
/
barebox
9
0
Fork 0
Code Releases Activity

param: Add helpers to provide an enum parameter 

We recently gained helper functions for different types of
device parameters. One thing missing was a helper for an
enum type parameter. This patch adds this.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
This commit is contained in:
Sascha Hauer 2013-05-23 13:40:38 +02:00
parent c5fa299862
commit a6afae76f1
2 changed files with 118 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
include/param.h
View File

@ -41,6 +41,11 @@ struct param_d *dev_add_param_bool(struct device_d *dev, const char *name,
int (*get)(struct param_d *p, void *priv),
int *value, void *priv);
struct param_d *dev_add_param_enum(struct device_d *dev, const char *name,
int (*set)(struct param_d *p, void *priv),
int (*get)(struct param_d *p, void *priv),
int *value, const char **names, int max, void *priv);
struct param_d *dev_add_param_int_ro(struct device_d *dev, const char *name,
int value, const char *format);
@ -90,6 +95,15 @@ static inline struct param_d *dev_add_param_int(struct device_d *dev, const char
return NULL;
}
static inline struct param_d *dev_add_param_enum(struct device_d *dev, const char *name,
int (*set)(struct param_d *p, void *priv),
int (*get)(struct param_d *p, void *priv),
int *value, const char **names, int max, void *priv)
{
return NULL;
}
static inline struct param_d *dev_add_param_bool(struct device_d *dev, const char *name,
int (*set)(struct param_d *p, void *priv),
int (*get)(struct param_d *p, void *priv),

104
lib/parameter.c
View File

@ -299,6 +299,110 @@ struct param_d *dev_add_param_int(struct device_d *dev, const char *name,
return &pi->param;
}
struct param_enum {
struct param_d param;
int *value;
const char **names;
int num_names;
int (*set)(struct param_d *p, void *priv);
int (*get)(struct param_d *p, void *priv);
};
static inline struct param_enum *to_param_enum(struct param_d *p)
{
return container_of(p, struct param_enum, param);
}
static int param_enum_set(struct device_d *dev, struct param_d *p, const char *val)
{
struct param_enum *pe = to_param_enum(p);
int value_save = *pe->value;
int i, ret;
if (!val)
return -EINVAL;
for (i = 0; i < pe->num_names; i++)
if (pe->names[i] && !strcmp(val, pe->names[i]))
break;
if (i == pe->num_names)
return -EINVAL;
*pe->value = i;
if (!pe->set)
return 0;
ret = pe->set(p, p->driver_priv);
if (ret)
*pe->value = value_save;
return ret;
}
static const char *param_enum_get(struct device_d *dev, struct param_d *p)
{
struct param_enum *pe = to_param_enum(p);
int ret;
if (pe->get) {
ret = pe->get(p, p->driver_priv);
if (ret)
return NULL;
}
free(p->value);
p->value = strdup(pe->names[*pe->value]);
return p->value;
}
static void param_enum_info(struct param_d *p)
{
struct param_enum *pe = to_param_enum(p);
int i;
printf(" (");
for (i = 0; i < pe->num_names; i++) {
if (!pe->names[i] || !*pe->names[i])
continue;
printf("\"%s\"%s", pe->names[i],
i == pe->num_names - 1 ? ")" : ", ");
}
}
struct param_d *dev_add_param_enum(struct device_d *dev, const char *name,
int (*set)(struct param_d *p, void *priv),
int (*get)(struct param_d *p, void *priv),
int *value, const char **names, int num_names, void *priv)
{
struct param_enum *pe;
struct param_d *p;
int ret;
pe = xzalloc(sizeof(*pe));
pe->value = value;
pe->set = set;
pe->get = get;
pe->names = names;
pe->num_names = num_names;
p = &pe->param;
p->driver_priv = priv;
ret = __dev_add_param(p, dev, name, param_enum_set, param_enum_get, 0);
if (ret) {
free(pe);
return ERR_PTR(ret);
}
p->info = param_enum_info;
return &pe->param;
}
/**
* dev_add_param_bool - add an boolean parameter to a device
* @param dev The device