sysmo-bts
/
barebox
9
0
Fork 0
Code Releases Activity

param: let dev_add_param return the newly created param 

dev_add_param creates a new parameter so it makes more sense to
return it than to return an error code. Since the return value
is hardly ever checked this is only a small patch.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
This commit is contained in:
Sascha Hauer 2014-07-24 12:21:03 +02:00
parent d096cafff7
commit ade0583602
3 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
common/globalvar.c
View File

@ -17,7 +17,12 @@ int globalvar_add(const char *name,
const char *(*get)(struct device_d *, struct param_d *p),
unsigned long flags)
{
return dev_add_param(&global_device, name, set, get, flags);
struct param_d *param;
param = dev_add_param(&global_device, name, set, get, flags);
if (IS_ERR(param))
return PTR_ERR(param);
return 0;
}
/*

4
include/param.h
View File

@ -26,7 +26,7 @@ const char *dev_get_param(struct device_d *dev, const char *name);
int dev_set_param(struct device_d *dev, const char *name, const char *val);
struct param_d *get_param_by_name(struct device_d *dev, const char *name);
int dev_add_param(struct device_d *dev, const char *name,
struct param_d *dev_add_param(struct device_d *dev, const char *name,
int (*set)(struct device_d *dev, struct param_d *p, const char *val),
const char *(*get)(struct device_d *, struct param_d *p),
unsigned long flags);
@ -92,7 +92,7 @@ static inline struct param_d *get_param_by_name(struct device_d *dev,
return NULL;
}
static inline int dev_add_param(struct device_d *dev, char *name,
static inline struct param_d *dev_add_param(struct device_d *dev, char *name,
int (*set)(struct device_d *dev, struct param_d *p, const char *val),
const char *(*get)(struct device_d *, struct param_d *p),
unsigned long flags)

8
lib/parameter.c
View File

@ -160,7 +160,7 @@ static int __dev_add_param(struct param_d *param, struct device_d *dev, const ch
* expect the parameter value to be a string which can be freed with free(). Do
* not use static arrays when using the generic functions.
*/
int dev_add_param(struct device_d *dev, const char *name,
struct param_d *dev_add_param(struct device_d *dev, const char *name,
int (*set)(struct device_d *dev, struct param_d *p, const char *val),
const char *(*get)(struct device_d *dev, struct param_d *param),
unsigned long flags)
@ -171,10 +171,12 @@ int dev_add_param(struct device_d *dev, const char *name,
param = xzalloc(sizeof(*param));
ret = __dev_add_param(param, dev, name, set, get, flags);
if (ret)
if (ret) {
free(param);
return ERR_PTR(ret);
}
return ret;
return param;
}
/**