sysmo-bts
/
barebox
9
0
Fork 0
Code Releases Activity

fs: efivars: don't store attributes in file 

We don't have a use-case yet where we need to manipulate
the attributes of a variable and it confuses "normal"
users of the variables.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
This commit is contained in:
Lucas Stach 2014-12-08 14:42:37 +01:00 committed by Sascha Hauer
parent eb15ab159f
commit c296bef5ed
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
fs/efivarfs.c
View File

@ -131,6 +131,7 @@ struct efivars_file {
unsigned long size;
efi_guid_t vendor;
s16 *name;
u32 attributes;
};
static int efivarfs_open(struct device_d *dev, FILE *f, const char *filename)
@ -138,7 +139,6 @@ static int efivarfs_open(struct device_d *dev, FILE *f, const char *filename)
struct efivars_file *efile;
efi_status_t efiret;
int ret;
uint32_t attributes;
efile = xzalloc(sizeof(*efile));
@ -146,28 +146,27 @@ static int efivarfs_open(struct device_d *dev, FILE *f, const char *filename)
if (ret)
return -ENOENT;
efiret = RT->get_variable(efile->name, &efile->vendor, &attributes, &efile->size, NULL);
efiret = RT->get_variable(efile->name, &efile->vendor,
&efile->attributes, &efile->size, NULL);
if (EFI_ERROR(efiret) && efiret != EFI_BUFFER_TOO_SMALL) {
ret = -efi_errno(efiret);
goto out;
}
efile->buf = malloc(efile->size + sizeof(uint32_t));
efile->buf = malloc(efile->size);
if (!efile->buf) {
ret = -ENOMEM;
goto out;
}
efiret = RT->get_variable(efile->name, &efile->vendor, NULL, &efile->size,
efile->buf + sizeof(uint32_t));
efile->buf);
if (EFI_ERROR(efiret)) {
ret = -efi_errno(efiret);
goto out;
}
*(uint32_t *)efile->buf = attributes;
f->size = efile->size + sizeof(uint32_t);
f->size = efile->size;
f->inode = efile;
return 0;