From e44c9b04c4cb96e09c2d7a5caf91bfb56d08729b Mon Sep 17 00:00:00 2001 From: Mirko Damiani Date: Mon, 16 Mar 2015 16:02:41 +0100 Subject: [PATCH] net: ping: return an error exit code when connection fails ping command does not always returns 1 as exit code when connection to host fails. In particular it returns the exit code of the previous run. This patch fixes this issue. Signed-off-by: Mirko Damiani Signed-off-by: Sascha Hauer --- net/ping.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/ping.c b/net/ping.c index 2349f4bed..4eb77cb78 100644 --- a/net/ping.c +++ b/net/ping.c @@ -67,6 +67,9 @@ static int do_ping(int argc, char *argv[]) return 1; } + ping_state = PING_STATE_INIT; + ping_sequence_number = 0; + ping_con = net_icmp_new(net_ping_ip, ping_handler, NULL); if (IS_ERR(ping_con)) { ret = PTR_ERR(ping_con); @@ -78,9 +81,6 @@ static int do_ping(int argc, char *argv[]) if (ret) goto out_unreg; - ping_state = PING_STATE_INIT; - ping_sequence_number = 0; - while (ping_state == PING_STATE_INIT) { if (ctrlc()) { ret = -EINTR;