9
0
Fork 0

state: check return value of of_property_count_strings

When a enum32 state variable node does not have a "names" property bail
out instead of continuing with an error value used as number of strings.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
This commit is contained in:
Sascha Hauer 2015-09-10 15:14:39 +02:00
parent 2a34749fca
commit e94d1eb5d3
1 changed files with 4 additions and 0 deletions

View File

@ -318,6 +318,10 @@ static struct state_variable *state_enum32_create(struct state *state,
enum32 = xzalloc(sizeof(*enum32));
num_names = of_property_count_strings(node, "names");
if (num_names < 0) {
dev_err(&state->dev, "enum32 node without \"names\" property\n");
return ERR_PTR(-EINVAL);
}
enum32->names = xzalloc(sizeof(char *) * num_names);
enum32->num_names = num_names;