This patch does probably too much, but it's hard (and very cumbersome/time consuming) to break it out. What is does is this: * each command has one short description, e.g. "list MUX configuration" * made sure the short descriptions start lowercase * each command has one usage. That string contains just the options, e.g. "[-npn]". It's not part of the long help text. * that is, it doesn't say "[OPTIONS]" anymore, every usable option is listed by character in this (short) option string (the long description is in the long help text, as before) * help texts have been reworked, to make them - sometimes smaller - sometimes describe the options better - more often present themselves in a nicer format * all long help texts are now created with BUSYBOX_CMD_HELP_ macros, no more 'static const __maybe_unused char cmd_foobar_help[]' * made sure the long help texts starts uppercase * because cmdtp->name and cmdtp->opts together provide the new usage, all "Usage: foobar" texts have been removed from the long help texts * BUSYBOX_CMD_HELP_TEXT() provides the trailing newline by itself, this is nicer in the source code * BUSYBOX_CMD_HELP_OPT() provides the trailing newline by itself * made sure no line gets longer than 77 characters * delibertely renamed cmdtp->usage, so that we can get compile-time errors (e.g. in out-of-tree modules that use register_command() * the 'help' command can now always emit the usage, even without compiled long help texts * 'help -v' gives a list of commands with their short description, this is similar like the old "help" command before my patchset * 'help -a' gives out help of all commands Signed-off-by: Holger Schurig <holgerschurig@gmail.com> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
136 lines
2.5 KiB
C
136 lines
2.5 KiB
C
#include <common.h>
|
|
#include <command.h>
|
|
#include <getopt.h>
|
|
#include <linux/clk.h>
|
|
#include <linux/err.h>
|
|
|
|
static int do_clk_enable(int argc, char *argv[])
|
|
{
|
|
struct clk *clk;
|
|
|
|
if (argc != 2)
|
|
return COMMAND_ERROR_USAGE;
|
|
|
|
clk = clk_lookup(argv[1]);
|
|
if (IS_ERR(clk))
|
|
return PTR_ERR(clk);
|
|
|
|
return clk_enable(clk);
|
|
}
|
|
|
|
BAREBOX_CMD_START(clk_enable)
|
|
.cmd = do_clk_enable,
|
|
BAREBOX_CMD_DESC("enable a clock")
|
|
BAREBOX_CMD_OPTS("CLK")
|
|
BAREBOX_CMD_GROUP(CMD_GRP_HWMANIP)
|
|
BAREBOX_CMD_END
|
|
|
|
static int do_clk_disable(int argc, char *argv[])
|
|
{
|
|
struct clk *clk;
|
|
|
|
if (argc != 2)
|
|
return COMMAND_ERROR_USAGE;
|
|
|
|
clk = clk_lookup(argv[1]);
|
|
if (IS_ERR(clk))
|
|
return PTR_ERR(clk);
|
|
|
|
clk_disable(clk);
|
|
|
|
return 0;
|
|
}
|
|
|
|
BAREBOX_CMD_START(clk_disable)
|
|
.cmd = do_clk_disable,
|
|
BAREBOX_CMD_DESC("disable a clock")
|
|
BAREBOX_CMD_OPTS("CLK")
|
|
BAREBOX_CMD_GROUP(CMD_GRP_HWMANIP)
|
|
BAREBOX_CMD_END
|
|
|
|
static int do_clk_set_rate(int argc, char *argv[])
|
|
{
|
|
struct clk *clk;
|
|
unsigned long rate;
|
|
|
|
if (argc != 3)
|
|
return COMMAND_ERROR_USAGE;
|
|
|
|
clk = clk_lookup(argv[1]);
|
|
if (IS_ERR(clk))
|
|
return PTR_ERR(clk);
|
|
|
|
rate = simple_strtoul(argv[2], NULL, 0);
|
|
|
|
return clk_set_rate(clk, rate);
|
|
}
|
|
|
|
BAREBOX_CMD_HELP_START(clk_set_rate)
|
|
BAREBOX_CMD_HELP_TEXT("Set clock CLK to RATE")
|
|
BAREBOX_CMD_HELP_END
|
|
|
|
BAREBOX_CMD_START(clk_set_rate)
|
|
.cmd = do_clk_set_rate,
|
|
BAREBOX_CMD_DESC("set a clocks rate")
|
|
BAREBOX_CMD_OPTS("CLK HZ")
|
|
BAREBOX_CMD_GROUP(CMD_GRP_HWMANIP)
|
|
BAREBOX_CMD_HELP(cmd_clk_set_rate_help)
|
|
BAREBOX_CMD_END
|
|
|
|
static int do_clk_dump(int argc, char *argv[])
|
|
{
|
|
int opt, verbose = 0;
|
|
|
|
while ((opt = getopt(argc, argv, "v")) > 0) {
|
|
switch(opt) {
|
|
case 'v':
|
|
verbose = 1;
|
|
break;
|
|
default:
|
|
return -EINVAL;
|
|
|
|
}
|
|
}
|
|
|
|
clk_dump(verbose);
|
|
|
|
return 0;
|
|
}
|
|
|
|
BAREBOX_CMD_HELP_START(clk_dump)
|
|
BAREBOX_CMD_HELP_TEXT("Options:")
|
|
BAREBOX_CMD_HELP_OPT ("-v", "verbose")
|
|
BAREBOX_CMD_HELP_END
|
|
|
|
BAREBOX_CMD_START(clk_dump)
|
|
.cmd = do_clk_dump,
|
|
BAREBOX_CMD_DESC("show information about registered clocks")
|
|
BAREBOX_CMD_OPTS("[-v]")
|
|
BAREBOX_CMD_GROUP(CMD_GRP_INFO)
|
|
BAREBOX_CMD_HELP(cmd_clk_dump_help)
|
|
BAREBOX_CMD_END
|
|
|
|
static int do_clk_set_parent(int argc, char *argv[])
|
|
{
|
|
struct clk *clk, *parent;
|
|
|
|
if (argc != 3)
|
|
return COMMAND_ERROR_USAGE;
|
|
|
|
clk = clk_lookup(argv[1]);
|
|
if (IS_ERR(clk))
|
|
return PTR_ERR(clk);
|
|
parent = clk_lookup(argv[2]);
|
|
if (IS_ERR(parent))
|
|
return PTR_ERR(parent);
|
|
|
|
return clk_set_parent(clk, parent);
|
|
}
|
|
|
|
BAREBOX_CMD_START(clk_set_parent)
|
|
.cmd = do_clk_set_parent,
|
|
BAREBOX_CMD_DESC("set parent of a clock")
|
|
BAREBOX_CMD_OPTS("CLK PARENT")
|
|
BAREBOX_CMD_GROUP(CMD_GRP_HWMANIP)
|
|
BAREBOX_CMD_END
|