2007-01-21 21:28:51 +00:00
# BB Class inspired by ebuild.sh
#
# This class will test files after installation for certain
# security issues and other kind of issues.
#
# Checks we do:
# -Check the ownership and permissions
# -Check the RUNTIME path for the $TMPDIR
# -Check if .la files wrongly point to workdir
# -Check if .pc files wrongly point to workdir
2008-03-19 15:53:07 +00:00
# -Check if packages contains .debug directories or .so files
# where they should be in -dev or -dbg
2007-09-02 09:46:35 +00:00
# -Check if config.log contains traces to broken autoconf tests
2007-01-21 21:28:51 +00:00
#
# We need to have the scanelf utility as soon as
2008-03-19 15:53:07 +00:00
# possible and this is contained within the pax-utils-native.
# The package.bbclass can help us here.
2007-01-21 21:28:51 +00:00
#
inherit package
2007-11-14 09:36:55 +00:00
PACKAGE_DEPENDS += "pax-utils-native desktop-file-utils-native"
2007-01-21 21:28:51 +00:00
PACKAGEFUNCS += " do_package_qa "
2007-09-02 09:46:35 +00:00
#
# dictionary for elf headers
#
2008-03-19 15:53:07 +00:00
# feel free to add and correct.
2007-09-02 09:46:35 +00:00
#
# TARGET_OS TARGET_ARCH MACHINE, OSABI, ABIVERSION, Little Endian, 32bit?
def package_qa_get_machine_dict():
return {
2010-07-08 09:23:17 +00:00
"darwin9" : {
2011-03-01 18:42:28 +00:00
"arm" : (40, 0, 0, True, 32),
2010-07-08 09:23:17 +00:00
},
2007-09-02 09:46:35 +00:00
"linux" : {
2011-03-01 18:42:28 +00:00
"arm" : (40, 97, 0, True, 32),
"armeb": (40, 97, 0, False, 32),
"powerpc": (20, 0, 0, False, 32),
"i386": ( 3, 0, 0, True, 32),
"i486": ( 3, 0, 0, True, 32),
"i586": ( 3, 0, 0, True, 32),
"i686": ( 3, 0, 0, True, 32),
"x86_64": (62, 0, 0, True, 64),
"ia64": (50, 0, 0, True, 64),
"alpha": (36902, 0, 0, True, 64),
"hppa": (15, 3, 0, False, 32),
"m68k": ( 4, 0, 0, False, 32),
"mips": ( 8, 0, 0, False, 32),
"mipsel": ( 8, 0, 0, True, 32),
"s390": (22, 0, 0, False, 32),
"sh4": (42, 0, 0, True, 32),
"sparc": ( 2, 0, 0, False, 32),
2007-09-02 09:46:35 +00:00
},
"linux-uclibc" : {
2011-03-01 18:42:28 +00:00
"arm" : ( 40, 97, 0, True, 32),
"armeb": ( 40, 97, 0, False, 32),
"powerpc": ( 20, 0, 0, False, 32),
"i386": ( 3, 0, 0, True, 32),
"i486": ( 3, 0, 0, True, 32),
"i586": ( 3, 0, 0, True, 32),
"i686": ( 3, 0, 0, True, 32),
"x86_64": ( 62, 0, 0, True, 64),
"mips": ( 8, 0, 0, False, 32),
"mipsel": ( 8, 0, 0, True, 32),
"avr32": (6317, 0, 0, False, 32),
"sh4": (42, 0, 0, True, 32),
2010-07-08 09:23:17 +00:00
2007-09-02 09:46:35 +00:00
},
"uclinux-uclibc" : {
2011-03-01 18:42:28 +00:00
"bfin": ( 106, 0, 0, True, 32),
2007-09-02 09:46:35 +00:00
},
"linux-gnueabi" : {
2011-03-01 18:42:28 +00:00
"arm" : (40, 0, 0, True, 32),
"armeb" : (40, 0, 0, False, 32),
2007-09-02 09:46:35 +00:00
},
2011-04-01 03:07:44 +00:00
"linux-uclibceabi" : {
2011-03-01 18:42:28 +00:00
"arm" : (40, 0, 0, True, 32),
"armeb" : (40, 0, 0, False, 32),
2007-09-02 09:46:35 +00:00
},
2010-07-08 09:23:17 +00:00
"linux-gnuspe" : {
2011-03-01 18:42:28 +00:00
"powerpc": (20, 0, 0, False, 32),
2010-07-08 09:23:17 +00:00
},
"linux-uclibcspe" : {
2011-03-01 18:42:28 +00:00
"powerpc": (20, 0, 0, False, 32),
2010-07-08 09:23:17 +00:00
},
2008-03-19 15:53:07 +00:00
2007-09-02 09:46:35 +00:00
}
2010-07-08 09:23:17 +00:00
2007-09-02 09:46:35 +00:00
# Known Error classes
# 0 - non dev contains .so
# 1 - package contains a dangerous RPATH
# 2 - package depends on debug package
# 3 - non dbg contains .so
# 4 - wrong architecture
# 5 - .la contains installed=yes or reference to the workdir
# 6 - .pc contains reference to /usr/include or workdir
2008-03-19 15:53:07 +00:00
# 7 - the desktop file is not valid
# 8 - .la contains reference to the workdir
2010-07-08 09:23:17 +00:00
# 9 - LDFLAGS ignored
# 10 - Build paths in binaries
2007-09-02 09:46:35 +00:00
def package_qa_clean_path(path,d):
2008-03-19 15:53:07 +00:00
""" Remove the common prefix from the path. In this case it is the TMPDIR"""
2007-09-02 09:46:35 +00:00
return path.replace(bb.data.getVar('TMPDIR',d,True),"")
def package_qa_make_fatal_error(error_class, name, path,d):
"""
decide if an error is fatal
TODO: Load a whitelist of known errors
"""
2010-07-08 22:51:06 +00:00
return False
2008-04-22 21:22:11 +00:00
return not error_class in [0, 5, 7, 8, 9]
2007-09-02 09:46:35 +00:00
def package_qa_write_error(error_class, name, path, d):
2008-03-19 15:53:07 +00:00
"""
Log the error
"""
2007-09-02 09:46:35 +00:00
ERROR_NAMES =[
"non dev contains .so",
"package contains RPATH",
"package depends on debug package",
"non dbg contains .debug",
"wrong architecture",
"evil hides inside the .la",
"evil hides inside the .pc",
2008-03-19 15:53:07 +00:00
"the desktop file is not valid",
".la contains reference to the workdir",
2010-07-08 09:23:17 +00:00
"LDFLAGS ignored",
2008-04-22 21:22:11 +00:00
"package contains reference to tmpdir paths",
2007-09-02 09:46:35 +00:00
]
log_path = os.path.join( bb.data.getVar('T', d, True), "log.qa_package" )
f = file( log_path, "a+")
2008-03-19 15:53:07 +00:00
print >> f, "%s, %s, %s" % \
(ERROR_NAMES[error_class], name, package_qa_clean_path(path,d))
2007-09-02 09:46:35 +00:00
f.close()
2008-04-22 21:22:11 +00:00
logfile = bb.data.getVar('QA_LOGFILE', d, True)
if logfile:
p = bb.data.getVar('P', d, True)
f = file( logfile, "a+")
print >> f, "%s, %s, %s, %s" % \
(p, ERROR_NAMES[error_class], name, package_qa_clean_path(path,d))
f.close()
2008-03-19 15:53:07 +00:00
def package_qa_handle_error(error_class, error_msg, name, path, d):
2008-04-22 21:22:11 +00:00
fatal = package_qa_make_fatal_error(error_class, name, path, d)
if fatal:
bb.error("QA Issue: %s" % error_msg)
else:
2011-01-13 15:47:14 +00:00
bb.warn("QA Issue: %s" % error_msg)
2008-03-19 15:53:07 +00:00
package_qa_write_error(error_class, name, path, d)
2008-04-22 21:22:11 +00:00
return not fatal
2007-09-02 09:46:35 +00:00
2010-07-08 09:23:17 +00:00
def package_qa_check_rpath(file,name,d, elf):
2007-01-21 21:28:51 +00:00
"""
Check for dangerous RPATHs
"""
2010-07-08 09:23:17 +00:00
if not elf:
return True
2008-03-19 15:53:07 +00:00
sane = True
2007-01-21 21:28:51 +00:00
scanelf = os.path.join(bb.data.getVar('STAGING_BINDIR_NATIVE',d,True),'scanelf')
2010-07-08 09:23:17 +00:00
bad_dirs = [bb.data.getVar('TMPDIR', d, True) + "/work", bb.data.getVar('STAGING_DIR_TARGET', d, True)]
2007-09-02 09:46:35 +00:00
bad_dir_test = bb.data.getVar('TMPDIR', d, True)
2007-01-21 21:28:51 +00:00
if not os.path.exists(scanelf):
2007-09-02 09:46:35 +00:00
bb.fatal("Can not check RPATH, scanelf (part of pax-utils-native) not found")
2008-03-19 15:53:07 +00:00
2010-07-08 09:23:17 +00:00
if not bad_dirs[0] in bb.data.getVar('WORKDIR', d, True):
2007-01-21 21:28:51 +00:00
bb.fatal("This class assumed that WORKDIR is ${TMPDIR}/work... Not doing any check")
2007-09-02 09:46:35 +00:00
output = os.popen("%s -B -F%%r#F '%s'" % (scanelf,file))
txt = output.readline().split()
for line in txt:
2010-07-08 09:23:17 +00:00
for dir in bad_dirs:
if dir in line:
error_msg = "package %s contains bad RPATH %s in file %s" % (name, line, file)
sane = sane + package_qa_handle_error(1, error_msg, name, file, d)
2008-03-19 15:53:07 +00:00
return sane
2007-01-21 21:28:51 +00:00
2010-07-08 09:23:17 +00:00
def package_qa_check_dev(path, name,d, elf):
2007-01-21 21:28:51 +00:00
"""
2010-07-08 09:23:17 +00:00
Check for ".so" library symlinks in non-dev packages
2007-01-21 21:28:51 +00:00
"""
2007-09-02 09:46:35 +00:00
sane = True
2011-02-09 03:46:47 +00:00
if not name.endswith("-dev") and not name.endswith("-dbg") and path.endswith(".so") and os.path.islink(path):
error_msg = "non -dev/-dbg package contains symlink .so: %s path '%s'" % \
2010-07-08 09:23:17 +00:00
(name, package_qa_clean_path(path,d))
sane = package_qa_handle_error(0, error_msg, name, path, d)
return sane
def package_qa_check_dbg(path, name,d, elf):
"""
Check for ".debug" files or directories outside of the dbg package
"""
sane = True
2007-01-21 21:28:51 +00:00
if not "-dbg" in name:
2010-07-08 09:23:17 +00:00
if '.debug' in path.split(os.path.sep):
2008-03-19 15:53:07 +00:00
error_msg = "non debug package contains .debug directory: %s path %s" % \
(name, package_qa_clean_path(path,d))
sane = package_qa_handle_error(3, error_msg, name, path, d)
2007-09-02 09:46:35 +00:00
return sane
2007-01-21 21:28:51 +00:00
2010-07-08 09:23:17 +00:00
def package_qa_check_perm(path,name,d, elf):
2007-01-21 21:28:51 +00:00
"""
Check the permission of files
"""
2007-09-02 09:46:35 +00:00
sane = True
return sane
2007-01-21 21:28:51 +00:00
2010-07-08 09:23:17 +00:00
def package_qa_check_arch(path,name,d, elf):
2007-01-21 21:28:51 +00:00
"""
Check if archs are compatible
"""
2010-07-08 09:23:17 +00:00
if not elf:
return True
2008-03-19 15:53:07 +00:00
sane = True
2007-09-02 09:46:35 +00:00
target_os = bb.data.getVar('TARGET_OS', d, True)
target_arch = bb.data.getVar('TARGET_ARCH', d, True)
2008-03-19 15:53:07 +00:00
2007-09-02 09:46:35 +00:00
# FIXME: Cross package confuse this check, so just skip them
2010-07-08 09:23:17 +00:00
for s in ['cross', 'nativesdk', 'cross-canadian']:
if bb.data.inherits_class(s, d):
return True
2007-09-02 09:46:35 +00:00
# avoid following links to /usr/bin (e.g. on udev builds)
# we will check the files pointed to anyway...
if os.path.islink(path):
return True
#if this will throw an exception, then fix the dict above
2011-03-01 18:42:28 +00:00
(machine, osabi, abiversion, littleendian, bits) \
2008-03-19 15:53:07 +00:00
= package_qa_get_machine_dict()[target_os][target_arch]
2007-09-02 09:46:35 +00:00
2008-03-19 15:53:07 +00:00
# Check the architecture and endiannes of the binary
2007-09-02 09:46:35 +00:00
if not machine == elf.machine():
2008-03-19 15:53:07 +00:00
error_msg = "Architecture did not match (%d to %d) on %s" % \
(machine, elf.machine(), package_qa_clean_path(path,d))
sane = package_qa_handle_error(4, error_msg, name, path, d)
2011-03-01 18:42:28 +00:00
elif not bits == elf.abiSize():
error_msg = "Bit size did not match (%d to %d) on %s" % \
(bits, elf.abiSize(), package_qa_clean_path(path,d))
sane = package_qa_handle_error(4, error_msg, name, path, d)
2007-09-02 09:46:35 +00:00
elif not littleendian == elf.isLittleEndian():
2008-03-19 15:53:07 +00:00
error_msg = "Endiannes did not match (%d to %d) on %s" % \
(littleendian, elf.isLittleEndian(), package_qa_clean_path(path,d))
sane = package_qa_handle_error(4, error_msg, name, path, d)
2007-01-21 21:28:51 +00:00
2007-09-02 09:46:35 +00:00
return sane
2007-01-21 21:28:51 +00:00
2010-07-08 09:23:17 +00:00
def package_qa_check_desktop(path, name, d, elf):
2007-11-14 09:36:55 +00:00
"""
Run all desktop files through desktop-file-validate.
"""
2008-03-19 15:53:07 +00:00
sane = True
2007-11-14 09:36:55 +00:00
if path.endswith(".desktop"):
2008-04-03 05:17:32 +00:00
desktop_file_validate = os.path.join(bb.data.getVar('STAGING_BINDIR_NATIVE',d,True),'desktop-file-validate')
output = os.popen("%s %s" % (desktop_file_validate, path))
2007-11-14 09:48:17 +00:00
# This only produces output on errors
for l in output:
2008-03-19 15:53:07 +00:00
sane = package_qa_handle_error(7, l.strip(), name, path, d)
return sane
2007-11-14 09:36:55 +00:00
2010-07-08 09:23:17 +00:00
def package_qa_hash_style(path, name, d, elf):
"""
Check if the binary has the right hash style...
"""
if not elf:
return True
if os.path.islink(path):
return True
gnu_hash = "--hash-style=gnu" in bb.data.getVar('LDFLAGS', d, True)
if not gnu_hash:
gnu_hash = "--hash-style=both" in bb.data.getVar('LDFLAGS', d, True)
if not gnu_hash:
return True
objdump = bb.data.getVar('OBJDUMP', d, True)
env_path = bb.data.getVar('PATH', d, True)
sane = True
elf = False
# A bit hacky. We do not know if path is an elf binary or not
# we will search for 'NEEDED' or 'INIT' as this should be printed...
# and come before the HASH section (guess!!!) and works on split out
# debug symbols too
for line in os.popen("LC_ALL=C PATH=%s %s -p '%s' 2> /dev/null" % (env_path, objdump, path), "r"):
if "NEEDED" in line or "INIT" in line:
sane = False
elf = True
if "GNU_HASH" in line:
sane = True
if "[mips32]" in line or "[mips64]" in line:
sane = True
if elf and not sane:
error_msg = "No GNU_HASH in the elf binary: '%s'" % path
return package_qa_handle_error(9, error_msg, name, path, d)
return True
def package_qa_check_buildpaths(path, name, d, elf):
2008-04-22 21:22:11 +00:00
"""
Check for build paths inside target files and error if not found in the whitelist
"""
sane = True
# Ignore .debug files, not interesting
if path.find(".debug") != -1:
return True
# Ignore symlinks
if os.path.islink(path):
return True
tmpdir = bb.data.getVar('TMPDIR', d, True)
file_content = open(path).read()
if tmpdir in file_content:
error_msg = "File %s in package contained reference to tmpdir" % package_qa_clean_path(path,d)
2010-07-08 09:23:17 +00:00
sane = package_qa_handle_error(10, error_msg, name, path, d)
2008-04-22 21:22:11 +00:00
return sane
2010-05-11 23:25:39 +00:00
def package_qa_check_license(workdir, d):
"""
Check for changes in the license files
"""
import tempfile
sane = True
lic_files = bb.data.getVar('LIC_FILES_CHKSUM', d, True)
2010-07-13 16:41:25 +00:00
pn = bb.data.getVar('PN', d, True)
2010-05-11 23:25:39 +00:00
if not lic_files:
2010-05-12 17:54:05 +00:00
# just throw a warning now. Once licensing data in entered for enough of the recipes,
# this will be converted into error and False will be returned.
2010-12-22 23:50:12 +00:00
bb.error(pn + ": Recipe file does not have license file information (LIC_FILES_CHKSUM)")
2011-01-06 02:18:55 +00:00
return False
2010-05-11 23:25:39 +00:00
srcdir = bb.data.getVar('S', d, True)
for url in lic_files.split():
(type, host, path, user, pswd, parm) = bb.decodeurl(url)
srclicfile = os.path.join(srcdir, path)
2010-06-04 04:48:16 +00:00
if not os.path.isfile(srclicfile):
2011-01-06 02:18:55 +00:00
raise bb.build.FuncFailed( pn + ": LIC_FILES_CHKSUM points to invalid file: " + path)
2010-05-11 23:25:39 +00:00
if 'md5' not in parm:
2011-01-06 02:18:55 +00:00
bb.error(pn + ": md5 checksum is not specified for ", url)
2010-05-11 23:25:39 +00:00
return False
beginline, endline = 0, 0
if 'beginline' in parm:
beginline = int(parm['beginline'])
if 'endline' in parm:
endline = int(parm['endline'])
if (not beginline) and (not endline):
md5chksum = bb.utils.md5_file(srclicfile)
else:
fi = open(srclicfile, 'r')
fo = tempfile.NamedTemporaryFile(mode='wb', prefix='poky.', suffix='.tmp', delete=False)
tmplicfile = fo.name;
lineno = 0
linesout = 0
for line in fi:
lineno += 1
if (lineno >= beginline):
if ((lineno <= endline) or not endline):
fo.write(line)
linesout += 1
else:
break
fo.flush()
fo.close()
fi.close()
md5chksum = bb.utils.md5_file(tmplicfile)
os.unlink(tmplicfile)
if parm['md5'] == md5chksum:
2011-01-06 02:18:55 +00:00
bb.note (pn + ": md5 checksum matched for ", url)
2010-05-11 23:25:39 +00:00
else:
2011-01-06 02:18:55 +00:00
bb.error (pn + ": md5 data is not matching for ", url)
bb.error (pn + ": The new md5 checksum is ", md5chksum)
bb.error (pn + ": Check if the license information has changed in")
2010-06-28 03:02:45 +00:00
sane = False
2010-05-11 23:25:39 +00:00
return sane
2007-01-21 21:28:51 +00:00
def package_qa_check_staged(path,d):
"""
Check staged la and pc files for sanity
-e.g. installed being false
2007-09-02 09:46:35 +00:00
As this is run after every stage we should be able
to find the one responsible for the errors easily even
if we look at every .pc and .la file
2007-01-21 21:28:51 +00:00
"""
2007-09-02 09:46:35 +00:00
sane = True
2008-03-19 15:53:07 +00:00
tmpdir = bb.data.getVar('TMPDIR', d, True)
workdir = os.path.join(tmpdir, "work")
2007-09-02 09:46:35 +00:00
2008-03-19 15:53:07 +00:00
installed = "installed=yes"
if bb.data.inherits_class("native", d) or bb.data.inherits_class("cross", d):
pkgconfigcheck = workdir
2007-09-02 09:46:35 +00:00
else:
2008-03-19 15:53:07 +00:00
pkgconfigcheck = tmpdir
2007-09-02 09:46:35 +00:00
# find all .la and .pc files
# read the content
# and check for stuff that looks wrong
for root, dirs, files in os.walk(path):
for file in files:
path = os.path.join(root,file)
2010-07-08 09:23:17 +00:00
if file.endswith(".la"):
2007-09-02 09:46:35 +00:00
file_content = open(path).read()
2008-01-13 16:58:42 +00:00
if workdir in file_content:
2008-03-19 15:53:07 +00:00
error_msg = "%s failed sanity test (workdir) in path %s" % (file,root)
sane = package_qa_handle_error(8, error_msg, "staging", path, d)
2010-07-08 09:23:17 +00:00
elif file.endswith(".pc"):
2007-09-02 09:46:35 +00:00
file_content = open(path).read()
2008-03-19 15:53:07 +00:00
if pkgconfigcheck in file_content:
error_msg = "%s failed sanity test (tmpdir) in path %s" % (file,root)
sane = package_qa_handle_error(6, error_msg, "staging", path, d)
2007-09-02 09:46:35 +00:00
return sane
2007-01-21 21:28:51 +00:00
# Walk over all files in a directory and call func
def package_qa_walk(path, funcs, package,d):
2010-07-08 09:23:17 +00:00
import oe.qa
2007-09-02 09:46:35 +00:00
2010-07-08 09:23:17 +00:00
#if this will throw an exception, then fix the dict above
target_os = bb.data.getVar('TARGET_OS', d, True)
target_arch = bb.data.getVar('TARGET_ARCH', d, True)
sane = True
2007-01-21 21:28:51 +00:00
for root, dirs, files in os.walk(path):
for file in files:
path = os.path.join(root,file)
2011-03-01 18:42:28 +00:00
elf = oe.qa.ELFFile(path)
2010-07-08 09:23:17 +00:00
try:
elf.open()
except:
elf = None
2007-01-21 21:28:51 +00:00
for func in funcs:
2010-07-08 09:23:17 +00:00
if not func(path, package,d, elf):
2007-09-02 09:46:35 +00:00
sane = False
return sane
2007-01-21 21:28:51 +00:00
2010-07-08 09:23:17 +00:00
def package_qa_check_rdepends(pkg, pkgdest, d):
2007-09-02 09:46:35 +00:00
sane = True
2007-01-21 21:28:51 +00:00
if not "-dbg" in pkg and not "task-" in pkg and not "-image" in pkg:
# Copied from package_ipk.bbclass
# boiler plate to update the data
localdata = bb.data.createCopy(d)
2010-07-08 09:23:17 +00:00
root = "%s/%s" % (pkgdest, pkg)
2007-01-21 21:28:51 +00:00
bb.data.setVar('ROOT', '', localdata)
bb.data.setVar('ROOT_%s' % pkg, root, localdata)
2007-01-22 20:11:19 +00:00
pkgname = bb.data.getVar('PKG_%s' % pkg, localdata, True)
2007-01-21 21:28:51 +00:00
if not pkgname:
pkgname = pkg
bb.data.setVar('PKG', pkgname, localdata)
2010-08-23 14:26:38 +00:00
bb.data.setVar('OVERRIDES', pkg, localdata)
2007-01-21 21:28:51 +00:00
bb.data.update_data(localdata)
# Now check the RDEPENDS
2009-01-25 17:20:05 +00:00
rdepends = bb.utils.explode_deps(bb.data.getVar('RDEPENDS', localdata, True) or "")
2007-01-21 21:28:51 +00:00
# Now do the sanity check!!!
for rdepend in rdepends:
if "-dbg" in rdepend:
2008-03-19 15:53:07 +00:00
error_msg = "%s rdepends on %s" % (pkgname,rdepend)
sane = package_qa_handle_error(2, error_msg, pkgname, rdepend, d)
2007-09-02 09:46:35 +00:00
return sane
2007-01-21 21:28:51 +00:00
# The PACKAGE FUNC to scan each package
python do_package_qa () {
bb.note("DO PACKAGE QA")
2010-09-30 20:50:42 +00:00
logdir = bb.data.getVar('T', d, True)
pkg = bb.data.getVar('PN', d, True)
# Check the compile log for host contamination
compilelog = os.path.join(logdir,"log.do_compile")
statement = "grep -e 'CROSS COMPILE Badness:' -e 'is unsafe for cross-compilation' %s > /dev/null" % compilelog
if os.system(statement) == 0:
bb.warn("%s: The compile log indicates that host include and/or library paths were used. Please check the log '%s' for more information." % \
(pkg, compilelog))
# Check the install log for host contamination
installlog = os.path.join(logdir,"log.do_install")
statement = "grep -e 'CROSS COMPILE Badness:' -e 'is unsafe for cross-compilation' %s > /dev/null" % installlog
if os.system(statement) == 0:
bb.warn("%s: The install log indicates that host include and/or library paths were used. Please check the log '%s' for more information." % \
(pkg, installlog))
# Scan the packages...
2010-07-08 09:23:17 +00:00
pkgdest = bb.data.getVar('PKGDEST', d, True)
2007-01-21 21:28:51 +00:00
packages = bb.data.getVar('PACKAGES',d, True)
# no packages should be scanned
if not packages:
return
2010-07-08 09:23:17 +00:00
checks = [package_qa_check_rpath, package_qa_check_dev,
2008-03-19 15:53:07 +00:00
package_qa_check_perm, package_qa_check_arch,
2011-01-07 16:27:01 +00:00
package_qa_check_desktop, package_qa_hash_style,
2010-07-08 09:23:17 +00:00
package_qa_check_dbg]
2011-01-07 16:27:01 +00:00
# package_qa_check_buildpaths,
2007-09-02 09:46:35 +00:00
walk_sane = True
rdepends_sane = True
2007-01-21 21:28:51 +00:00
for package in packages.split():
2007-01-22 20:11:19 +00:00
if bb.data.getVar('INSANE_SKIP_' + package, d, True):
2007-01-22 19:41:29 +00:00
bb.note("Package: %s (skipped)" % package)
continue
2007-09-02 09:46:35 +00:00
bb.note("Checking Package: %s" % package)
2010-07-08 09:23:17 +00:00
path = "%s/%s" % (pkgdest, package)
2008-03-19 15:53:07 +00:00
if not package_qa_walk(path, checks, package, d):
2007-09-02 09:46:35 +00:00
walk_sane = False
2010-07-08 09:23:17 +00:00
if not package_qa_check_rdepends(package, pkgdest, d):
2007-09-02 09:46:35 +00:00
rdepends_sane = False
2010-05-11 23:25:39 +00:00
2010-07-15 08:35:53 +00:00
if not walk_sane or not rdepends_sane:
2007-09-02 09:46:35 +00:00
bb.fatal("QA run found fatal errors. Please consider fixing them.")
bb.note("DONE with PACKAGE QA")
2007-01-21 21:28:51 +00:00
}
python do_qa_staging() {
2007-09-02 09:46:35 +00:00
bb.note("QA checking staging")
2007-01-21 21:28:51 +00:00
2010-01-26 16:00:13 +00:00
if not package_qa_check_staged(bb.data.expand('${SYSROOT_DESTDIR}/${STAGING_LIBDIR}',d), d):
2007-09-02 09:46:35 +00:00
bb.fatal("QA staging was broken by the package built above")
}
python do_qa_configure() {
2009-12-19 12:29:14 +00:00
configs = []
2010-07-15 08:35:53 +00:00
workdir = bb.data.getVar('WORKDIR', d, True)
2009-12-19 12:29:14 +00:00
bb.note("Checking autotools environment for common misconfiguration")
2010-07-15 08:35:53 +00:00
for root, dirs, files in os.walk(workdir):
2010-09-30 20:50:42 +00:00
statement = "grep -e 'CROSS COMPILE Badness:' -e 'is unsafe for cross-compilation' %s > /dev/null" % \
2008-03-19 15:53:07 +00:00
os.path.join(root,"config.log")
2007-09-02 09:46:35 +00:00
if "config.log" in files:
2008-03-19 15:53:07 +00:00
if os.system(statement) == 0:
2011-02-08 16:05:46 +00:00
bb.fatal("""This autoconf log indicates errors, it looked at host include and/or library paths while determining system capabilities.
2008-03-19 15:53:07 +00:00
Rerun configure task after fixing this. The path was '%s'""" % root)
2009-12-19 12:29:14 +00:00
if "configure.ac" in files:
configs.append(os.path.join(root,"configure.ac"))
if "configure.in" in files:
configs.append(os.path.join(root, "configure.in"))
2010-03-29 21:28:49 +00:00
if "gettext" not in bb.data.getVar('P', d, True) and "gcc-runtime" not in bb.data.getVar('P', d, True):
2009-12-22 17:17:55 +00:00
if bb.data.inherits_class('native', d) or bb.data.inherits_class('cross', d) or bb.data.inherits_class('crosssdk', d) or bb.data.inherits_class('nativesdk', d):
gt = "gettext-native"
2010-01-14 11:37:56 +00:00
elif bb.data.inherits_class('cross-canadian', d):
2010-01-14 11:25:42 +00:00
gt = "gettext-nativesdk"
2009-12-22 17:17:55 +00:00
else:
2011-05-03 23:32:48 +00:00
gt = "virtual/gettext"
2009-12-22 17:17:55 +00:00
deps = bb.utils.explode_deps(bb.data.getVar('DEPENDS', d, True) or "")
if gt not in deps:
for config in configs:
gnu = "grep \"^[[:space:]]*AM_GNU_GETTEXT\" %s >/dev/null" % config
if os.system(gnu) == 0:
2010-01-06 10:50:06 +00:00
bb.fatal("""Gettext required but not in DEPENDS for file %s.
Missing inherit gettext?""" % config)
2010-07-15 08:35:53 +00:00
if not package_qa_check_license(workdir, d):
2011-01-06 02:18:55 +00:00
bb.fatal("Licensing Error: LIC_FILES_CHKSUM does not match, please fix")
2007-01-21 21:28:51 +00:00
}
2011-04-22 18:23:20 +00:00
# The Staging Func, to check all staging
#addtask qa_staging after do_populate_sysroot before do_build
do_populate_sysroot[postfuncs] += "do_qa_staging "
# Check broken config.log files, for packages requiring Gettext which don't
# have it in DEPENDS and for correct LIC_FILES_CHKSUM
#addtask qa_configure after do_configure before do_compile
do_configure[postfuncs] += "do_qa_configure "