bitbake: cooker: Fire BuildCompleted before finishing the command

Some handlers hook on BuildComplete so it avoids certain event races
to finish the command after the BuildComplete event is sent out.

This means the UI is available to handle events until the command
completes.

What appears to be a race on one of the sanity tests for event handlers
triggered this change although the failure is hard to reproduce.

[YOCTO #7921]

(Bitbake rev: e42d7c47a06fbb5981e0313478c8e3656b99f4e7)

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
Richard Purdie 2015-06-25 17:53:23 +01:00
parent d93bc4cf48
commit 00ca43be05
1 changed files with 2 additions and 2 deletions

View File

@ -1303,8 +1303,8 @@ class BBCooker:
return False
if not retval:
self.command.finishAsyncCommand(msg)
bb.event.fire(bb.event.BuildCompleted(len(rq.rqdata.runq_fnid), buildname, item, failures), self.expanded_data)
self.command.finishAsyncCommand(msg)
return False
if retval is True:
return True
@ -1336,8 +1336,8 @@ class BBCooker:
return False
if not retval:
self.command.finishAsyncCommand(msg)
bb.event.fire(bb.event.BuildCompleted(len(rq.rqdata.runq_fnid), buildname, targets, failures), self.data)
self.command.finishAsyncCommand(msg)
return False
if retval is True:
return True