sysmo-bts
/
generic-poky
9
0
Fork 0
Code Pull Requests Releases Activity

oe-selftest: replace assertTrue(False, ...) with fail(...) 

I'd somehow missed the existence of fail() when I wrote these. It's
preferable here so you don't get the somewhat useless "false is not
true" message in the case of failure.

(From OE-Core rev: 173a5896fff57136e1f15e15f90961416aadde94)

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
Paul Eggleton 2015-08-05 14:37:13 +01:00 committed by Richard Purdie
parent d114b561b1
commit 21f9844fa9
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
meta/lib/oeqa/selftest/devtool.py
View File

@ -51,7 +51,7 @@ class DevtoolBase(oeSelfTest):
bbappendfile = bbappend
break
else:
self.assertTrue(False, 'bbappend for recipe %s does not seem to be created in test layer' % testrecipe)
self.fail('bbappend for recipe %s does not seem to be created in test layer' % testrecipe)
return bbappendfile
def _create_temp_layer(self, templayerdir, addlayer, templayername, priority=999, recipepathspec='recipes-*/*'):

4
meta/lib/oeqa/selftest/recipetool.py
View File

@ -282,7 +282,7 @@ class RecipetoolTests(RecipetoolBase):
self.assertIn('add-file.patch', line, 'Unexpected warning found in output:\n%s' % line)
break
else:
self.assertTrue(False, 'Patch warning not found in output:\n%s' % output)
self.fail('Patch warning not found in output:\n%s' % output)
@testcase(1188)
def test_recipetool_appendfile_script(self):
@ -351,7 +351,7 @@ class RecipetoolTests(RecipetoolBase):
bbappendfile = f
break
if not bbappendfile:
self.assertTrue(False, 'No bbappend file created')
self.fail('No bbappend file created')
runCmd('rm -rf %s/recipes-*' % self.templayerdir)
return bbappendfile