From 54efca180ba02bd7a3d51d23ed426c7b31d06eda Mon Sep 17 00:00:00 2001 From: Paul Eggleton Date: Thu, 31 Aug 2017 11:46:22 +1200 Subject: [PATCH] classes/license: drop erroneous sha256 parameter in LIC_FILES_CHKSUM In OE-Core commit a48fea275b08ff3d3dfc9a928aeb04768db35873, a check on the value of a "sha256" parameter was added, however there was no mention of this in the commit message and no corresponding code to actually verify the checksum as sha256 was added along with it either, so there's no point in getting the value. Additionally it was assuming that a sha256 value would be present without checking first, with the result that if you leave out the md5 value in a recipe intentionally in order to get it to tell you the correct value on the next build, you got a traceback instead of the appropriate error containing the information. Drop this entirely - if we want to implement this we need to do it properly. (From OE-Core rev: e9eaa7d15fe7ab643ab19556dab84051f8f1974e) (From OE-Core rev: fcedfce43adad8659a1376bb28b1ed41e621dd53) Signed-off-by: Paul Eggleton Signed-off-by: Richard Purdie Signed-off-by: Armin Kuster Signed-off-by: Richard Purdie --- meta/classes/license.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/classes/license.bbclass b/meta/classes/license.bbclass index d4be478166..b1fffe70fe 100644 --- a/meta/classes/license.bbclass +++ b/meta/classes/license.bbclass @@ -491,7 +491,7 @@ def find_license_files(d): except bb.fetch.MalformedUrl: bb.fatal("%s: LIC_FILES_CHKSUM contains an invalid URL: %s" % (d.getVar('PF'), url)) # We want the license filename and path - chksum = parm['md5'] if 'md5' in parm else parm['sha256'] + chksum = parm.get('md5', None) beginline = parm.get('beginline') endline = parm.get('endline') lic_chksums[path] = (chksum, beginline, endline)