sysmo-bts
/
generic-poky
9
0
Fork 0
Code Pull Requests Releases Activity

bitbake: toaster: Remove Toaster exceptions section of build dashboard 

Fatal build errors were displayed as exceptions, and highlighted
with less severity than they deserved.

Roll back to treating Toaster exceptions as errors by removing
the toaster_exceptions member on Build objects and displaying
EXCEPTION events in the errors section on the dashboard.

[YOCTO #8320]

(Bitbake rev: 59197320bdcefddf06084e871f1b5b21b21cbb63)

Signed-off-by: Elliot Smith <elliot.smith@intel.com>
Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
Elliot Smith 2015-10-15 15:45:14 +03:00 committed by Richard Purdie
parent 93f0b61749
commit 65e8bde9f1
2 changed files with 4 additions and 45 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
bitbake/lib/toaster/orm/models.py
View File

@ -347,10 +347,6 @@ class Build(models.Model):
def get_outcome_text(self):
return Build.BUILD_OUTCOME[int(self.outcome)][1]
@property
def toaster_exceptions(self):
return self.logmessage_set.filter(level=LogMessage.EXCEPTION)
@property
def errors(self):
return (self.logmessage_set.filter(level=LogMessage.ERROR) |

45
bitbake/lib/toaster/toastergui/templates/builddashboard.html
View File

@ -44,14 +44,6 @@
{%endif%}
</div>
{% if build.toaster_exceptions.count > 0 %}
<div class="row">
<small class="pull-right">
<i class="icon-question-sign get-help get-help-blue" title="" data-original-title="Toaster exceptions do not affect your build: only the operation of Toaster"></i>
<a class="show-exceptions" href="#exceptions">Toaster threw {{build.toaster_exceptions.count}} exception{{build.toaster_exceptions.count|pluralize}}</a>
</small>
</div>
{% endif %}
</div>
</div>
@ -69,12 +61,10 @@
<div class="accordion-body collapse in" id="collapse-errors">
<div class="accordion-inner">
<div class="span10">
{% for error in logmessages %}
{% if error.level == 2 or error.level == 3 %}
<div class="alert alert-error">
<pre>{{error.message}}</pre>
</div>
{% endif %}
{% for error in build.errors %}
<div class="alert alert-error">
<pre>{{error.message}}</pre>
</div>
{% endfor %}
</div>
</div>
@ -271,33 +261,6 @@
</div>
{% endif %}
{% if build.toaster_exceptions.count > 0 %}
<div class="accordion span10 pull-right" id="exceptions">
<div class="accordion-group">
<div class="accordion-heading">
<a class="accordion-toggle exception toggle-exceptions">
<h2 id="exception-toggle">
<i class="icon-warning-sign"></i>
{{build.toaster_exceptions.count}} Toaster exception{{build.toaster_exceptions.count|pluralize}}
</h2>
</a>
</div>
<div class="accordion-body collapse" id="collapse-exceptions">
<div class="accordion-inner">
<div class="span10">
{% for exception in build.toaster_exceptions %}
<div class="alert alert-exception">
<pre>{{exception.message}}</pre>
</div>
{% endfor %}
</div>
</div>
</div>
</div>
</div>
{% endif %}
<script type="text/javascript">
$(document).ready(function() {
//show warnings section when requested from the previous page