sysmo-bts
/
generic-poky
9
0
Fork 0
Code Pull Requests Releases Activity

gst-player: Disable visualizations 

On some machines, visualizations in gst-player trigger a bug in
xvimagesink. Till we have a proper fix, disable the visualization
rather than downgrading the xvimagesink.

Fixes [YOCTO #10041]

(From OE-Core rev: b79d1bf49b56a97216fb719ac19e4dd9022f15b4)

Signed-off-by: Maxin B. John <maxin.john@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
Maxin B. John 2016-09-25 21:40:05 +03:00 committed by Richard Purdie
parent 013fff4639
commit 850ded308c
2 changed files with 37 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
meta/recipes-multimedia/gstreamer/gst-player/0001-Disable-visualizations-by-default.patch Normal file
View File

@ -0,0 +1,36 @@
From 93e1838f8b8704e4d7d71965f61bee931377b080 Mon Sep 17 00:00:00 2001
From: Jussi Kukkonen <jussi.kukkonen@intel.com>
Date: Thu, 22 Sep 2016 19:26:40 +0300
Subject: [PATCH] Disable visualizations by default
As documented in [YOCTO #10041] visualizations trigger a bug in
xvimagesink on some hardware, which prevents playback in the
mediaplayer. Disable visualizations until the xv issue is solved
to enable playback QA.
Upstream-Status: Inappropriate [workaround]
Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com>
Signed-off-by: Maxin B. John <maxin.john@intel.com>
---
gtk/gtk-play.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/gtk/gtk-play.c b/gtk/gtk-play.c
index 8ae0fea..322e599 100644
--- a/gtk/gtk-play.c
+++ b/gtk/gtk-play.c
@@ -1751,9 +1751,8 @@ gtk_play_constructor (GType type, guint n_construct_params,
g_signal_connect (self->player, "volume-changed",
G_CALLBACK (player_volume_changed_cb), self);
- /* enable visualization (by default playbin uses goom) */
- /* if visualization is enabled then use the first element */
- gst_player_set_visualization_enabled (self->player, TRUE);
+ /* Disable visualization by default */
+ gst_player_set_visualization_enabled (self->player, FALSE);
g_signal_connect (G_OBJECT (self), "show", G_CALLBACK (show_cb), NULL);
--
2.4.0

1
meta/recipes-multimedia/gstreamer/gst-player_git.bb
View File

@ -9,6 +9,7 @@ SRC_URI = "git://github.com/sdroege/gst-player.git \
file://Fix-pause-play.patch;apply=0 \
file://Add-error-signal-emission-for-missing-plugins.patch;apply=0 \
file://0001-gtk-play-provide-similar-behaviour-for-quit-and-clos.patch \
file://0001-Disable-visualizations-by-default.patch \
file://gst-player.desktop"
SRCREV = "ea90e63c1064503f9ba5d59aa4ca604f13ca5def"