From c2ac78c4d8fb6aa85a6787cf170ea7f06659d2eb Mon Sep 17 00:00:00 2001 From: Paul Eggleton Date: Thu, 30 Mar 2017 15:23:59 +1300 Subject: [PATCH] bitbake: tinfoil: fix get_recipe_file() to return an error on invalid recipe This function calls cooker.findBestProvider() but didn't handle the fact that that function returns a tuple (None, None, None, None) when there is no matching recipe. (This fixes devtool in OpenEmbedded showing a traceback when an invalid recipe is specified instead of a proper error message.) (Bitbake rev: 54a4757ca706afc6e98c7692f960592e80cab12b) Signed-off-by: Paul Eggleton Signed-off-by: Richard Purdie --- bitbake/lib/bb/tinfoil.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bitbake/lib/bb/tinfoil.py b/bitbake/lib/bb/tinfoil.py index c2ee707298..14a2271cd2 100644 --- a/bitbake/lib/bb/tinfoil.py +++ b/bitbake/lib/bb/tinfoil.py @@ -363,7 +363,7 @@ class Tinfoil: skipped. """ best = self.find_best_provider(pn) - if not best: + if not best or (len(best) > 3 and not best[3]): skiplist = self.get_skipped_recipes() taskdata = bb.taskdata.TaskData(None, skiplist=skiplist) skipreasons = taskdata.get_reasons(pn)