tiff: Security fix CVE-2015-8781
CVE-2015-8781 libtiff: out-of-bounds writes for invalid images External Reference: https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2015-8781 (From OE-Core rev: 9e97ff5582fab9f157ecd970c7c3559265210131) Signed-off-by: Armin Kuster <akuster@mvista.com> Signed-off-by: Yi Zhao <yi.zhao@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
parent
955d6cb60f
commit
dc75fc92b5
|
@ -0,0 +1,195 @@
|
||||||
|
From aaab5c3c9d2a2c6984f23ccbc79702610439bc65 Mon Sep 17 00:00:00 2001
|
||||||
|
From: erouault <erouault>
|
||||||
|
Date: Sun, 27 Dec 2015 16:25:11 +0000
|
||||||
|
Subject: [PATCH] * libtiff/tif_luv.c: fix potential out-of-bound writes in
|
||||||
|
decode functions in non debug builds by replacing assert()s by regular if
|
||||||
|
checks (bugzilla #2522). Fix potential out-of-bound reads in case of short
|
||||||
|
input data.
|
||||||
|
|
||||||
|
Upstream-Status: Backport
|
||||||
|
|
||||||
|
https://github.com/vadz/libtiff/commit/aaab5c3c9d2a2c6984f23ccbc79702610439bc65
|
||||||
|
hand applied Changelog changes
|
||||||
|
|
||||||
|
CVE: CVE-2015-8781
|
||||||
|
|
||||||
|
Signed-off-by: Armin Kuster <akuster@mvista.com>
|
||||||
|
---
|
||||||
|
ChangeLog | 7 +++++++
|
||||||
|
libtiff/tif_luv.c | 55 ++++++++++++++++++++++++++++++++++++++++++++-----------
|
||||||
|
2 files changed, 51 insertions(+), 11 deletions(-)
|
||||||
|
|
||||||
|
Index: tiff-4.0.4/ChangeLog
|
||||||
|
===================================================================
|
||||||
|
--- tiff-4.0.4.orig/ChangeLog
|
||||||
|
+++ tiff-4.0.4/ChangeLog
|
||||||
|
@@ -1,3 +1,10 @@
|
||||||
|
+2015-12-27 Even Rouault <even.rouault at spatialys.com>
|
||||||
|
+
|
||||||
|
+ * libtiff/tif_luv.c: fix potential out-of-bound writes in decode
|
||||||
|
+ functions in non debug builds by replacing assert()s by regular if
|
||||||
|
+ checks (bugzilla #2522).
|
||||||
|
+ Fix potential out-of-bound reads in case of short input data.
|
||||||
|
+
|
||||||
|
2015-12-26 Even Rouault <even.rouault at spatialys.com>
|
||||||
|
|
||||||
|
* libtiff/tif_getimage.c: fix out-of-bound reads in TIFFRGBAImage
|
||||||
|
Index: tiff-4.0.4/libtiff/tif_luv.c
|
||||||
|
===================================================================
|
||||||
|
--- tiff-4.0.4.orig/libtiff/tif_luv.c
|
||||||
|
+++ tiff-4.0.4/libtiff/tif_luv.c
|
||||||
|
@@ -202,7 +202,11 @@ LogL16Decode(TIFF* tif, uint8* op, tmsiz
|
||||||
|
if (sp->user_datafmt == SGILOGDATAFMT_16BIT)
|
||||||
|
tp = (int16*) op;
|
||||||
|
else {
|
||||||
|
- assert(sp->tbuflen >= npixels);
|
||||||
|
+ if(sp->tbuflen < npixels) {
|
||||||
|
+ TIFFErrorExt(tif->tif_clientdata, module,
|
||||||
|
+ "Translation buffer too short");
|
||||||
|
+ return (0);
|
||||||
|
+ }
|
||||||
|
tp = (int16*) sp->tbuf;
|
||||||
|
}
|
||||||
|
_TIFFmemset((void*) tp, 0, npixels*sizeof (tp[0]));
|
||||||
|
@@ -211,9 +215,11 @@ LogL16Decode(TIFF* tif, uint8* op, tmsiz
|
||||||
|
cc = tif->tif_rawcc;
|
||||||
|
/* get each byte string */
|
||||||
|
for (shft = 2*8; (shft -= 8) >= 0; ) {
|
||||||
|
- for (i = 0; i < npixels && cc > 0; )
|
||||||
|
+ for (i = 0; i < npixels && cc > 0; ) {
|
||||||
|
if (*bp >= 128) { /* run */
|
||||||
|
- rc = *bp++ + (2-128); /* TODO: potential input buffer overrun when decoding corrupt or truncated data */
|
||||||
|
+ if( cc < 2 )
|
||||||
|
+ break;
|
||||||
|
+ rc = *bp++ + (2-128);
|
||||||
|
b = (int16)(*bp++ << shft);
|
||||||
|
cc -= 2;
|
||||||
|
while (rc-- && i < npixels)
|
||||||
|
@@ -223,6 +229,7 @@ LogL16Decode(TIFF* tif, uint8* op, tmsiz
|
||||||
|
while (--cc && rc-- && i < npixels)
|
||||||
|
tp[i++] |= (int16)*bp++ << shft;
|
||||||
|
}
|
||||||
|
+ }
|
||||||
|
if (i != npixels) {
|
||||||
|
#if defined(__WIN32__) && (defined(_MSC_VER) || defined(__MINGW32__))
|
||||||
|
TIFFErrorExt(tif->tif_clientdata, module,
|
||||||
|
@@ -268,13 +275,17 @@ LogLuvDecode24(TIFF* tif, uint8* op, tms
|
||||||
|
if (sp->user_datafmt == SGILOGDATAFMT_RAW)
|
||||||
|
tp = (uint32 *)op;
|
||||||
|
else {
|
||||||
|
- assert(sp->tbuflen >= npixels);
|
||||||
|
+ if(sp->tbuflen < npixels) {
|
||||||
|
+ TIFFErrorExt(tif->tif_clientdata, module,
|
||||||
|
+ "Translation buffer too short");
|
||||||
|
+ return (0);
|
||||||
|
+ }
|
||||||
|
tp = (uint32 *) sp->tbuf;
|
||||||
|
}
|
||||||
|
/* copy to array of uint32 */
|
||||||
|
bp = (unsigned char*) tif->tif_rawcp;
|
||||||
|
cc = tif->tif_rawcc;
|
||||||
|
- for (i = 0; i < npixels && cc > 0; i++) {
|
||||||
|
+ for (i = 0; i < npixels && cc >= 3; i++) {
|
||||||
|
tp[i] = bp[0] << 16 | bp[1] << 8 | bp[2];
|
||||||
|
bp += 3;
|
||||||
|
cc -= 3;
|
||||||
|
@@ -325,7 +336,11 @@ LogLuvDecode32(TIFF* tif, uint8* op, tms
|
||||||
|
if (sp->user_datafmt == SGILOGDATAFMT_RAW)
|
||||||
|
tp = (uint32*) op;
|
||||||
|
else {
|
||||||
|
- assert(sp->tbuflen >= npixels);
|
||||||
|
+ if(sp->tbuflen < npixels) {
|
||||||
|
+ TIFFErrorExt(tif->tif_clientdata, module,
|
||||||
|
+ "Translation buffer too short");
|
||||||
|
+ return (0);
|
||||||
|
+ }
|
||||||
|
tp = (uint32*) sp->tbuf;
|
||||||
|
}
|
||||||
|
_TIFFmemset((void*) tp, 0, npixels*sizeof (tp[0]));
|
||||||
|
@@ -334,11 +349,13 @@ LogLuvDecode32(TIFF* tif, uint8* op, tms
|
||||||
|
cc = tif->tif_rawcc;
|
||||||
|
/* get each byte string */
|
||||||
|
for (shft = 4*8; (shft -= 8) >= 0; ) {
|
||||||
|
- for (i = 0; i < npixels && cc > 0; )
|
||||||
|
+ for (i = 0; i < npixels && cc > 0; ) {
|
||||||
|
if (*bp >= 128) { /* run */
|
||||||
|
+ if( cc < 2 )
|
||||||
|
+ break;
|
||||||
|
rc = *bp++ + (2-128);
|
||||||
|
b = (uint32)*bp++ << shft;
|
||||||
|
- cc -= 2; /* TODO: potential input buffer overrun when decoding corrupt or truncated data */
|
||||||
|
+ cc -= 2;
|
||||||
|
while (rc-- && i < npixels)
|
||||||
|
tp[i++] |= b;
|
||||||
|
} else { /* non-run */
|
||||||
|
@@ -346,6 +363,7 @@ LogLuvDecode32(TIFF* tif, uint8* op, tms
|
||||||
|
while (--cc && rc-- && i < npixels)
|
||||||
|
tp[i++] |= (uint32)*bp++ << shft;
|
||||||
|
}
|
||||||
|
+ }
|
||||||
|
if (i != npixels) {
|
||||||
|
#if defined(__WIN32__) && (defined(_MSC_VER) || defined(__MINGW32__))
|
||||||
|
TIFFErrorExt(tif->tif_clientdata, module,
|
||||||
|
@@ -413,6 +431,7 @@ LogLuvDecodeTile(TIFF* tif, uint8* bp, t
|
||||||
|
static int
|
||||||
|
LogL16Encode(TIFF* tif, uint8* bp, tmsize_t cc, uint16 s)
|
||||||
|
{
|
||||||
|
+ static const char module[] = "LogL16Encode";
|
||||||
|
LogLuvState* sp = EncoderState(tif);
|
||||||
|
int shft;
|
||||||
|
tmsize_t i;
|
||||||
|
@@ -433,7 +452,11 @@ LogL16Encode(TIFF* tif, uint8* bp, tmsiz
|
||||||
|
tp = (int16*) bp;
|
||||||
|
else {
|
||||||
|
tp = (int16*) sp->tbuf;
|
||||||
|
- assert(sp->tbuflen >= npixels);
|
||||||
|
+ if(sp->tbuflen < npixels) {
|
||||||
|
+ TIFFErrorExt(tif->tif_clientdata, module,
|
||||||
|
+ "Translation buffer too short");
|
||||||
|
+ return (0);
|
||||||
|
+ }
|
||||||
|
(*sp->tfunc)(sp, bp, npixels);
|
||||||
|
}
|
||||||
|
/* compress each byte string */
|
||||||
|
@@ -506,6 +529,7 @@ LogL16Encode(TIFF* tif, uint8* bp, tmsiz
|
||||||
|
static int
|
||||||
|
LogLuvEncode24(TIFF* tif, uint8* bp, tmsize_t cc, uint16 s)
|
||||||
|
{
|
||||||
|
+ static const char module[] = "LogLuvEncode24";
|
||||||
|
LogLuvState* sp = EncoderState(tif);
|
||||||
|
tmsize_t i;
|
||||||
|
tmsize_t npixels;
|
||||||
|
@@ -521,7 +545,11 @@ LogLuvEncode24(TIFF* tif, uint8* bp, tms
|
||||||
|
tp = (uint32*) bp;
|
||||||
|
else {
|
||||||
|
tp = (uint32*) sp->tbuf;
|
||||||
|
- assert(sp->tbuflen >= npixels);
|
||||||
|
+ if(sp->tbuflen < npixels) {
|
||||||
|
+ TIFFErrorExt(tif->tif_clientdata, module,
|
||||||
|
+ "Translation buffer too short");
|
||||||
|
+ return (0);
|
||||||
|
+ }
|
||||||
|
(*sp->tfunc)(sp, bp, npixels);
|
||||||
|
}
|
||||||
|
/* write out encoded pixels */
|
||||||
|
@@ -553,6 +581,7 @@ LogLuvEncode24(TIFF* tif, uint8* bp, tms
|
||||||
|
static int
|
||||||
|
LogLuvEncode32(TIFF* tif, uint8* bp, tmsize_t cc, uint16 s)
|
||||||
|
{
|
||||||
|
+ static const char module[] = "LogLuvEncode32";
|
||||||
|
LogLuvState* sp = EncoderState(tif);
|
||||||
|
int shft;
|
||||||
|
tmsize_t i;
|
||||||
|
@@ -574,7 +603,11 @@ LogLuvEncode32(TIFF* tif, uint8* bp, tms
|
||||||
|
tp = (uint32*) bp;
|
||||||
|
else {
|
||||||
|
tp = (uint32*) sp->tbuf;
|
||||||
|
- assert(sp->tbuflen >= npixels);
|
||||||
|
+ if(sp->tbuflen < npixels) {
|
||||||
|
+ TIFFErrorExt(tif->tif_clientdata, module,
|
||||||
|
+ "Translation buffer too short");
|
||||||
|
+ return (0);
|
||||||
|
+ }
|
||||||
|
(*sp->tfunc)(sp, bp, npixels);
|
||||||
|
}
|
||||||
|
/* compress each byte string */
|
|
@ -6,6 +6,7 @@ HOMEPAGE = "http://www.remotesensing.org/libtiff/"
|
||||||
SRC_URI = "ftp://ftp.remotesensing.org/pub/libtiff/tiff-${PV}.tar.gz \
|
SRC_URI = "ftp://ftp.remotesensing.org/pub/libtiff/tiff-${PV}.tar.gz \
|
||||||
file://libtool2.patch \
|
file://libtool2.patch \
|
||||||
file://CVE-2015-8665_8683.patch \
|
file://CVE-2015-8665_8683.patch \
|
||||||
|
file://CVE-2015-8781.patch \
|
||||||
"
|
"
|
||||||
|
|
||||||
SRC_URI[md5sum] = "d1d2e940dea0b5ad435f21f03d96dd72"
|
SRC_URI[md5sum] = "d1d2e940dea0b5ad435f21f03d96dd72"
|
||||||
|
|
Loading…
Reference in New Issue