Because we have hob icon, so need to make some gtk icon to transfer to hob icon. so use hob icon checker to fixed the gtk icon
[YOCTO #2108]
(From Poky rev: d1d84e5529e0d0752fdcd8d3458ed7595d373115)
(Bitbake rev: 65bbc07a3557ac760c6b900880ea6ae2937afde3)
Signed-off-by: Liming An <limingx.l.an@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
fixed the bug of 'error' and 'warning' icon is not constaintly with hob ui design
[YOCTO #2097]
(From Poky rev: 5b4f379b5341222e2678043f078b3d33c0556a86)
(Bitbake rev: 3807a95cd48a01486b3ecd5360a59ddfc3a3b6d6)
Signed-off-by: Liming An <limingx.l.an@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
add a refresh icon to indicator the running task, for avoid add more heavy to bitbake building process, increased the timer interval counter, and decreased the refresh icon render size.
(From Poky rev: cf76d2cef0905a442e61769560173b2e6a58fb62)
(Bitbake rev: d5923a484f80bc1577f78035152c2d0728e4a1f3)
Signed-off-by: Liming An <limingx.l.an@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Use HobAltButton, rather than gtk.LinkButton, for the 'View files'
button.
Use xdg-open to display the folders contents.
(From Poky rev: 22955b47ac485e0d069ddd8301a11658d76bcfee)
(Bitbake rev: 9647c188c0d06ec045c15281eae785e935c25d2b)
Signed-off-by: Joshua Lock <josh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Tweak the table layout and insert some dummy widgets when the buttons
aren't drawn such that when the buttons do get drawn the existing widgets
don't all jump up.
(From Poky rev: 9edd833e7e36aea6a7350a36a5aad0ef300959c4)
(Bitbake rev: c09f71414d459eb926aa567d90a63407407d173e)
Signed-off-by: Joshua Lock <josh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Use two lines to display the active task and recipe, per visual design.
(From Poky rev: ea61503fc439e033b341bb7a50bac77c5e88834e)
(Bitbake rev: ab508907308e8b1bc1b097df1f583dffd7ef25af)
Signed-off-by: Joshua Lock <josh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The design calls for primary buttons which are orange and large and
secondary buttons which are subtle with pale blue text. This is so that the
user is drawn towards the primary action and their use of the application
is more guided.
This patch uses HobButton and HobAltButton classes to style all dialogue
buttons accordingly.
Fixes [YOCTO #2125]
(From Poky rev: 1a52fe9f9e79f33686bd92613fc93eb97daacab8)
(Bitbake rev: 723ad434d427398b202b70f27762878315ffb22c)
Signed-off-by: Joshua Lock <josh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This patch is to add build status (incl. "Running task XX of XX: XXXXXX") in the build details screen,
in order to provide clear information about task in progress and make the GUI close to the visual design.
[Yocto #2098]
(Bitbake rev: 02d3451b2e0744204a1280f9effe9fd862bb4faf)
Signed-off-by: Shane Wang <shane.wang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The persistent tooltip looks a little weird when it's too small, request
that the toolkit and WM give it a reasonable minimum size.
(Bitbake rev: 637ea3671dda9c5a1065f992fd9ee87d63043cf4)
Signed-off-by: Joshua Lock <josh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The design documents have the close button vertically aligned with the
tooltip contents - reorganise the interal widget layout to achieve this.
(Bitbake rev: 4f8c36226867291c7b6c413ee2570d61a326ec47)
Signed-off-by: Joshua Lock <josh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The design calls for all buttons to match the style of either the HobButton
or HobAltButton classes, therefore implement the styling logic as static
methods of the implementing classes so that we can more easily set styles
for the buttons created by a gtk.Dialog (or subclass) without having to
modify too much of the dialog instantiation code.
(Bitbake rev: ccb8f5cd52ee7833129583b9201c65d93cb87d56)
Signed-off-by: Joshua Lock <josh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The buttons taking the user back to image configuration should be prefixed
with '<<'.
(Bitbake rev: e0d598b454c01303a0ea9503feef3ce6f1ed1d69)
Signed-off-by: Joshua Lock <josh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Use an alternative, grey, colour when the button is insensitive so that
the insensitivity is easily noticed.
(Bitbake rev: 53af6a962aa2f6b4d68d59792be9c7f33cf887b4)
Signed-off-by: Joshua Lock <josh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The two layers which cannot be removed, meta and meta-hob, should be the
first two items in the tree view.
(Bitbake rev: 6e51643325611f6cfc9090dcbbff20755d09c92d)
Signed-off-by: Joshua Lock <josh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Correct some apparent misspellings of BB_NUMBER_THREADS.
(Bitbake rev: 175e55db8f0762a2f2f0aaf3ca48169016b9ef6b)
Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
We should get TMPDIR from bitbake server instead of hardcode.
(Bitbake rev: 91bdd43468448385e07a57ac54ce25db9a8edf03)
Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
In Hob advanced setting, if "defaultsetup" is selected, we need to
leave DISTRO variable not set in bitbake server.
Otherwise, defaultsetup.conf will be parsed twice, causing TMPDIR and
its related variables mess up.
(Bitbake rev: 863b14ebf2c7443ce6df362f24af6395e520edbc)
Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Implement the filter for runqemu and deployment functionality.
runqemu
1) suffix should be in the list of RUNNABLE_IMAGE_TYPES.
2) machine should match the pattern of RUNNABLE_MACHINE_PATTERNS.
deployment:
1) suffix should be in the list of DEPLOYMENT_IMAGE_TYPES.
(Bitbake rev: de4d09a8d100b81622300db5f46627c649812abd)
Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This change allows adding extra inherits before getting all the
parameters.
(Bitbake rev: eb993c0bad03718f9d3e133667cd0fefca23611a)
Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
When creating label in recipeselectionpage.py, the builder's
configuration may not be ready yet, so create an empty label in
initialization.
(Bitbake rev: e4f22f6242f489afcadac67cc8dd282936b78586)
Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The ASYNC commands can automatically detect if BB file parsing is needed.
Therefore remove this explicit parsing command.
(Bitbake rev: 73692cb55d7d5aaedfbcf6b8a24ab435a1d25a9e)
Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Change the text of view_recipe_button to 'Add/remove recipes and tasks'
Change the text of view_packages_button to 'Add/remove previously built packages'
[Yocto #2146]
(Bitbake rev: 0348ef08db9ac425d83126d2e6eb465adc28b110)
Signed-off-by: Shane Wang <shane.wang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
For make the building screen to provide clear information about task in progress by request, so add this function.
At the beginning of building, the vertical scroll bar will go to the active area automatically.
Once the user moves the scroll bar in the middle, the automatic move of the bar is disabled.
However, once the user moves it to the bottom again, it will be kept to the bottom even though more logs come.
[Yocto #2098]
(Bitbake rev: cf43be6685d45c66e6508bbce653f8a67db66a9b)
Signed-off-by: Liming An <limingx.l.an@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This patch is not to show the horizontal scroll bar for building log, and add CellRendererText class to wrap the text.
[Yocto #2091]
(Bitbake rev: 7c5e1297c1af2edd46315e3dec4516f850d5e222)
Signed-off-by: Liming An <limingx.l.an@intel.com>
Signed-off-by: Shane Wang <shane.wang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Replace all gtk.Button instances that have the orange style applied with
HobButton.
(Bitbake rev: f4dfdc23a6498fdaa164a1bfccf616ff8fcbd251)
Signed-off-by: Joshua Lock <josh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The design uses a big, bold labelled, orange button for the primary action
on each dialogue. The HobButton implements this design as a reusable widget.
HobButton makes use of Pango Markup to use a relative size, x-large, for
the button text to ensure it's relative to the system configured font
sizes.
(Bitbake rev: 9aa477f7bd16d3e360bf9b51c1f9d5032a6c5288)
Signed-off-by: Joshua Lock <josh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Design calls for these buttons to include << at the beginning of the label
(Bitbake rev: 08cc5ec196a51c29f936eccba1644607be2ed759)
Signed-off-by: Joshua Lock <josh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The visual design calls for the alternative button to have a pale blue
colour.
(Bitbake rev: c9f61765216a013c7ebc02157ea47c3478252e7c)
Signed-off-by: Joshua Lock <josh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Use a separate, pre-lit, icon when the button has the cursor over it.
(Bitbake rev: 535d23921dfb7310022099d39b1092edfee51c1a)
Signed-off-by: Joshua Lock <josh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Per discussion with the design team the LayerSelectionDialog should only
have a close button.
See: https://bugzilla.yoctoproject.org/show_bug.cgi?id=2083#c10
(Bitbake rev: 65d92efe2786f21b8a2790ef0383f87b6dc15b57)
Signed-off-by: Joshua Lock <josh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
HobImageButton is an gtk.Button subclass, and therefore behaves like a
button with prelight and focus states, with an icon and two lines of text -
primary and secondary. The secondary text is displayed in a lighter colour
using a new module method, soften_color(), per the design.
(Bitbake rev: b91cc96c4ff4195ac26fdfd1fb0c2ff8db06aff8)
Signed-off-by: Joshua Lock <josh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Add add-hover and remove-hover icons for the Layer Selection Dialogue.
Autocrop layers_hover, packages_hover and recipe_hover images.
Signed-off-by: Joshua Lock <josh@linux.intel.com>
The Hob GUI requires the meta-hob layer to function so prevent its removal
as we do with the core meta layer.
(From Poky rev: a64d71e1e4475236e286cb20dde29c4d099d3693)
(Bitbake rev: 431624678025b3d3fe04f1c6e8fc50820b3129fb)
Signed-off-by: Joshua Lock <josh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The layer dialogue design includes in-line remove/delete widgets next to
the layer path in the tree view for all layers other than the meta layer as
well as an in-line notice that the meta layer cannot be removed.
This is achieved in this patch through the use of custom cell_data_func's
for the treeview to render the meta layer differently and a custom
CellRenderer implementation, CellRendererPixbufActivatable, which renders a
pixbuf and emits a clicked signal when the user clicks on it.
Fixes [YOCTO #2083]
(From Poky rev: 83c96b7a0ec4412716090098385a665045909a9a)
(Bitbake rev: b2d8f28c0059992200457a15aef8be09e015a5dd)
Signed-off-by: Joshua Lock <josh@linux.intel.com>
Signed-off-by: Shane Wang <shane.wang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Remove transparent border from the edge of the layers_display,
packages_display and recipe_display images.
(From Poky rev: d240f17687f34a0c5733a7744e8689420f45381c)
(Bitbake rev: e439de09eb073a50e12021b196f10fc87e33b858)
Signed-off-by: Joshua Lock <josh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This adds a gtk.Button subclass for secondary actions which unsets the
relief so that the user is aware that the button is clickable and yet it is
more subtle than the primary action (such that the primary action is the
most obvious one) - this is per the interaction design.
Further we replace all uses of gtk.LinkButton with the new HobAltButton
Partially addresses [YOCTO #2105], a follow on patch will theme the button
so that it matches the visual design.
(From Poky rev: c3f17fed243180678264168968333463b203bfa0)
(Bitbake rev: 601521c2d7f5568d94529a77b2cbe19fef7cbf48)
Signed-off-by: Joshua Lock <josh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
We use 4 spaces, not a tab, in BitBake
(From Poky rev: 7d9c9fd7c267d69bab51590074d66a2d68e98ca6)
(Bitbake rev: 7658cd6d8e0e558f60df72b294019a40c27bc703)
Signed-off-by: Joshua Lock <josh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Darker gtk+ themes, such as the one used in Ubuntu Unity, revealed that the
PersistentTooltip styling wasn't setting the label colour correctly.
Set the label foreground colour to the tooltip_fg_colour value as read from
gtk-color-scheme property of the system settings.
(From Poky rev: 0934cfcea5986dbdc50e7159ee907c70b0b3e587)
(Bitbake rev: ab15ef585e51e4c85a4a55aa6b35fbf3b53f3805)
Signed-off-by: Joshua Lock <josh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Change the layout and borders so that the close button is flush with the
edge of the tooltip window yet leave the contents with a small border such
that text isn't flush with the window edge.
(From Poky rev: 5a0891d144de5d3f73c51adef5a30492a679c66a)
(Bitbake rev: f652d9d28d69a04bc9361599d173625378ac8d33)
Signed-off-by: Joshua Lock <josh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
It's a common pattern on Gtk+ desktops to be able to clear a search/filter
entry using an icon in that entry.
(From Poky rev: 6394283522ef2f259397d8bd294291fb20354c8b)
(Bitbake rev: f55372d542995fd0797b11f42dcfdbe57858449a)
Signed-off-by: Joshua Lock <josh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Previously we use pattern "-image-" to match recipe name to judge if
it is image type. This will ignore some images whose name doesn't
match the pattern. The new method is to use the inherit information,
that is, if a recipe inherits image.bbclass, we treat it as an image.
(From Poky rev: 981b81bd39529d2ba9af0d4e2a25bda3d32bd8fc)
(Bitbake rev: bdbee0c899e115ad08b9a77d3e58d6767766da75)
Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Liming An
Joshua Lock
Shane Wang
Robert P. J. Day
Dongxiao Xu
Richard Purdie