This silences one of the QA warnings.
(From OE-Core rev: 3412a1d69201951dd097e4d9a4abcec124d34d68)
Signed-off-by: Christopher Larson <kergoth@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This is a newly installed directory and Makefile that is not needed
in an embedded setup
It fixes:
ERROR: For recipe eglibc, the following files/directories were installed but not shipped in any package:
ERROR: /var
ERROR: /var/db
ERROR: /var/db/Makefile
(From OE-Core rev: 35b5fb2dd2131d4c7dc6635c14c6e08ea6926457)
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The -mabi option is part of HOST_CC_ARCH which does not
appear in CFLAGS. This is for completeness since compiler
already defaults to n64 it wont matter that much
(From OE-Core rev: 2aa0540515efc15957101e24224b425ee00446d9)
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
uclibc has recently got posix_spawn implementation
and the implementation resided in librt so we link
-lrt to get the configure tests using uclibc provided
definitions and not the gnu-lib wrappers
Let libintl.a live in -staticdev package
(From OE-Core rev: 68e07a5ff114b5f413a5eeedeb551d82bc77774c)
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Currently we stub out iconv in glib when building
for uclibc which is not needed and infact results
in building systems with false hope of having
iconv and they misbehave during runtime
(From OE-Core rev: d13b1dc1897af733cc2ec22df50ae9d1fd0b48af)
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Modified the uclibc PACKAGES list order to ensure the uclibc-dev package is
processed before uclibc-staticdev to allow *_nonshared.a libraries to be
packaged in the uclibc-dev package. The *_nonshared.a libraries are required
by the SDK.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Use update-alternatives and sync to the way the replace kbd package
does things. Using update-alternatives ensures that the proper provides
are setup in the packages.
(From OE-Core rev: 9c2aa2da7cb9ceec02c5d42d18a623a51f922cea)
Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Change to use ALTERNATIVE_LINKS from update-alternatives. This ensures
the links are created consistently and the package provides are
correct.
(From OE-Core rev: 728569a3db005a935e6b08d6aac3e23e88d486df)
Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
There are issues with the current unionfs when making a union mount over "/".
Until these are resolved we can't use unionfs for live booting so disable this
temporarily as a workaround.
unionfs is usable in other circumstances.
[YOCTO #2331 workaround]
(From OE-Core rev: 60ee26ae23132b916019d58e20b8c2e1ddd2b471)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Remove BB_NO_NETWORK because we can not guarentee that all
downloads will be available in the self-hosted image for
the possible targets being built. If this image is run with
out networking, failures may be seen and BB_NO_NETWORK
should be set via the Hob
Update the Poky SRCREV so it has the latest set of fixes and
patches.
(From OE-Core rev: 70541d5e82ee05289eb0095bed4b121d12a00729)
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The lsb package is needed to enable the distro checking
in the self hosted image. Currently there is no standard
identification in the self-hosted image so use the existing
lsb package which provides lsb_release that parses the
/etc/release file
(From OE-Core rev: 1373865ce7f205a8e63f42caf436e9e2f7a565f5)
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Generally distros keep perl at /usr/bin/perl
Fedora 17 also has /bin/perl
this causes glib-2.0 build on such distros to put perl interpreter path in
the perl scripts as /bin/perl
But we set perl location for target as /usr/bin/perl
This mismatch of perl path causes failure of rootfs image creation
like this:
| error: Failed dependencies:
| /bin/perl is needed by libglib-2.0-utils-2.30.3-r0.ppc603e
NOTE: package meta-toolchain-gmae-1.0-r7: task do_populate_sdk: Failed
[YOCTO #2304]
(From OE-Core rev: 13e6e316d751d0ea3107d5547f6bdd2b74919cad)
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
We need consistent configuration files for opkg so we might as well always use
the full list. This is equal to PACKAGE_ARCHS in the non-multilib case.
This fixes various multilib failures with ipk multilibs.
(From OE-Core rev: bc85abc5013d0c831cc3c3823df45536c293aaba)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Re-running the debug_patch task would cause the build to fail. This patch
moves the extra patch handling directly into SRC_URI and removes the need
for the separate task, allowing safe re-execution of each task.
[YOCTO #2194]
(From OE-Core rev: 1d6156e37ef0f36cf5ce8eeaaf23560215c86833)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This avoids a number of bogus preferred providers warnings too.
(From OE-Core rev: 823a2f96df84547216a26697838977a162f838c5)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Generally distros keep perl at /sur/bin/perl
Fedora 17 alpha also has /bin/perl
this causes eglibc build on such distros to put perl interpreter path in
the perl scripts as /bin/perl
But we set perl location for target as /usr/bin/perl
This mismatch of perl path causes failure of rootfs image creation
like this:
| error: Failed dependencies:
| /bin/perl is needed by eglibc-utils-2.13-r23+svnr15508.i586
NOTE: package core-image-sato-1.0-r0: task do_rootfs: Failed
ERROR: Task 8
(/home/nitin/prj/poky.git/meta/recipes-sato/images/core-image-sato.bb,
do_rootfs) failed with exit code '1'
This Fixes bug : [YOCTO #2286]
RP: Updated to better account for -nativesdk
(From OE-Core rev: 381bf0d364da5970682502f8f124264907587b87)
Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This reverts commit 7c95d554c431451f975e1e5d0336d1fb7d0ce7ae.
eglibc uses the PERL to execute things as well as encoding the path
in target scripts. We will therefore have to resort to sed on the scripts
at do_install time to fix the problems originally reported. This patch
causes various weird build failures and needs to be removed.
(From OE-Core rev: 160ee52b9563dac64941b5f6e2e072171ad396b8)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Export PYTHONHOME to ${STAGING_DIR_NATIVE}/usr. In this way python will search
for modules in native sysroot.
[YOCTO #2134]
(From OE-Core rev: 230b235329bcaca1a95afd89801d28768aff483b)
Signed-off-by: Andrei Gherzan <andrei@gherzan.ro>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
fedora 17 has /usr/bin/perl as well as /bin/perl, which results in
the perl path set in thetarget perl scripts as /bin/perl
While we install perl on target at ${bindir}/perl i.e. /usr/bin/perl
Hence the target perl scripts are broken when build is done on fedora 17.
Work around the issue by providing cached value of perl path to eglibc
This fixes bug [YOCTO #2286]
(From OE-Core rev: 7c95d554c431451f975e1e5d0336d1fb7d0ce7ae)
Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Task do_patch_append calling do_fix_ia_headers is removing files using "rm" not "rm -f".
So first time execution of patch task is success, while re-execution of patch task
fails as it tries to remove the files already removed.
So changed "rm" to "rm -f".
[Yocto #2194]
(From OE-Core rev: f960da1b48bafb3ccdd58222fe9fc12c1bb6ed9b)
Signed-off-by: Venkata Ramana Gollamudi <ramana.gollamudi@huawei.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
[YOCTO #1487]
When booting up with liveCD image, init scripts can't work well on read-only filesystem. Unionfs,
which is supported in Yocto kernel, allows a filesystem to appear as writeable, but without
actually allowing writes to change the filesystem.
Use unionfs to mount rootfs and make root file system can be writen when using liveCD to boot up.
Set UNION_FS variable depending on kernel config, so that it can work with kernel which doesn't
have unionfs feature.
[RP: Mark recipe as machine specific due to kernel dependency]
(From OE-Core rev: b7f4e8d153c2aebbcf6556e7e926f6b94801d6aa)
Signed-off-by: Yang Shi <yang.shi@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Only add locale package dependencies if the eglibc is configured
with locale support.
This avoids dependencies issues for distros such as poky-tiny
[RP: Add PR bump]
(From OE-Core rev: bcaea8ec9c9c333f76b368225f60d4fb54c1c7b2)
Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* busybox-udhcpc-no_deconfig.patch broke the options,
preventing udhcpc from forking into the background
if no lease can be obtained.
(From OE-Core rev: 24ad7ca9bd99cd6cd11f7d2d49a79fe3521cbcec)
Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Adding vte for a more full featured terminal
adding eglibc-gconv-ibm850 for mcopy
(From OE-Core rev: b30a6eb08640b25bb0b0530f51a8cb749de1c311)
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Use a nicer theme (Clearlooks) to improve Hob's appearance in the self
hosted image and fix the progress bar not changing colour when the build
fails.
Fixes [YOCTO #2208]
(From OE-Core rev: 19a13ecceac1f48fcfe1552e88df18edd96e1bea)
Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The default amount of reserved space for ext2/3 is 5% - this amounts to
about 2GB of a 40GB filesystem that the builder user can't make use of.
We don't need this much reserved so peg it back to 0.5% which should be
more than enough.
(From OE-Core rev: c62d6d119c107fc60894ba25e83c96536a1b423c)
Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Fixes [YOCTO #2227]
I've updated the image descriptions per the bug description.
(From OE-Core rev: 479b020edbc609c3ae1e3846e9e0d1643ac10059)
Signed-off-by: Elizabeth Flanagan <elizabeth.flanagan@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
We need to have about 40G to do a full sato build even with rm_work enabled
Add sudo priveleges inorder to allow the builder user to setup the tap/tun
devices needed by runqemu
(From OE-Core rev: 3e4562500956550dbae5467a5fe9289f1d32f775)
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This recipe already includes "task-self-hosted" in the IMAGE_INSTALL
line:
IMAGE_INSTALL = "task-core-boot task-core-apps-console task-core-ssh-openssh task-self-hosted"
so there's no apparent need to include it again further down.
(From OE-Core rev: bbc7f24d463c11b16f000462528c18bbb86b1e88)
Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The PACKAGE_NO_GCONV var manipulations ware happening in the
eglibc-options.inc file, and the eglibc-locale recipe do not
see it. Moving that into the libc-package.bbclass which is
common to eglibc & eglibc-locale recipes.
This fixes bug: [YOCTO #2089]
This avoids this error for poky-tiny
NOTE: package eglibc-locale-2.13-r19: task do_populate_sysroot: Started
ERROR: Error executing a python function in
/opt/poky.git/meta/recipes-core/eglibc/eglibc-locale_2.13.bb:
OSError: [Errno 2] No such file or directory:
'/home/rchatre/concordia/dev/ccd-distro-work/tmp/work/core2-poky-linux/eglibc-locale-2.13-r19/package/usr/lib/gconv'
ERROR: The stack trace of python calls that resulted in this exception/failure
was:
ERROR: File "package_do_split_gconvs", line 264, in <module>
ERROR:·
ERROR: File "package_do_split_gconvs", line 45, in package_do_split_gconvs
ERROR:·
ERROR: File "package.bbclass", line 30, in do_split_packages
ERROR:·
ERROR: The code that was being executed was:
ERROR: 0260:»------»-------bb.note("generation of binary locales disabled.
this may break i18n!")
ERROR: 0261:
ERROR: 0262:
ERROR: 0263:
ERROR: *** 0264:package_do_split_gconvs(d)
ERROR: 0265:
ERROR: (file: 'package_do_split_gconvs', lineno: 264, function: <module>)
ERROR: 0041:»------»-------»-------d.setVar('RPROVIDES_%s' % pkg,
pkg.replace(bpn, 'glibc'))
ERROR: 0042:
ERROR: 0043:»------do_split_packages(d, gconv_libdir,
file_regex='^(.*)\.so$', output_pattern=bpn+'-gconv-%s', \
ERROR: 0044:»------»-------description='gconv module for character set
%s', hook=calc_gconv_deps, \
ERROR: *** 0045:»------»-------extra_depends=bpn+'-gconv')
ERROR: 0046:
ERROR: 0047:»------def calc_charmap_deps(fn, pkg, file_regex,
output_pattern, group):
ERROR: 0048:»------»-------deps = []
ERROR: 0049:»------»-------f = open(fn, "r")
ERROR: (file: 'package_do_split_gconvs', lineno: 45, function:
package_do_split_gconvs)
ERROR: Function failed: package_do_split_gconvs
ERROR: Logfile of failure stored in:
/home/rchatre/concordia/dev/ccd-distro-work/tmp/work/core2-poky-linux/eglibc-locale-2.13-r19/temp/log.do_package.31042
NOTE: package eglibc-locale-2.13-r19: task do_package: Failed
ERROR: Task 552 (/opt/poky.git/meta/recipes-core/eglibc/eglibc-locale_2.13.bb,
do_package) failed with exit code '1'
Signed-Off-By: Nitin A Kamble <nitin.a.kamble@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Use SDK_GLIBC_ADDONS for eglibc-nativesdk so that it is not
dependant on the target eglibc's GLIBC_ADDONS settings.
(From OE-Core rev: e165203a6a7eb1fd47a20c3ede4d5a20ad49487f)
Signed-off-by: Lianhao Lu <lianhao.lu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
gettext-minimal-native andgettext-native are trampling over each other's files. This can
be reproduced with:
bitbake gettext-minimal-native
bitbake gettext-native
bitbake gettext-native -c clean
bitbake shadow-native
which will fail since the aclocal gettext macros will have disappeared. This patch
fixes the problem by giving ownership of them to gettext-minimal-native and ensuring
there is a correct dependency on this.
(From OE-Core rev: 5bcb68a232539cf11a30e3b812b2fbd6d7d76e35)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
1) remove the assumption ${DL_DIR} ends with downloads/.
Thanks Paul Eggleton for pointing this out.
2) remove downloads/git2_* tarballs to speed up the rootfs creation.
This is ok since we still have the git2/.
Thanks Richard Purdie for suggesting this.
(From OE-Core rev: 58ba59f034941bf167e70ae6c08117e5184a20ec)
Signed-off-by: Dexuan Cui <dexuan.cui@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Get new patches and remove the one that got merged upstream
(From OE-Core rev: 0e1a843a1f0c54f00736170de39a8a8f62d26879)
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This patch installs the poky source into the /home/builder/poky/ of the
self-hosted-image.
This makes the user of self-hosted-image easier to start a build.
I think the recent poky master is stable enough, so I specify
a commit number by SRCREV -- we may want to update this number before
releasing 1.2.
This patch fixes [YOCTO #2065]
(From OE-Core rev: 1f2d9be4516cd8c1ed5ce468cb2276f062296ad1)
Signed-off-by: Dexuan Cui <dexuan.cui@intel.com>
Added code for supporting target based pseudo
fixed indentation
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Typoes fixed: "enviroment", "editted", "spliting", "scheulder".
(From OE-Core rev: 17e981a857a51b0bec08c929e8539d36d83874b6)
Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Commit 68dc2a3fa30c03a196d650de34d0c657a7b85454 broke opkg upgrade:
| update-alternatives: Error: cannot register alternative watch to
| /usr/bin/watch since it is already registered to /bin/watch
(From OE-Core rev: fa8b2d2bed63fa4fc2af45f094998b0f9e69d272)
Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(From OE-Core rev: 647595821870693186c9ecad1bdfa12fe4ea334d)
Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
util-linux-lscpu provides an example of pkg level incompatible
license. In this instance, we've set the license for this specific
package as GPLv3. The other packages inherit the recipe LICENSE.
What this allows is the package to not be included on install to
the image.
(From OE-Core rev: ed84f2cee691b16671f93fb68a83ed1b0715c1be)
Signed-off-by: Elizabeth Flanagan <elizabeth.flanagan@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* mountpoint and runlevel may be provided by busybox.
* Use update-alternatives to avoid conflict.
(From OE-Core rev: 3122da7cb2cbaf2f79c299acd5d2070caf07ec56)
Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Set PKGSUFFIX in nativesdk.bbclass for correct variable name expansion.
This would fix bunch of "not shipped" packaging warnings in "-nativesdk"
recipes. And also bumping the corresponding PR.
(From OE-Core rev: c69268305e6f814800b64f3a4be724c40b41108c)
Signed-off-by: Lianhao Lu <lianhao.lu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Fixed not shipped packaging warnings.
WARNING: For recipe ncurses-nativesdk, the following files/directories
were installed but not shipped in any package:
WARNING:
/opt/poky/1.1+snapshot/sysroots/x86_64-pokysdk-linux/usr/bin/reset
WARNING:
/opt/poky/1.1+snapshot/sysroots/x86_64-pokysdk-linux/usr/bin/clear
(From OE-Core rev: c09a2058f6b2f24ab2ae9c5ea357111dd82af39e)
Signed-off-by: Lianhao Lu <lianhao.lu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Ensure that the eglibc-dbg package follows Debian naming too if
enabled. Retain backward compatibility with old libc-dbg naming.
(From OE-Core rev: e338607f36fcad89af7d796b2e9f3a31f11e54d6)
Signed-off-by: Mike Crowe <mac@mcrowe.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Due to the system providing a copy of gzip, we face some issues when we
'shadow' that copy with our own leading to a varient of race type bugs,
and issues for example if a dependency such as libz is missing but the
binary is still present. We usually rely on our dependency logic to protect
us from this but for gzip, we don't have this protection since its not listed
by all its users (and doing so would be impractical).
This patch installed pigz and gzip into their own directory which we only
add to PATH when we explictly want these binaries in much the same way we do
with perl-native. This means dependency logic is correct when we use the binary
and everything should work well.
The patch adds an explict dependency into image.bbclass since the accelerated
speed of compression is most appreciated at rootfs time.
(From OE-Core rev: 7a98c0ef28822ae1fcee45b14db3edcfd4c7ad8f)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Without this, in the target, we don't have the mount.nfs utility.
(From OE-Core rev: 42fb0129c701c52df978430da3d237c924d1d5ee)
Signed-off-by: Dexuan Cui <dexuan.cui@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Removing the patch busybox-1.19.3-getty.patch is because it is already in the upstream.
(From OE-Core rev: f03f8eac4c72be0f16468ebd0ee4dd1f07b0563b)
Signed-off-by: Shane Wang <shane.wang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
WARNING: .../sysvinit-inittab-2.88dsf-r6/sysvinit-2.88dsf/COPYING could
not be copied for some reason. It may not exist. WARN for now.
(From OE-Core rev: 85e4d0c4bb024a67b61afb0f0fedfb15d6aa0d18)
Signed-off-by: Lianhao Lu <lianhao.lu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Includes minor formatting cleanups.
(From OE-Core rev: 5c0be0af8090839588c04ffdba8fd5d75321126c)
Signed-off-by: Scott Garman <scott.a.garman@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
OE-Core commit 4a158b6ef125b555225472eefbe1ea226dc47c2c unintentionally
removed the dependencies for util-linux-native on zlib-native and
ncurses-native by getting append and virtclass-native overrides swapped
around; later this was tidied up to remove the append (which did not change
anything functionally). These libraries are required, so add them back in.
(From OE-Core rev: 0038a030e605195284c98bc154f500a1343c252b)
Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Fix this issue:
| rm: cannot remove `/srv/home/nitin/builds/build-multilib/tmp/work/x86_64-poky-linux/ncurses-5.9-r6.1/image/usr/lib64/terminfo': No such file or directory
NOTE: package ncurses-5.9-r6.1: task do_install: Failed
PR not bumped as there is no change in the packages output.
(From OE-Core rev: 1e6dce3228a483b2367286e49c4aa8a71733dcbb)
Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The packaging changes to ncurses could break package feeds,
so bump the PR on everythong that DEPENDS on ncurses.
(From OE-Core rev: be92256917c157284ef8370bb93bbf443849b2e1)
Signed-off-by: Scott Garman <scott.a.garman@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This ensures packaging of the ncurses libraries moved to
base_libdir is done correctly.
(From OE-Core rev: a897c05ae5c70d81f4d88e7186f9bb9a721ee343)
Signed-off-by: Scott Garman <scott.a.garman@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
If wide character support is disabled (as it is with poky-tiny, for
example) then we won't have libncursesw.so.*, so skip moving these files
in that case. (Fixes a regression introduced in OE-Core revision
ccd370ab147b78de7a5bd74818f755f4d3ca6d81).
(From OE-Core rev: fa15b1dfbf338969660a352deb870dfd5727bc47)
Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This change is needed because currently the INCOMPATIBLE_LICENSE
checking code does not map between SPDX and older style naming
(GPL-3+ vs GPLv3+). Yocto bug number 2093 filed to track this.
(From OE-Core rev: a5cdf764a980624dbf350cb23cd360724c059584)
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* bootmisc.sh executes /etc/init.d/hwclock.sh, which
is optional (depends on CONFIG_HWCLOCK in busybox).
(From OE-Core rev: 9c8300f030b69652ad39e1bc2979f5d9a03adf1e)
Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This reverts commit 37b9d140b5d55af4f77baab0c0b0343d8b5e8b6c since it caused
QA issues for several people. The ncurses location needs to be explicitly
specificed.
(From OE-Core rev: 87f02bdf4b9c0687f466de5c0bc81f510f389fc3)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The --with-libncurses-prefix configure option was added before
this recipe had ncurses in DEPENDS, so it should be safe to
remove it.
(From OE-Core rev: 37b9d140b5d55af4f77baab0c0b0343d8b5e8b6c)
Signed-off-by: Scott Garman <scott.a.garman@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The previous approach to moving the ncurses libraries to
base_libdir was too aggressive, and it broke curses support
in python.
Instead, move only libncurses, libncursesw, and libtinfo to
base_libdir and leave the remaining libraries in libdir.
Also delete ${libdir}/terminfo as it never gets packaged to
avoid a QA warning.
This fixes [YOCTO #2070] and is a partial fix for [YOCTO #1937].
(From OE-Core rev: ccd370ab147b78de7a5bd74818f755f4d3ca6d81)
Signed-off-by: Scott Garman <scott.a.garman@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* util-linux auto-detects libudev for lsblk, so
disable it, because it's not listed in DEPENDS.
(From OE-Core rev: f831d4713a24dd56bf09276fb3b293d9c2b508cb)
Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This is needed to ensure that the RDEPENDS_${PN}-dev,
RDEPENDS_${PN}-staticdev, and RRECOMMENDS_${PN}-dbg are accurate with respect
to the PKGV of the ${PN} package, and incidentally fixes an rpm packaging
issue, as rpm dislikes the recipe PV as PKGV.
(From OE-Core rev: 61d5fa2b7ae6b3ce49747a102b3817c36f6cf85d)
Signed-off-by: Christopher Larson <chris_larson@mentor.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Python commands module is used in the recipe, but never imported.
This leads to build errors like:
NameError: global name 'commands' is not defined
ERROR: The stack trace of python calls that resulted in this exception/failure was:
ERROR: File "do_compile", line 24, in <module>
ERROR:
ERROR: File "do_compile", line 11, in do_compile
ERROR:
ERROR: The code that was being executed was:
ERROR: 0020: bb.build.exec_func("oe_runmake", d)
ERROR: 0021: shutil.copyfile("psplash", outputfile)
ERROR: 0022:
ERROR: 0023:
ERROR: *** 0024:do_compile(d)
ERROR: 0025:
ERROR: (file: 'do_compile', lineno: 24, function: <module>)
ERROR: 0007: localfiles = d.getVar('SPLASH_LOCALPATHS', True).split()
ERROR: 0008: outputfiles = d.getVar('SPLASH_INSTALL', True).split()
ERROR: 0009: for localfile, outputfile in zip(localfiles, outputfiles):
ERROR: 0010: if localfile.endswith(".png"):
ERROR: *** 0011: outp = commands.getstatusoutput('./make-image-header.sh %s POKY' % localfile)
ERROR: 0012: print(outp[1])
ERROR: 0013: fbase = os.path.splitext(os.path.basename(localfile))[0]
ERROR: 0014: shutil.copyfile("%s-img.h" % fbase, destfile)
ERROR: 0015: else:
(From OE-Core rev: 34bdb9a459208377210454e54635afb9404ee126)
Signed-off-by: Peter Tworek <tworaz666@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* pidof lives in /bin, search it in $PATH.
* Assume pidof's presence.
(From OE-Core rev: 2f9ac0a10f7d1e3144622a5dff5aa6787fcee534)
Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Using "1" with getVar is bad coding style and "True" is preferred.
This patch is a sed over the meta directory of the form:
sed \
-e 's:\(\.getVar([^,()]*, \)1 *):\1True):g' \
-e 's:\(\.getVarFlag([^,()]*, [^,()]*, \)1 *):\1True):g' \
-i `grep -ril getVar *`
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Dash did not like >& so we do 2 >& 1 > /dev/null
(From OE-Core rev: 06c783e2d6f4e3b316b230565b28d9e4c535c31b)
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
If a machine loses power while building the volatiles cache, it will
continue to operate with an incomplete set of volatiles. Fix this by
updating atomically.
(From OE-Core rev: a60432ff4588390f5f955a6da234298e958546e6)
Signed-off-by: James Limbouris <james@digitalmatter.com.au>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Restore CONFIG_FEATURE_DATE_COMPAT so that all versions of 'date',
whether from busybox or coreutils, agree on the format when
setting the date from the command line.
(From OE-Core rev: 5506cc481b7afd9a30af53e8966bcbe2ff67b6d0)
Signed-off-by: Gary Thomas <gary@mlbassoc.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Reformat date, as stored in /etc/timestamp, to match CLI format.
(From OE-Core rev: 7aa4c51089cc4a2811bd11842647839d1e4b1e95)
Signed-off-by: Gary Thomas <gary@mlbassoc.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
AC_CHECK_DECLS generated defines should be
checked with #if not #ifdef
(From OE-Core rev: 14b86a350d07b0da550a7a39886a660210918fbf)
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
WARNING: For recipe netbase, the following files/directories were installed but not shipped in any package:
WARNING: /usr/sbin
(From OE-Core rev: 64f3a58026909b4462e8e1a3e2ccabdf9bdb4468)
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Without 64 bit shell tests, the timestamp comparison in initscripts' bootmisc.sh throws 'out of range' errors.
With CONFIG_FEATURE_DATE_COMPAT, date reads the YYYYMMddhhmm string as hhmmYYYYMMdd when setting the time from the timestamp in bootmisc.sh.
(From OE-Core rev: e32e23649f4eab0bdc71a854f99b11fee19125ac)
Signed-off-by: James Limbouris <james@digitalmatter.com.au>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
According to its documentation, gettext 0.18.1.1 needs either
libunistring or it will use its own internal version. Just add
a configure option '--with-included-libunistring' to force the
latter to avoid races.
[YOCTO#1934]
(From OE-Core rev: f4f242cf8af9df3dc2394d245740b173f34cbf81)
Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This updates various checksums for the COPYING files, which moved in the process
no changes to Licenses
Tweak the scanf_cv_alloc_modifier and rebase the patch
(From OE-Core rev: 9cb35b41c803bd0d1904b2dc0e14624fa7ea6e95)
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Various people are reporting glib-2.0 failures from a dependency on
libfam creeping in uninvited. This patch explicitly disables it to
favour a deterministic build.
(From OE-Core rev: e1d5a81bf78786dcb11a4840436f46ba9ec4010e)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* We have various variables which are either not quoted at all or are half
quoted. This patch fixes the bad exmaples so everything is consistent.
(From OE-Core rev: 960ee8076e860353a05eb2eb7f825a455c54698d)
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
dbus is only needed for some of the glib tests which we don't use. We can
therefore drop the dependency and gain some small parallelism gains.
(From OE-Core rev: 4642ae91cee2978956a61cf15df7ea62e3eb1726)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Added cifs to mountnfs.sh and umountnfs.sh.
(From OE-Core rev: c44e51f281101c8933679f679e3d4a75a41bedf7)
Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Adds a SPLASH_IMAGES variable which you can set to include one or more
images (listed in URI form as they would appear in SRC_URI), and an
executable will be built for each one, with each executable packaged
separately and managed at runtime using the alternatives system. An
optional "outsuffix" parameter can be used to specify the suffix for the
executable/package name. The images themselves can either be
pre-processed image header files (produced using the
make-image-header.sh script that comes with psplash), or alternatively
you can provide a .png and it will be converted using the aforementioned
script on the fly (at the expense of requiring gdk-pixbuf-native at
build time).
This has been implemented in such a way that you can still just provide
your own psplash-poky-img.h in a bbappend and it will work as it did
before; the only change being that the psplash executable is provided
in a "psplash-default" package rather than in the main psplash package,
and an RRECOMMENDS is set up to ensure psplash-default gets pulled in
(if you specify your own file or change the outsuffix you will need to
either install it separately yourself or add your own RRECOMMENDS
relationship.)
Implements [YOCTO #1947]
(From OE-Core rev: d3de5f7308b4a42b809884119a670af5bedde38f)
Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Use the OpenEmbedded logo for psplash in OE-Core.
(From OE-Core rev: cd321b83c78c00003f1ce06ac3ca85647cf9df51)
Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
python-pygtk depends on libgtk and libgtk's recommends have
gdk-pixbuf-loader-{png,jpeg,gif,xpm}, so we have the warnings.
We can add hicolor-icon-theme to fix the warning:
Configuring gdk-pixbuf-loader-png.
gtk-update-icon-cache: No theme index file.
Configuring gdk-pixbuf-loader-jpeg.
gtk-update-icon-cache: No theme index file.
Configuring liberation-fonts.
Configuring gdk-pixbuf-loader-xpm.
gtk-update-icon-cache: No theme index file.
Configuring gdk-pixbuf-loader-gif.
gtk-update-icon-cache: No theme index file.
Add socat for to faciliate proxy setting.
(From OE-Core rev: d32933a74b380aac906bbfbe1ec7d89b02e9f72d)
Signed-off-by: Dexuan Cui <dexuan.cui@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
WARNING: For recipe dbus-glib, the following files/directories were installed but not shipped in any package:
WARNING: /etc
WARNING: /etc/bash_completion.d
WARNING: /etc/bash_completion.d/dbus-bash-completion.sh
WARNING: /usr/libexec/dbus-bash-completion-helper
(From OE-Core rev: 8f0d188df4aaccc3fd4911f12c532f81ae9714a7)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
WARNING: For recipe glib-2.0, the following files/directories were installed but not shipped in any package:
WARNING: /usr/lib/gio
WARNING: /usr/lib/gio/modules
(From OE-Core rev: a85f283ffae5407b23532ce2262142ee2d986af2)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
WARNING: For recipe eglibc, the following files/directories were installed but not shipped in any package:
WARNING: /usr/lib/locale
(From OE-Core rev: d8c24378c6813036fcf9bc88cac919c3443c1446)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This patch makes no actual change to the functionality of the recipe.
(From OE-Core rev: 0dff62c849650f3fa51ce80979b4d80dcc0d36f1)
Signed-off-by: Dexuan Cui <dexuan.cui@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The package names are specified more than once.
We only need to keep one for each of them, so let's remove the duplicated
ones.
This patch makes no actual change to the functionality of the recipe.
(From OE-Core rev: 121a1499a81706366acc0081272a6bff634d4d62)
Signed-off-by: Dexuan Cui <dexuan.cui@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* It's not used by the recipe and its creation
currently depends on CONFIG_HWCLOCK=y.
(From OE-Core rev: cd59c2fcefa6aeacf78a63c5c9a623a4d77c0941)
Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This empty directory generates a QA warning of unshippped files/dirs.
(From OE-Core rev: d3573ae136c532d3cf537ef05c22f163275f4f41)
Signed-off-by: Andrei Gherzan <andrei@gherzan.ro>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Commit cc8695 changed the way timestamps were handled
and added some extra munging to be able to compare them
reliably. This change makes the timestamp value the same
everywhere and simplifies how the check to set the system
clock based on the timestamp is done.
Also, if the value stored in /etc/timestamp is newer
[at all] than the current system time, set the system clock
from the stored value, down to the minute, not just the day.
(From OE-Core rev: 5aab6653c9afa05e7c1b3ccd6bd34aec05c2a6f8)
Signed-off-by: Gary Thomas <gary@mlbassoc.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
There's no need to explicitly set PACKAGE_ARCH = MACHINE_ARCH, base.bbclass
takes care of setting this value for us based on the interfaces for those
machines being an OVERRIDE.
(From OE-Core rev: c3d5800d2850a186f91b5a0db642aa5d1c20156b)
Signed-off-by: Joshua Lock <josh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Fixed bad link in udev.inc to the udev home page / documentation on
kernel.org
(From OE-Core rev: 479b9a52a013d990da296f96bd658db00423f9a6)
Signed-off-by: Robert Cochran<yocto@mindchasers.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Add sanity checks that test for the existance of folders. This allows to use
an external binary toolchain that doesn't have localization support.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Without this, the VMware guest running self-hosted-image can't get IP
address automatically.
(From OE-Core rev: 3fa9a7e4dc9eadce22a9838d2067d5af0111b04b)
Signed-off-by: Dexuan Cui <dexuan.cui@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* it's called from install-libs target and when /etc/ld.so.cache is writeable by user running bitbake
then it creates invalid cache (in my case libstdc++.so cannot be found after building zlib(-native)
and I have to call touch */libstdc++.so && /sbin/ldconfig to fix it
(From OE-Core rev: b5c8add7f3ed58451cb460a242b4edd671ba618e)
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Currently a process was being forked off for each individual file
this class wanted to inspect with rpmdeps. This converts it to use
rpmdeps-oecore which allows batch processing of these dependencies.
For do_package for perl, this reduced the time by about 1 minute (33%).
(From OE-Core rev: 548037acd63bd4859f8de8d23a3d12f36ce9f97f)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Dont use autotools, it really not so autoconf like.
the configure script gets updated with every release of zlib
and we overwrite that. Instead use the upstream provided
configure
copyright year was changed in zlib.h which caused change in
LIC_FILE_CHECKSUM
fix.inverted.LFS.logic.patch is already applied upstream so drop it
Drop the configure.ac and Makefile.am scripts since we do not
autoreconf anymore and do not inherit autotools anymore
Bump PR for depending recipes so a rebuild it ensues so that
they dont depend on .la anymore
and add missing dependencies discovered during incremental
build
(From OE-Core rev: 50ad5230ea9e0982cdfda23fb9fcfccf89d28f29)
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The use of __packed, which isn't defined in userspace, caused busybox build
failures.
(From OE-Core rev: 9c44bb6434a1d2347ebbb38bde9671688b0ae447)
Signed-off-by: Christopher Larson <chris_larson@mentor.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
CS puts optimized executables in usr/lib/bin, not usr/bin.
(From OE-Core rev: 25d22bfb0970f7152b678796f2282dced7230fe1)
Signed-off-by: Christopher Larson <chris_larson@mentor.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
task-core-tools-debug, task-core-tools-profile, task-core-tools-testapps
otherwise if we choose one through PACKAGE_GROUPS all packages
are built since they are in same recipe.
(From OE-Core rev: 180227d8ff71c42e0d16ad7eb4a5f9b7d6a0c1c6)
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The usefulness of cache nowadays has been reduced a lot and thus it's
better to stop using it by default. Dropping the recommends allows for
image to decide if they want or not to have cache enabled, instead of
require a machine override.
(From OE-Core rev: bf849b8a6da32cebaa361242162e4fcc4b1cd97f)
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Flock is required by by pm-utils package to function properly
(/usr/lib/pm-utils/functions). It's shipped in both busybox and
util-linux. Both versions work fine with pm-utils. Enabling it
in busybox seems like simpliest solution for the problem.
(From OE-Core rev: a8ba002b5eb3c2e57550483d7b3ea99f0cc8a9cb)
Signed-off-by: Peter Tworek <tworaz666@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Unfortunately, the CSL ia32 toolchain has non-prefixed binaries in its bindir
(e.g. gcc, ld). To avoid this messing up our build, we avoid adding this
bindir to our PATH, and instead add symlinks to the prefixed binaries to our
staging toolchain bindir.
(From OE-Core rev: c924d878b55cce7a0e98dc60acf706b5a1b4f404)
Signed-off-by: Christopher Larson <chris_larson@mentor.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
- Rather than adjusting TARGET_VENDOR, which results in our TARGET_SYS
matching the external toolchain, override TARGET_PREFIX to match external,
and leave TARGET_SYS alone
- Grab the optimized files out of the toolchain if available
- Create a symlink in sysroot to ensure the sysroot layout matches toolchain
expectations (optimized files in a subdir)
(From OE-Core rev: a37298eb3421a44e88ec5a66b2fc5305ab18f453)
Signed-off-by: Christopher Larson <chris_larson@mentor.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* allow udev-cache to be disabled at runtime (using
/etc/default/udev-cache);
* make cache invalidated if kernel, bootparams or device list
changes;
(From OE-Core rev: 22b72b23653736436f10d394de36201c32630d5d)
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
These allow the recipe to build again:
- add compilerlibs, g++, libgcc to the provides
- add linux-libc-headers-dev to the packages
- in libc-package, only sed the ldd.bash.in file if it exists, as the external
toolchain is using that class as well
- shift the inherit location of the libc classes, as they were overriding the
recipe's do_install
- use ?= for EXTERNAL_TOOLCHAIN, so the user can set it
(From OE-Core rev: 8fb1c84f4cadf8d7a061fd6d90d270c19b474bfe)
Signed-off-by: Christopher Larson <chris_larson@mentor.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
only *_nonshared.a are to be packaged in uclibc-dev
rest can go into uclibc-staticdev
(From OE-Core rev: aa799ba49833bdf6acbcd4b34f0605050c938175)
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Christopher Larson
Saul Wold
Khem Raj
Mark Norman
Mark Hatle
Richard Purdie
Robert Yang
Nitin A Kamble
Andrei Gherzan
Venkata ramana gollamudi
Yang Shi
Andreas Oberritter
Paul Eggleton
Dexuan Cui
Elizabeth Flanagan
Robert P. J. Day
Lianhao Lu
Mike Crowe
Andreas Müller
Shane Wang
Dongxiao Xu
Scott Garman
Christopher Larson
Peter Tworek
James Limbouris
Gary Thomas
Wenzong Fan
Martin Jansa
Joshua Lock
Bob Cochran
Ken Werner
Otavio Salvador