generic-poky/bitbake/lib/bb/ui
Mikko Rapeli 4490625088 bitbake: bitbake: Fix return value checks from subprocess.call()'s
Python function subprocess.call() returns the return value of the
executed process. If return values are not checked, errors may
go unnoticed and bad things can happen.

Change all callers of subprocess.call() which do not check for
the return value to use subprocess.check_call() which raises
CalledProcessError if the subprocess returns with non-zero value.

https://docs.python.org/2/library/subprocess.html#using-the-subprocess-module

All users of the function were found with:

$ git grep "subprocess\.call" | \
  egrep -v 'if.*subprocess\.call|=\ +subprocess\.call|return.*subprocess\.call'

Tested similar patch on top of yocto jethro. Only compile tested
core-image-minimal on poky master branch.

(Bitbake rev: aac956a0950c05bf58af1885474cd89bb9c8fbd1)

Signed-off-by: Mikko Rapeli <mikko.rapeli@bmw.de>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2017-11-05 22:37:29 +00:00
..
icons bitbake: Add missing file that went out of sync 2013-06-12 13:13:21 +01:00
__init__.py Formatting cleanups 2010-07-02 15:41:32 +01:00
buildinfohelper.py bitbake: toaster: add getMessage to MockEvent 2017-07-27 22:36:46 +01:00
knotty.py bitbake: knotty: Remove extra whitespace after task progress bars 2017-03-13 09:43:40 +00:00
ncurses.py bitbake: bitbake: Fix return value checks from subprocess.call()'s 2017-11-05 22:37:29 +00:00
taskexp.py bitbake: ui: Replace depexp with taskexp 2017-02-19 06:28:46 -08:00
toasterui.py bitbake: toaster: fix SDK artifact capture 2017-04-11 18:05:09 +01:00
uievent.py bitbake: bitbake: fix wrong usage of format_exc 2016-06-16 11:51:26 +01:00
uihelper.py bitbake: build/uihelper: Show better information about multiconfig tasks on UI 2016-12-22 12:36:40 +00:00