generic-poky/bitbake
Mikko Rapeli 4490625088 bitbake: bitbake: Fix return value checks from subprocess.call()'s
Python function subprocess.call() returns the return value of the
executed process. If return values are not checked, errors may
go unnoticed and bad things can happen.

Change all callers of subprocess.call() which do not check for
the return value to use subprocess.check_call() which raises
CalledProcessError if the subprocess returns with non-zero value.

https://docs.python.org/2/library/subprocess.html#using-the-subprocess-module

All users of the function were found with:

$ git grep "subprocess\.call" | \
  egrep -v 'if.*subprocess\.call|=\ +subprocess\.call|return.*subprocess\.call'

Tested similar patch on top of yocto jethro. Only compile tested
core-image-minimal on poky master branch.

(Bitbake rev: aac956a0950c05bf58af1885474cd89bb9c8fbd1)

Signed-off-by: Mikko Rapeli <mikko.rapeli@bmw.de>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2017-11-05 22:37:29 +00:00
..
bin bitbake: toaster: noweb should init database 2017-07-27 22:36:46 +01:00
contrib bitbake: dump_cache.py: use python3 as interpreter 2016-08-20 16:08:59 +01:00
doc bitbake: fetch/local: Drop FILESDIR 2017-04-05 23:20:03 +01:00
lib bitbake: bitbake: Fix return value checks from subprocess.call()'s 2017-11-05 22:37:29 +00:00
AUTHORS misc: Update the email address to a working one. 2011-01-04 14:36:54 +00:00
COPYING bitbake: Sync with upstream. 2007-01-08 23:53:01 +00:00
ChangeLog *: Fix typo in documentation 2010-08-04 16:12:39 +01:00
HEADER bitbake: Sync with upstream. 2007-01-08 23:53:01 +00:00
LICENSE bitbake: lib/bb/siggen: show word-diff for single-line values containing spaces 2017-04-10 23:00:32 +01:00
toaster-requirements.txt bitbake: toaster: modified list of dependencies 2016-06-02 08:24:03 +01:00