You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Ido Schimmel 7e2a755497 bridge: netlink: register netdevice before executing changelink ... [ Upstream commit 5b8d5429da ] Peter reported a kernel oops when executing the following command: $ ip link add name test type bridge vlan_default_pvid 1 [13634.939408] BUG: unable to handle kernel NULL pointer dereference at 0000000000000190 [13634.939436] IP: __vlan_add+0x73/0x5f0 [...] [13634.939783] Call Trace: [13634.939791] ? pcpu_next_unpop+0x3b/0x50 [13634.939801] ? pcpu_alloc+0x3d2/0x680 [13634.939810] ? br_vlan_add+0x135/0x1b0 [13634.939820] ? __br_vlan_set_default_pvid.part.28+0x204/0x2b0 [13634.939834] ? br_changelink+0x120/0x4e0 [13634.939844] ? br_dev_newlink+0x50/0x70 [13634.939854] ? rtnl_newlink+0x5f5/0x8a0 [13634.939864] ? rtnl_newlink+0x176/0x8a0 [13634.939874] ? mem_cgroup_commit_charge+0x7c/0x4e0 [13634.939886] ? rtnetlink_rcv_msg+0xe1/0x220 [13634.939896] ? lookup_fast+0x52/0x370 [13634.939905] ? rtnl_newlink+0x8a0/0x8a0 [13634.939915] ? netlink_rcv_skb+0xa1/0xc0 [13634.939925] ? rtnetlink_rcv+0x24/0x30 [13634.939934] ? netlink_unicast+0x177/0x220 [13634.939944] ? netlink_sendmsg+0x2fe/0x3b0 [13634.939954] ? _copy_from_user+0x39/0x40 [13634.939964] ? sock_sendmsg+0x30/0x40 [13634.940159] ? ___sys_sendmsg+0x29d/0x2b0 [13634.940326] ? __alloc_pages_nodemask+0xdf/0x230 [13634.940478] ? mem_cgroup_commit_charge+0x7c/0x4e0 [13634.940592] ? mem_cgroup_try_charge+0x76/0x1a0 [13634.940701] ? __handle_mm_fault+0xdb9/0x10b0 [13634.940809] ? __sys_sendmsg+0x51/0x90 [13634.940917] ? entry_SYSCALL_64_fastpath+0x1e/0xad The problem is that the bridge's VLAN group is created after setting the default PVID, when registering the netdevice and executing its ndo_init(). Fix this by changing the order of both operations, so that br_changelink() is only processed after the netdevice is registered, when the VLAN group is already initialized. Fixes: b6677449df ("bridge: netlink: call br_changelink() during br_dev_newlink()") Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com> Signed-off-by: Ido Schimmel <idosch@mellanox.com> Reported-by: Peter V. Saveliev <peter@svinota.eu> Tested-by: Peter V. Saveliev <peter@svinota.eu> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <alexander.levin@verizon.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		6 years ago
..
netfilter	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	7 years ago
Kconfig	bridge: Add vlan filtering infrastructure	10 years ago
Makefile	bridge: switchdev: Add forward mark support for stacked devices	7 years ago
br.c	netfilter: bridge: clarify bridge/netfilter message	7 years ago
br_device.c	bridge: switchdev: Clear forward mark when transmitting packet	6 years ago
br_fdb.c	rtnetlink: fdb dump: optimize by saving last interface markers	7 years ago
br_forward.c	net: bridge: allow IPv6 when multicast flood is disabled	6 years ago
br_if.c	net: bridge: add per-port multicast flood flag	7 years ago
br_input.c	bridge: drop netfilter fake rtable unconditionally	6 years ago
br_ioctl.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	7 years ago
br_mdb.c	bridge: mdb: fix leak on complete_info ptr on fail path	6 years ago
br_multicast.c	bridge: multicast: restore perm router ports on multicast enable	7 years ago
br_netfilter_hooks.c	bridge: drop netfilter fake rtable unconditionally	6 years ago
br_netfilter_ipv6.c	netfilter: bridge: add and use br_nf_hook_thresh	7 years ago
br_netlink.c	bridge: netlink: register netdevice before executing changelink	6 years ago
br_nf_core.c	net: Remove protocol from struct dst_ops	8 years ago
br_private.h	net: bridge: change unicast boolean to exact pkt_type	7 years ago
br_private_stp.h	net: 8021q/bluetooth/bridge/can/ceph: Remove extern from function prototypes	10 years ago
br_stp.c	net: bridge: br_set_ageing_time takes a clock_t	7 years ago
br_stp_bpdu.c	netfilter: Pass net into okfn	8 years ago
br_stp_if.c	net: bridge: start hello timer only if device is up	6 years ago
br_stp_timer.c	bridge: start hello_timer when enabling KERNEL_STP in br_stp_start	6 years ago
br_switchdev.c	bridge: switchdev: Add forward mark support for stacked devices	7 years ago
br_sysfs_br.c	net: bridge: set error code on failure	6 years ago
br_sysfs_if.c	net: bridge: add the multicast_flood flag attribute to brport_attrs	7 years ago
br_vlan.c	bridge: netlink: export per-vlan stats	7 years ago