You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Jason A. Donenfeld b4a119251f netlink: do not proceed if dump's start() errs ... [ Upstream commit fef0035c0f ] Drivers that use the start method for netlink dumping rely on dumpit not being called if start fails. For example, ila_xlat.c allocates memory and assigns it to cb->args[0] in its start() function. It might fail to do that and return -ENOMEM instead. However, even when returning an error, dumpit will be called, which, in the example above, quickly dereferences the memory in cb->args[0], which will OOPS the kernel. This is but one example of how this goes wrong. Since start() has always been a function with an int return type, it therefore makes sense to use it properly, rather than ignoring it. This patch thus returns early and does not call dumpit() when start() fails. Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com> Cc: Johannes Berg <johannes@sipsolutions.net> Reviewed-by: Johannes Berg <johannes@sipsolutions.net> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		6 years ago
..
Kconfig	netlink: remove mmapped netlink support	7 years ago
Makefile	netlink: Diag core and basic socket info dumping (v2)	10 years ago
af_netlink.c	netlink: do not proceed if dump's start() errs	6 years ago
af_netlink.h	netlink: Call cb->done from a worker thread	6 years ago
diag.c	netlink: netlink_diag_dump() runs without locks	6 years ago
genetlink.c	genetlink: fix a memory leak on error path	6 years ago