sysmo-bts
/
u-boot
9
0
Fork 0
Code Pull Requests Releases Activity

83xx: mpc8315erdb: fix silly thinko in fdt_tsec1_fixup 

The thinko was quite silly indeed, I messed with !ptr. Normally this
would trigger some fault, but in U-Boot NULL pointer is equal to phys
0, so the code was working still, just didn't actually test mpc8315erdb
environment variable value. Heh.

Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
This commit is contained in:
Anton Vorontsov 2008-07-10 17:20:51 +04:00 committed by Kim Phillips
parent 25f5f0d49a
commit 021f6df6e9
1 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
board/freescale/mpc8315erdb/mpc8315erdb.c
View File

@ -128,7 +128,9 @@ void fdt_tsec1_fixup(void *fdt, bd_t *bd)
const char *path; const char *path;
int ret; int ret;
if (!mpc8315erdb) { if (!mpc8315erdb)
return;
if (!strcmp(mpc8315erdb, "tsec1")) { if (!strcmp(mpc8315erdb, "tsec1")) {
return; return;
} else if (strcmp(mpc8315erdb, "ulpi")) { } else if (strcmp(mpc8315erdb, "ulpi")) {
@ -137,7 +139,6 @@ void fdt_tsec1_fixup(void *fdt, bd_t *bd)
"or `tsec1'.\n", mpc8315erdb); "or `tsec1'.\n", mpc8315erdb);
return; return;
} }
}
ret = fdt_path_offset(fdt, "/aliases"); ret = fdt_path_offset(fdt, "/aliases");
if (ret < 0) { if (ret < 0) {