sysmo-bts
/
u-boot
9
0
Fork 0
Code Pull Requests Releases Activity

net/: sparse fixes 

bootp.c:44:14: warning: symbol 'dhcp_state' was not declared. Should it be static?
bootp.c:45:15: warning: symbol 'dhcp_leasetime' was not declared. Should it be static?
bootp.c:46:10: warning: symbol 'NetDHCPServerIP' was not declared. Should it be static?
arp.c:30:17: warning: symbol 'NetArpWaitReplyIP' was not declared. Should it be static?
arp.c:37:16: warning: symbol 'NetArpTxPacket' was not declared. Should it be static?
arp.c:38:17: warning: symbol 'NetArpPacketBuf' was not declared. Should it be static?
atheros.c:33:19: warning: symbol 'AR8021_driver' was not declared. Should it be static?
net.c:183:7: warning: symbol 'PktBuf' was not declared. Should it be static?
net.c:159:21: warning: symbol 'net_state' was not declared. Should it be static?
ping.c:73:6: warning: symbol 'ping_start' was not declared. Should it be static?
ping.c:82:13: warning: symbol 'ping_receive' was not declared. Should it be static?
tftp.c:53:7: warning: symbol 'TftpRRQTimeoutMSecs' was not declared. Should it be static?
tftp.c:54:5: warning: symbol 'TftpRRQTimeoutCountMax' was not declared. Should it be static?
eth.c:125:19: warning: symbol 'eth_current' was not declared. Should it be static?

Note: in the ping.c fix, commit a36b12f95a
"net: Move PING out of net.c" mistakenly carried the ifdef CMD_PING
clause from when it was necessary to avoid warnings when it was embedded
in net.c.

Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
This commit is contained in:
Kim Phillips 2012-10-29 13:34:33 +00:00 committed by Tom Rini
parent 199adb601f
commit 0637059088
8 changed files with 17 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
common/update.c
View File

@ -37,6 +37,7 @@
#include <command.h> #include <command.h>
#include <flash.h> #include <flash.h>
#include <net.h> #include <net.h>
#include <net/tftp.h>
#include <malloc.h> #include <malloc.h>
/* env variable holding the location of the update file */ /* env variable holding the location of the update file */

2
drivers/net/phy/atheros.c
View File

@ -30,7 +30,7 @@ static int ar8021_config(struct phy_device *phydev)
return 0; return 0;
} }
struct phy_driver AR8021_driver = { static struct phy_driver AR8021_driver = {
.name = "AR8021", .name = "AR8021",
.uid = 0x4dd040, .uid = 0x4dd040,
.mask = 0xfffff0, .mask = 0xfffff0,

9
include/net.h
View File

@ -102,12 +102,13 @@ extern int eth_register(struct eth_device* dev);/* Register network device */
extern int eth_unregister(struct eth_device *dev);/* Remove network device */ extern int eth_unregister(struct eth_device *dev);/* Remove network device */
extern void eth_try_another(int first_restart); /* Change the device */ extern void eth_try_another(int first_restart); /* Change the device */
extern void eth_set_current(void); /* set nterface to ethcur var */ extern void eth_set_current(void); /* set nterface to ethcur var */
/* get the current device MAC */ /* get the current device MAC */
extern struct eth_device *eth_current;
static inline __attribute__((always_inline)) static inline __attribute__((always_inline))
struct eth_device *eth_get_dev(void) struct eth_device *eth_get_dev(void)
{ {
extern struct eth_device *eth_current;
return eth_current; return eth_current;
} }
extern struct eth_device *eth_get_dev_by_name(const char *devname); extern struct eth_device *eth_get_dev_by_name(const char *devname);
@ -517,10 +518,10 @@ enum net_loop_state {
NETLOOP_SUCCESS, NETLOOP_SUCCESS,
NETLOOP_FAIL NETLOOP_FAIL
}; };
extern enum net_loop_state net_state;
static inline void net_set_state(enum net_loop_state state) static inline void net_set_state(enum net_loop_state state)
{ {
extern enum net_loop_state net_state;
debug_cond(DEBUG_INT_STATE, "--- NetState set to %d\n", state); debug_cond(DEBUG_INT_STATE, "--- NetState set to %d\n", state);
net_state = state; net_state = state;
} }

6
net/arp.c
View File

@ -27,15 +27,15 @@
#endif #endif
IPaddr_t NetArpWaitPacketIP; IPaddr_t NetArpWaitPacketIP;
IPaddr_t NetArpWaitReplyIP; static IPaddr_t NetArpWaitReplyIP;
/* MAC address of waiting packet's destination */ /* MAC address of waiting packet's destination */
uchar *NetArpWaitPacketMAC; uchar *NetArpWaitPacketMAC;
int NetArpWaitTxPacketSize; int NetArpWaitTxPacketSize;
ulong NetArpWaitTimerStart; ulong NetArpWaitTimerStart;
int NetArpWaitTry; int NetArpWaitTry;
uchar *NetArpTxPacket; /* THE ARP transmit packet */ static uchar *NetArpTxPacket; /* THE ARP transmit packet */
uchar NetArpPacketBuf[PKTSIZE_ALIGN + PKTALIGN]; static uchar NetArpPacketBuf[PKTSIZE_ALIGN + PKTALIGN];
void ArpInit(void) void ArpInit(void)
{ {

6
net/bootp.c
View File

@ -41,9 +41,9 @@ ulong BootpID;
int BootpTry; int BootpTry;
#if defined(CONFIG_CMD_DHCP) #if defined(CONFIG_CMD_DHCP)
dhcp_state_t dhcp_state = INIT; static dhcp_state_t dhcp_state = INIT;
unsigned long dhcp_leasetime; static unsigned long dhcp_leasetime;
IPaddr_t NetDHCPServerIP; static IPaddr_t NetDHCPServerIP;
static void DhcpHandler(uchar *pkt, unsigned dest, IPaddr_t sip, unsigned src, static void DhcpHandler(uchar *pkt, unsigned dest, IPaddr_t sip, unsigned src,
unsigned len); unsigned len);

2
net/net.c
View File

@ -180,7 +180,7 @@ IPaddr_t NetNtpServerIP;
int NetTimeOffset; int NetTimeOffset;
#endif #endif
uchar PktBuf[(PKTBUFSRX+1) * PKTSIZE_ALIGN + PKTALIGN]; static uchar PktBuf[(PKTBUFSRX+1) * PKTSIZE_ALIGN + PKTALIGN];
/* Receive packet */ /* Receive packet */
uchar *NetRxPackets[PKTBUFSRX]; uchar *NetRxPackets[PKTBUFSRX];

3
net/ping.h
View File

@ -8,8 +8,6 @@
* Copyright 2000-2002 Wolfgang Denk, wd@denx.de * Copyright 2000-2002 Wolfgang Denk, wd@denx.de
*/ */
#if defined(CONFIG_CMD_PING)
#ifndef __PING_H__ #ifndef __PING_H__
#define __PING_H__ #define __PING_H__
@ -31,4 +29,3 @@ void ping_start(void);
void ping_receive(struct ethernet_hdr *et, struct ip_udp_hdr *ip, int len); void ping_receive(struct ethernet_hdr *et, struct ip_udp_hdr *ip, int len);
#endif /* __PING_H__ */ #endif /* __PING_H__ */
#endif

3
net/tftp.h
View File

@ -22,6 +22,9 @@ void TftpStart(enum proto_t protocol); /* Begin TFTP get/put */
extern void TftpStartServer(void); /* Wait for incoming TFTP put */ extern void TftpStartServer(void); /* Wait for incoming TFTP put */
#endif #endif
extern ulong TftpRRQTimeoutMSecs;
extern int TftpRRQTimeoutCountMax;
/**********************************************************************/ /**********************************************************************/
#endif /* __TFTP_H__ */ #endif /* __TFTP_H__ */