sysmo-bts
/
u-boot
9
0
Fork 0
Code Pull Requests Releases Activity

input: fix unaligned access in key_matrix_decode_fdt() 

Initialized character arrays on the stack can cause gcc to emit code that
performs unaligned accessess. Make the data static to avoid this.

Note that the unaligned accesses are made when copying data to prefix[] on
the stack from .rodata. By making the data static, the copy is completely
avoided. All explicitly written code treats the data as u8[], so will never
cause any unaligned accesses.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
Acked-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
Stephen Warren 2013-05-22 08:48:18 +00:00 committed by Tom Rini
parent b8521b740b
commit e573617c09
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/input/key_matrix.c
View File

@ -158,7 +158,7 @@ int key_matrix_decode_fdt(struct key_matrix *config, const void *blob,
int node)
{
const struct fdt_property *prop;
const char prefix[] = "linux,";
static const char prefix[] = "linux,";
int plen = sizeof(prefix) - 1;
int offset;