sysmo-bts
/
u-boot
9
0
Fork 0
Code Pull Requests Releases Activity

mx6boards: Fix error handling in board_mmc_init() 

When an invalid USDHC port is passed we should return -EINVAL instead of 0.

Also, return the error immediately on fsl_esdhc_initialize() failure.

Cc: Eric Benard <eric@eukrea.com>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
This commit is contained in:
Fabio Estevam 2014-11-21 16:42:58 -02:00 committed by Stefano Babic
parent 612f2dc026
commit e7eb277dce
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
board/embest/mx6boards/mx6boards.c
View File

@ -216,7 +216,7 @@ int board_mmc_getcd(struct mmc *mmc)
int board_mmc_init(bd_t *bis) int board_mmc_init(bd_t *bis)
{ {
s32 status = 0; int ret;
int i; int i;
/* /*
@ -268,13 +268,15 @@ int board_mmc_init(bd_t *bis)
printf("Warning: you configured more USDHC controllers" printf("Warning: you configured more USDHC controllers"
"(%d) then supported by the board (%d)\n", "(%d) then supported by the board (%d)\n",
i + 1, CONFIG_SYS_FSL_USDHC_NUM); i + 1, CONFIG_SYS_FSL_USDHC_NUM);
return status; return -EINVAL;
} }
status |= fsl_esdhc_initialize(bis, &usdhc_cfg[i]); ret = fsl_esdhc_initialize(bis, &usdhc_cfg[i]);
if (ret)
return ret;
} }
return status; return 0;
} }
#endif #endif