u-boot/board/esd
Wolfgang Denk 54841ab50c Make sure that argv[] argument pointers are not modified.
The hush shell dynamically allocates (and re-allocates) memory for the
argument strings in the "char *argv[]" argument vector passed to
commands.  Any code that modifies these pointers will cause serious
corruption of the malloc data structures and crash U-Boot, so make
sure the compiler can check that no such modifications are being done
by changing the code into "char * const argv[]".

This modification is the result of debugging a strange crash caused
after adding a new command, which used the following argument
processing code which has been working perfectly fine in all Unix
systems since version 6 - but not so in U-Boot:

int main (int argc, char **argv)
{
	while (--argc > 0 && **++argv == '-') {
/* ====> */	while (*++*argv) {
			switch (**argv) {
			case 'd':
				debug++;
				break;
			...
			default:
				usage ();
			}
		}
	}
	...
}

The line marked "====>" will corrupt the malloc data structures and
usually cause U-Boot to crash when the next command gets executed by
the shell.  With the modification, the compiler will prevent this with
an
	error: increment of read-only location '*argv'

N.B.: The code above can be trivially rewritten like this:

	while (--argc > 0 && **++argv == '-') {
		char *arg = *argv;
		while (*++arg) {
			switch (*arg) {
			...

Signed-off-by: Wolfgang Denk <wd@denx.de>
Acked-by: Mike Frysinger <vapier@gentoo.org>
2010-07-04 23:55:42 +02:00
..
adciop ppc4xx: Remove board specific linker scripts from most PPC4xx boards 2009-11-02 16:29:04 +01:00
apc405 Make sure that argv[] argument pointers are not modified. 2010-07-04 23:55:42 +02:00
ar405 Make sure that argv[] argument pointers are not modified. 2010-07-04 23:55:42 +02:00
ash405 Make sure that argv[] argument pointers are not modified. 2010-07-04 23:55:42 +02:00
canbt Make sure that argv[] argument pointers are not modified. 2010-07-04 23:55:42 +02:00
cms700 Make sure that argv[] argument pointers are not modified. 2010-07-04 23:55:42 +02:00
common Make sure that argv[] argument pointers are not modified. 2010-07-04 23:55:42 +02:00
cpci2dp Make sure that argv[] argument pointers are not modified. 2010-07-04 23:55:42 +02:00
cpci405 Make sure that argv[] argument pointers are not modified. 2010-07-04 23:55:42 +02:00
cpci750 Make sure that argv[] argument pointers are not modified. 2010-07-04 23:55:42 +02:00
cpci5200 Make sure that argv[] argument pointers are not modified. 2010-07-04 23:55:42 +02:00
cpciiser4 Make sure that argv[] argument pointers are not modified. 2010-07-04 23:55:42 +02:00
dasa_sim Make sure that argv[] argument pointers are not modified. 2010-07-04 23:55:42 +02:00
dp405 ppc4xx: Remove board specific linker scripts from most PPC4xx boards 2009-11-02 16:29:04 +01:00
du405 Make sure that argv[] argument pointers are not modified. 2010-07-04 23:55:42 +02:00
du440 Make sure that argv[] argument pointers are not modified. 2010-07-04 23:55:42 +02:00
hh405 Make sure that argv[] argument pointers are not modified. 2010-07-04 23:55:42 +02:00
hub405 ppc4xx: Remove board specific linker scripts from most PPC4xx boards 2009-11-02 16:29:04 +01:00
mecp5123 5xxx, fdt: move fdt_fixup_memory() to cpu.c file 2009-12-08 22:13:02 +01:00
mecp5200 mpc5xxx: Remove all references to MGT5100 2010-03-21 22:44:42 +01:00
meesc at91: Enable slow master clock on meesc board 2010-01-23 08:15:50 -06:00
ocrtc Make sure that argv[] argument pointers are not modified. 2010-07-04 23:55:42 +02:00
otc570 AT91: Update otc570 board to new SoC access 2010-03-07 12:36:37 -06:00
pci405 Make sure that argv[] argument pointers are not modified. 2010-07-04 23:55:42 +02:00
pf5200 Make sure that argv[] argument pointers are not modified. 2010-07-04 23:55:42 +02:00
plu405 Make sure that argv[] argument pointers are not modified. 2010-07-04 23:55:42 +02:00
pmc405 ppc4xx: Remove board specific linker scripts from most PPC4xx boards 2009-11-02 16:29:04 +01:00
pmc405de Make sure that argv[] argument pointers are not modified. 2010-07-04 23:55:42 +02:00
pmc440 Make sure that argv[] argument pointers are not modified. 2010-07-04 23:55:42 +02:00
tasreg Make sure that argv[] argument pointers are not modified. 2010-07-04 23:55:42 +02:00
vme8349 Make sure that argv[] argument pointers are not modified. 2010-07-04 23:55:42 +02:00
voh405 Make sure that argv[] argument pointers are not modified. 2010-07-04 23:55:42 +02:00
vom405 Merge branch 'master' into next 2009-12-05 02:11:59 +01:00
wuh405 Make sure that argv[] argument pointers are not modified. 2010-07-04 23:55:42 +02:00