u-boot/lib
Wolfgang Denk 54841ab50c Make sure that argv[] argument pointers are not modified.
The hush shell dynamically allocates (and re-allocates) memory for the
argument strings in the "char *argv[]" argument vector passed to
commands.  Any code that modifies these pointers will cause serious
corruption of the malloc data structures and crash U-Boot, so make
sure the compiler can check that no such modifications are being done
by changing the code into "char * const argv[]".

This modification is the result of debugging a strange crash caused
after adding a new command, which used the following argument
processing code which has been working perfectly fine in all Unix
systems since version 6 - but not so in U-Boot:

int main (int argc, char **argv)
{
	while (--argc > 0 && **++argv == '-') {
/* ====> */	while (*++*argv) {
			switch (**argv) {
			case 'd':
				debug++;
				break;
			...
			default:
				usage ();
			}
		}
	}
	...
}

The line marked "====>" will corrupt the malloc data structures and
usually cause U-Boot to crash when the next command gets executed by
the shell.  With the modification, the compiler will prevent this with
an
	error: increment of read-only location '*argv'

N.B.: The code above can be trivially rewritten like this:

	while (--argc > 0 && **++argv == '-') {
		char *arg = *argv;
		while (*++arg) {
			switch (*arg) {
			...

Signed-off-by: Wolfgang Denk <wd@denx.de>
Acked-by: Mike Frysinger <vapier@gentoo.org>
2010-07-04 23:55:42 +02:00
..
libfdt Move libfdt/ into lib/ 2010-04-13 09:13:04 +02:00
lzma Rename lib_generic/ to lib/ 2010-04-13 09:13:04 +02:00
lzo Rename lib_generic/ to lib/ 2010-04-13 09:13:04 +02:00
addr_map.c Rename lib_generic/ to lib/ 2010-04-13 09:13:04 +02:00
bzlib.c Rename lib_generic/ to lib/ 2010-04-13 09:13:04 +02:00
bzlib_crctable.c Rename lib_generic/ to lib/ 2010-04-13 09:13:04 +02:00
bzlib_decompress.c Rename lib_generic/ to lib/ 2010-04-13 09:13:04 +02:00
bzlib_huffman.c Rename lib_generic/ to lib/ 2010-04-13 09:13:04 +02:00
bzlib_private.h Rename lib_generic/ to lib/ 2010-04-13 09:13:04 +02:00
bzlib_randtable.c Rename lib_generic/ to lib/ 2010-04-13 09:13:04 +02:00
circbuf.c Rename lib_generic/ to lib/ 2010-04-13 09:13:04 +02:00
crc16.c Rename lib_generic/ to lib/ 2010-04-13 09:13:04 +02:00
crc32.c Rename lib_generic/ to lib/ 2010-04-13 09:13:04 +02:00
ctype.c Rename lib_generic/ to lib/ 2010-04-13 09:13:04 +02:00
display_options.c Avoid use of divides in print_size 2010-05-17 23:23:39 +02:00
div64.c Move arch/ppc to arch/powerpc 2010-04-21 23:42:38 +02:00
gunzip.c Rename lib_generic/ to lib/ 2010-04-13 09:13:04 +02:00
ldiv.c Rename lib_generic/ to lib/ 2010-04-13 09:13:04 +02:00
lmb.c Rename lib_generic/ to lib/ 2010-04-13 09:13:04 +02:00
Makefile Rename lib_generic/ to lib/ 2010-04-13 09:13:04 +02:00
md5.c Rename lib_generic/ to lib/ 2010-04-13 09:13:04 +02:00
net_utils.c Rename lib_generic/ to lib/ 2010-04-13 09:13:04 +02:00
rbtree.c Rename lib_generic/ to lib/ 2010-04-13 09:13:04 +02:00
sha1.c Rename lib_generic/ to lib/ 2010-04-13 09:13:04 +02:00
sha256.c Rename lib_generic/ to lib/ 2010-04-13 09:13:04 +02:00
string.c Rename lib_generic/ to lib/ 2010-04-13 09:13:04 +02:00
strmhz.c Rename lib_generic/ to lib/ 2010-04-13 09:13:04 +02:00
time.c Rename lib_generic/ to lib/ 2010-04-13 09:13:04 +02:00
vsprintf.c Make sure that argv[] argument pointers are not modified. 2010-07-04 23:55:42 +02:00
zlib.c Rename lib_generic/ to lib/ 2010-04-13 09:13:04 +02:00