u-boot/drivers/qe
Wolfgang Denk 54841ab50c Make sure that argv[] argument pointers are not modified.
The hush shell dynamically allocates (and re-allocates) memory for the
argument strings in the "char *argv[]" argument vector passed to
commands.  Any code that modifies these pointers will cause serious
corruption of the malloc data structures and crash U-Boot, so make
sure the compiler can check that no such modifications are being done
by changing the code into "char * const argv[]".

This modification is the result of debugging a strange crash caused
after adding a new command, which used the following argument
processing code which has been working perfectly fine in all Unix
systems since version 6 - but not so in U-Boot:

int main (int argc, char **argv)
{
	while (--argc > 0 && **++argv == '-') {
/* ====> */	while (*++*argv) {
			switch (**argv) {
			case 'd':
				debug++;
				break;
			...
			default:
				usage ();
			}
		}
	}
	...
}

The line marked "====>" will corrupt the malloc data structures and
usually cause U-Boot to crash when the next command gets executed by
the shell.  With the modification, the compiler will prevent this with
an
	error: increment of read-only location '*argv'

N.B.: The code above can be trivially rewritten like this:

	while (--argc > 0 && **++argv == '-') {
		char *arg = *argv;
		while (*++arg) {
			switch (*arg) {
			...

Signed-off-by: Wolfgang Denk <wd@denx.de>
Acked-by: Mike Frysinger <vapier@gentoo.org>
2010-07-04 23:55:42 +02:00
..
fdt.c mpc85xx: Configure QE USB for MPC8569E-MDS boards 2009-10-27 10:04:17 -05:00
Makefile drivers/qe: Move conditional compilation to Makefile 2008-08-13 01:40:41 +02:00
qe.c Make sure that argv[] argument pointers are not modified. 2010-07-04 23:55:42 +02:00
qe.h drivers/qe: Add more SNUM number for QE 2009-06-12 17:17:00 -05:00
uccf.c drivers/qe: Move conditional compilation to Makefile 2008-08-13 01:40:41 +02:00
uccf.h net: uec: Fix uccf.h and uec.h headers to include headers they depend on 2009-09-25 18:25:50 -05:00
uec.c 83xx: UEC: Added support for bitBang MII driver access to PHYs 2010-05-03 14:52:48 -07:00
uec.h 83xx, uec: split enet_interface in two variables 2010-01-31 22:37:12 -08:00
uec_phy.c 83xx: UEC: Added support for bitBang MII driver access to PHYs 2010-05-03 14:52:48 -07:00
uec_phy.h Change UEC PHY interface to RGMII on MPC8568MDS 2008-10-18 21:54:00 +02:00