u-boot/board/micronas/vct
Wolfgang Denk 54841ab50c Make sure that argv[] argument pointers are not modified.
The hush shell dynamically allocates (and re-allocates) memory for the
argument strings in the "char *argv[]" argument vector passed to
commands.  Any code that modifies these pointers will cause serious
corruption of the malloc data structures and crash U-Boot, so make
sure the compiler can check that no such modifications are being done
by changing the code into "char * const argv[]".

This modification is the result of debugging a strange crash caused
after adding a new command, which used the following argument
processing code which has been working perfectly fine in all Unix
systems since version 6 - but not so in U-Boot:

int main (int argc, char **argv)
{
	while (--argc > 0 && **++argv == '-') {
/* ====> */	while (*++*argv) {
			switch (**argv) {
			case 'd':
				debug++;
				break;
			...
			default:
				usage ();
			}
		}
	}
	...
}

The line marked "====>" will corrupt the malloc data structures and
usually cause U-Boot to crash when the next command gets executed by
the shell.  With the modification, the compiler will prevent this with
an
	error: increment of read-only location '*argv'

N.B.: The code above can be trivially rewritten like this:

	while (--argc > 0 && **++argv == '-') {
		char *arg = *argv;
		while (*++arg) {
			switch (*arg) {
			...

Signed-off-by: Wolfgang Denk <wd@denx.de>
Acked-by: Mike Frysinger <vapier@gentoo.org>
2010-07-04 23:55:42 +02:00
..
vcth MIPS: Add VCT board series support (Part 3/3) 2009-01-27 23:08:26 +09:00
vcth2 MIPS: Add VCT board series support (Part 3/3) 2009-01-27 23:08:26 +09:00
vctv MIPS: Add VCT board series support (Part 3/3) 2009-01-27 23:08:26 +09:00
bcu.h MIPS: Add VCT board series support (Part 1/3) 2009-01-27 23:08:08 +09:00
config.mk MIPS: Add VCT board series support (Part 1/3) 2009-01-27 23:08:08 +09:00
dcgu.c MIPS: Add VCT board series support (Part 1/3) 2009-01-27 23:08:08 +09:00
dcgu.h MIPS: Add VCT board series support (Part 1/3) 2009-01-27 23:08:08 +09:00
ebi.c MIPS: Add VCT board series support (Part 1/3) 2009-01-27 23:08:08 +09:00
ebi.h MIPS: Add VCT board series support (Part 1/3) 2009-01-27 23:08:08 +09:00
ebi_nor_flash.c MIPS: Add VCT board series support (Part 1/3) 2009-01-27 23:08:08 +09:00
ebi_onenand.c MIPS: VCT: Remove read_spareram reference 2009-09-28 13:55:06 -05:00
ebi_smc911x.c Convert SMC911X Ethernet driver to CONFIG_NET_MULTI API 2009-07-22 22:53:44 -07:00
ehci.c MIPS: Add VCT board series support (Part 2/3) 2009-01-27 23:08:17 +09:00
gpio.c MIPS: Add VCT board series support (Part 2/3) 2009-01-27 23:08:17 +09:00
Makefile MIPS: Add VCT board series support (Part 1/3) 2009-01-27 23:08:08 +09:00
scc.c MIPS: Add VCT board series support (Part 2/3) 2009-01-27 23:08:17 +09:00
scc.h MIPS: Add VCT board series support (Part 2/3) 2009-01-27 23:08:17 +09:00
smc_eeprom.c Make sure that argv[] argument pointers are not modified. 2010-07-04 23:55:42 +02:00
top.c MIPS: Add VCT board series support (Part 2/3) 2009-01-27 23:08:17 +09:00
u-boot.lds Fix all linker script to handle all rodata sections 2009-03-20 22:39:12 +01:00
vct.c Convert SMC911X Ethernet driver to CONFIG_NET_MULTI API 2009-07-22 22:53:44 -07:00
vct.h MIPS: Add VCT board series support (Part 2/3) 2009-01-27 23:08:17 +09:00