u-boot/fs/ext4
Łukasz Majewski 8b454eeeea fs:ext4:write:fix: Reinitialize global variables after updating a file
This bug shows up when file stored on the ext4 file system is updated.

The ext4fs_delete_file() is responsible for deleting file's (e.g. uImage)
data.
However some global data (especially ext4fs_indir2_block), which is used
during file deletion are left unchanged.

The ext4fs_indir2_block pointer stores reference to old ext4 double
indirect allocated blocks. When it is unchanged, after file deletion,
ext4fs_write_file() uses the same pointer (since it is already initialized
- i.e. not NULL) to return number of blocks to write. This trunks larger
file when previous one was smaller.

Lets consider following scenario:

1. Flash target with ext4 formatted boot.img (which has uImage [*] on itself)
2. Developer wants to upload their custom uImage [**]
	- When new uImage [**] is smaller than the [*] - everything works
	correctly - we are able to store the whole smaller file with corrupted
	ext4fs_indir2_block pointer
	- When new uImage [**] is larger than the [*] - theCRC is corrupted,
	since truncation on data stored at eMMC was done.
3. When uImage CRC error appears, then reboot and LTHOR/DFU reflashing causes
	proper setting of ext4fs_indir2_block() and after that uImage[**]
	is successfully stored (correct uImage [*] metadata is stored at an
	eMMC on the first flashing).

Due to above the bug was very difficult to reproduce.
This patch sets default values for all ext4fs_indir* pointers/variables.

Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
2014-05-12 16:31:50 -04:00
..
crc16.c ext4fs write support 2012-08-09 23:48:02 +02:00
crc16.h ext4fs write support 2012-08-09 23:48:02 +02:00
dev.c fs/ext4: fix partition size get truncated in calculation 2014-01-20 10:09:38 -05:00
ext4_common.c fs:ext4:write:fix: Reinitialize global variables after updating a file 2014-05-12 16:31:50 -04:00
ext4_common.h Revert "ext4fs: Add ext4 extent cache for read operations" 2014-02-26 08:18:58 -05:00
ext4_journal.c fs/ext4: fix calling put_ext4 with truncated offset 2014-01-20 10:09:38 -05:00
ext4_journal.h Add GPL-2.0+ SPDX-License-Identifier to source files 2013-07-24 09:44:38 -04:00
ext4_write.c fs:ext4:write:fix: Reinitialize global variables after updating a file 2014-05-12 16:31:50 -04:00
ext4fs.c Revert "ext4fs: Add ext4 extent cache for read operations" 2014-02-26 08:18:58 -05:00
Makefile fs: descend into sub directories when it is necessary 2013-11-17 14:11:34 -05:00