sysmocom
/
asterisk
11
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove my rant, since I have now replaced the rant with code. 

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@115315 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
Russell Bryant 2008-05-05 20:28:17 +00:00
parent 8aa3c0e2e1
commit 27521f9e63
1 changed files with 1 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
channels/chan_iax2.c
View File

@ -1588,20 +1588,7 @@ static void remove_by_peercallno(struct chan_iax2_pvt *pvt)
ao2_unlink(iax_peercallno_pvts, pvt);
}
/*!
* \todo XXX Note that this function contains a very expensive operation that
* happens for *every* incoming media frame. It iterates through every
* possible call number, locking and unlocking each one, to try to match the
* incoming frame to an active call. Call numbers can be up to 2^15, 32768.
* So, for a call with a local call number of 20000, every incoming audio
* frame would require 20000 mutex lock and unlock operations. Ouch.
*
* It's a shame that IAX2 media frames carry the source call number instead of
* the destination call number. If they did, this lookup wouldn't be needed.
* However, it's too late to change that now. Instead, we need to come up with
* a better way of indexing active calls so that these frequent lookups are not
* so expensive.
*
/*
* \note Calling this function while holding another pvt lock can cause a deadlock.
*/
static int __find_callno(unsigned short callno, unsigned short dcallno, struct sockaddr_in *sin, int new, int sockfd, int return_locked, int full_frame)