sysmocom
/
asterisk
11
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

srv: Fix crash when ast_srv_lookup is used and 0 records are returned. 

When performing an SRV lookup using the ast_srv_lookup function it
did not properly handle the situation where 0 records are returned.
If this happened it would wrongly assume that at least one record
was present.

This change fixes the code so it will exit early if an error occurs
or if 0 records are returned.

ASTERISK-26772
patches:
  srv_lookup.patch submitted by nappsoft (license 6822)

Change-Id: I09b19081c74e0ad11c12bf54a257243b1bcb2351
This commit is contained in:
Joshua Colp 2017-02-07 18:01:03 +00:00
parent b47cf1a7d6
commit 5422ec140c
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
main/srv.c
View File

@ -209,7 +209,8 @@ int ast_srv_lookup(struct srv_context **context, const char *service, const char
}
AST_LIST_HEAD_INIT_NOLOCK(&(*context)->entries);
if ((ast_search_dns(*context, service, C_IN, T_SRV, srv_callback)) < 0) {
if (((ast_search_dns(*context, service, C_IN, T_SRV, srv_callback)) < 1) ||
AST_LIST_EMPTY(&(*context)->entries)) {
ast_free(*context);
*context = NULL;
return -1;