sysmocom
/
asterisk
11
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

res_pjsip_outbound_publish: Potential crash due to off nominal path 

It was possible for the explicit publish destroy function to be called without
the pjsip client ever being initialized. This fix checks to make sure there is
a client to destroy before attempting.

Change-Id: I8eea1bfa3bd472149bfc255310be2a6248688f5c
This commit is contained in:
Kevin Harwell 2016-05-03 15:31:19 -05:00
parent 4df48581f1
commit dfbb03cc8e
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
res/res_pjsip_outbound_publish.c
View File

@ -701,8 +701,15 @@ static int explicit_publish_destroy(void *data)
{
struct ast_sip_outbound_publish_client *client = data;
pjsip_publishc_destroy(client->client);
ao2_ref(client, -1);
/*
* If there is no pjsip publishing client then we obviously don't need
* to destroy it. Also, the ref for the Asterisk publishing client that
* pjsip had would not exist or should already be gone as well.
*/
if (client->client) {
pjsip_publishc_destroy(client->client);
ao2_ref(client, -1);
}
return 0;
}