http.c: Fix NULL pointer dereference bug
If native HTTP is disabled but HTTPS is enabled and status page enabled too, Core/HTTP crashes while loading. 'global_http_server' references to NULL, but the status page tries to dereference it. The patch adds a check for HTTP is enabled. ASTERISK-30379 #close Change-Id: I11b02fc920b72aaed9c809fc43210523ccfdc249
This commit is contained in:
parent
811584ded3
commit
e85f23e6e5
10
main/http.c
10
main/http.c
|
@ -396,10 +396,12 @@ static int httpstatus_callback(struct ast_tcptls_session_instance *ser,
|
||||||
|
|
||||||
ast_str_append(&out, 0, "<tr><td><i>Server</i></td><td><b>%s</b></td></tr>\r\n", http_server_name);
|
ast_str_append(&out, 0, "<tr><td><i>Server</i></td><td><b>%s</b></td></tr>\r\n", http_server_name);
|
||||||
ast_str_append(&out, 0, "<tr><td><i>Prefix</i></td><td><b>%s</b></td></tr>\r\n", prefix);
|
ast_str_append(&out, 0, "<tr><td><i>Prefix</i></td><td><b>%s</b></td></tr>\r\n", prefix);
|
||||||
ast_str_append(&out, 0, "<tr><td><i>Bind Address</i></td><td><b>%s</b></td></tr>\r\n",
|
if (global_http_server) {
|
||||||
ast_sockaddr_stringify_addr(&global_http_server->args.old_address));
|
ast_str_append(&out, 0, "<tr><td><i>Bind Address</i></td><td><b>%s</b></td></tr>\r\n",
|
||||||
ast_str_append(&out, 0, "<tr><td><i>Bind Port</i></td><td><b>%s</b></td></tr>\r\n",
|
ast_sockaddr_stringify_addr(&global_http_server->args.old_address));
|
||||||
ast_sockaddr_stringify_port(&global_http_server->args.old_address));
|
ast_str_append(&out, 0, "<tr><td><i>Bind Port</i></td><td><b>%s</b></td></tr>\r\n",
|
||||||
|
ast_sockaddr_stringify_port(&global_http_server->args.old_address));
|
||||||
|
}
|
||||||
if (http_tls_cfg.enabled) {
|
if (http_tls_cfg.enabled) {
|
||||||
ast_str_append(&out, 0, "<tr><td><i>SSL Bind Port</i></td><td><b>%s</b></td></tr>\r\n",
|
ast_str_append(&out, 0, "<tr><td><i>SSL Bind Port</i></td><td><b>%s</b></td></tr>\r\n",
|
||||||
ast_sockaddr_stringify_port(&https_desc.old_address));
|
ast_sockaddr_stringify_port(&https_desc.old_address));
|
||||||
|
|
Loading…
Reference in New Issue