Commit Graph

15803 Commits

Author SHA1 Message Date
Tilghman Lesher bb03680941 Merged revisions 124315 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r124315 | tilghman | 2008-06-20 15:16:02 -0500 (Fri, 20 Jun 2008) | 8 lines

When using a Local channel, started by a call file, with a destination of an
AGI script, the AGI script does not always get notified of a hangup if the
underlying channel hangs up early.
(closes issue #11833)
 Reported by: IgorG
 Patches: 
       local_hangup-v1.diff uploaded by IgorG (license 20)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124316 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-20 20:17:04 +00:00
Mark Michelson a2333afed6 Change references to doc/channelvariables.txt to
doc/tex/channelvariables.tex.

This issue came up on the asterisk-dev mailing list.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124278 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-20 16:30:18 +00:00
Mark Michelson 0f62296eb6 Add a missing "ChannelType" header to one of the "PeerStatus" manager
events in chan_sip

(closes issue #12904)
Reported by: eliel
Patches:
      chan_sip.c.patch uploaded by eliel (license 64)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124243 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-20 15:20:11 +00:00
Tilghman Lesher e746aa2043 Merged revisions 124182 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r124182 | tilghman | 2008-06-19 17:53:22 -0500 (Thu, 19 Jun 2008) | 7 lines

It's possible for a hangup to be received, even just after the initial cid
spill.
(closes issue #12453)
 Reported by: Alex728
 Patches: 
       20080604__bug12453.diff.txt uploaded by Corydon76 (license 14)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124183 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-19 22:59:41 +00:00
Mark Michelson 1d2ac41c07 Fix attachment behavior when using IMAP storage for voicemails
1. Filenames had an extra "msg" in the attachment name
2. The attachment was being saved twice

(closes issue #12894)
Reported by: jaroth
Patches:
      imap_attach.patch uploaded by jaroth (license 50)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124180 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-19 22:34:03 +00:00
Michiel van Baak 8e8359465b Older versions of GNU gcc do not allow 'NULL' as sentinel.
They want (char *)NULL as sentinel.
An example is OpenBSD (confirmed on 4.3) that ships with gcc 3.3.4

This commit introduces a contstant SENTINEL which is declared as:
#define SENTINEL ((char *)NULL)

All places I could test compile on my openbsd system are converted.
Update CODING-GUIDELINES to tell about this constant.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124127 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-19 20:48:33 +00:00
Tilghman Lesher 2e0afd805b Oops
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124125 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-19 20:35:56 +00:00
Mark Michelson 7852d30fe8 Merged revisions 124112 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r124112 | mmichelson | 2008-06-19 15:28:41 -0500 (Thu, 19 Jun 2008) | 8 lines

Fix IMAP forwarding so that messages are sent to the proper mailbox.

(closes issue #12897)
Reported by: jaroth
Patches:
      destination_forward.patch uploaded by jaroth (license 50)


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124121 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-19 20:30:23 +00:00
Tilghman Lesher 27be0a3197 Make OpenBSD compile again
(reported by mvanbaak via IRC -dev)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124102 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-19 20:25:37 +00:00
Brett Bryant b4574d2a79 Add errors that report any locks held by threads when they are being closed.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124064 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-19 19:48:26 +00:00
Tilghman Lesher 122486b263 Allow alternative extensions to be specified for a user.
(closes issue #12830)
 Reported by: jcollie
 Patches: 
       astertisk-trunk-121496-alternate-extensions.patch uploaded by jcollie (license 412)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124049 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-19 19:22:59 +00:00
Brett Bryant 249ac33ab0 Fix bug in sip registration that sets the default port to 5060 for tls.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124024 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-19 18:57:04 +00:00
Russell Bryant fa4bce7c43 - Make res_timing_pthread allow a max rate of 100/sec instead of 50/sec
- change the "timing test" CLI command to let you specify a timing rate to test


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124023 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-19 18:30:49 +00:00
Tilghman Lesher 4522c60ec8 Detect if the installed gcc version supports the warn_unused_result attribute.
Reported by mvanbaak via IRC -dev.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123988 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-19 17:55:34 +00:00
Tilghman Lesher 5791b6680d Don't change pointers that need to be later passed back for deallocation.
(closes issue #12572)
 Reported by: flyn
 Patches: 
       20080613__bug12572.diff.txt uploaded by Corydon76 (license 14)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123952 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-19 17:22:27 +00:00
Tilghman Lesher 56654fc0f2 Merged revisions 123930 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r123930 | tilghman | 2008-06-19 11:58:19 -0500 (Thu, 19 Jun 2008) | 5 lines

Change informative messages to use the _multiple variant when multiple formats
are possible.
(Closes issue #12848)
Reported by klaus3000

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123931 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-19 17:02:54 +00:00
Tilghman Lesher 33ea368c93 Merged revisions 123909 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r123909 | tilghman | 2008-06-19 11:26:03 -0500 (Thu, 19 Jun 2008) | 5 lines

Only process 40 arguments (20 files) at once with xargs, because some older
shells may force xargs to separate on an odd boundary.
(Closes issue #12883)
Reported by Nik Soggia

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123913 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-19 16:26:50 +00:00
Tilghman Lesher 48a9e5cada Merged revisions 123883 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r123883 | tilghman | 2008-06-19 11:20:41 -0500 (Thu, 19 Jun 2008) | 4 lines

Correct description of notifyringing option.
(Closes issue #12890)
Reported by gminet

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123887 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-19 16:21:32 +00:00
Tilghman Lesher 284ae601c3 Merged revisions 123869 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r123869 | tilghman | 2008-06-19 11:07:23 -0500 (Thu, 19 Jun 2008) | 6 lines

The RDTSC instruction was introduced on the Pentium line of microprocessors,
and is not compatible with certain 586 clones, like Cyrix.  Hence, asking for
i386 compatibility was always incorrect. See http://en.wikipedia.org/wiki/RDTSC
(Closes issue #12886)
Reported by tecnoxarxa

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123870 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-19 16:08:29 +00:00
Mark Michelson a2b4382fd7 Forwarding non-urgent IMAP messages could inadvertently cause the messages
to be marked urgent. This fixes that issue.

(closes issue #12895)
Reported by: jaroth
Patches:
      urgent_forwarding.patch uploaded by jaroth (license 50)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123867 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-19 15:55:10 +00:00
Tilghman Lesher d2247c2573 Missing comma
(closes issue #12891)
 Reported by: chris-mac


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123865 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-19 15:52:17 +00:00
Sean Bright a41649d66b Update the queuelog.tex documentation as well.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123830 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-19 14:28:56 +00:00
Sean Bright 62cb684f59 Include original position in TRANSFER entries written to queue_log.
(closes issue #12888)
Reported by: slavon
Patches:
      app_queue_transfer_patch_trunk.diff uploaded by slavon (license 288)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123828 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-19 14:24:43 +00:00
Tilghman Lesher a06ab7b648 Merged revisions 123769 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r123769 | tilghman | 2008-06-18 17:08:30 -0500 (Wed, 18 Jun 2008) | 8 lines

Add support for saying numbers in Hebrew.
(closes issue #11662)
 Reported by: greenfieldtech
 Patches: 
       say.c.patch-12042008 uploaded by greenfieldtech (license 369)
       Hebrew-Sounds.ods uploaded by greenfieldtech
       (with signficant changes to the spreadsheet by me)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123770 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-18 22:17:17 +00:00
Tilghman Lesher c86e26e66b Merged revisions 123710 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r123710 | tilghman | 2008-06-18 15:22:42 -0500 (Wed, 18 Jun 2008) | 7 lines

Set the variables top-down, so that if a script sets a variable more than once,
the last one will take precedence.
(closes issue #12673)
 Reported by: phber
 Patches: 
       20080519__bug12673.diff.txt uploaded by Corydon76 (license 14)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123715 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-18 20:23:58 +00:00
Brett Bryant 8d353eb15a Fix a crash in tcp and tls connections related to reference counts.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123692 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-18 20:07:56 +00:00
Mark Michelson eaa14309dd A portion of the code which handled the 'c' queue option had been
removed. No telling when it happened. Anyway, it's back in now
and works properly.

(Based on issue reported on mailing list)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123652 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-18 15:08:56 +00:00
Mark Michelson 103a94c6c4 Silly pointers. This fixes a memory corruption I introduced
with the attended transfer logging.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123650 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-18 14:54:47 +00:00
Tilghman Lesher 90867b2b0c Channel lock janitor -- add locks around retrieval of channel variables
(closes issue #12840)
 Reported by: pputman
 Patches: 
       app_dial_threadsafe3.patch uploaded by pputman (license 81)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123648 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-18 13:09:02 +00:00
Sean Bright 9c62626a52 Whitespace only
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123609 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-18 00:33:31 +00:00
Brett Bryant 99757cdb70 Revert a previous regression in astobj2.c from merging a branch.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123575 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-17 22:24:45 +00:00
Brett Bryant 2aae0ba13d Updates all usages of ast_tcptls_session_instance to be managed by reference counts so that they only get destroyed when all threads are done using
them, and memory does not get free'd causing strange issues with SIP. 

This code was originally written by russellb in the team/group/issue_11972/ branch.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123546 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-17 21:46:57 +00:00
Tilghman Lesher 9d403c379f Add an option, specifying maximum analysis time for talk detection.
(closes issue #12149)
 Reported by: davevg
 Patches: 
       app_talkdetect.c.diff uploaded by davevg (license 209)
       (Plus a few additional cleanups by moi)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123544 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-17 21:42:42 +00:00
Mark Michelson b0b8bcd3b2 Put quotes around "test"
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123541 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-17 21:33:40 +00:00
Mark Michelson fb3564de50 _ys pointed out in #asterisk-bugs that he was experiencing
a memory leak when running the astobj2 test CLI command. After
searching, it appears the leak was in the command handler itself.

Each object was allocated (recount = 1) and then linked into
a container (refounct = 2). Then at the end of the function, 
the container was unreffed, causing all the objects to have
their refcount decremented by one, leaving the refcount for
all objects allocated in that function at 1. I've now added
an extra unref to the mix so that the refcount equals zero
when the container is unreffed.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123526 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-17 21:26:31 +00:00
Mark Michelson 67ca33e267 Merged revisions 123485 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r123485 | mmichelson | 2008-06-17 15:26:38 -0500 (Tue, 17 Jun 2008) | 4 lines

Make chan_sip build under dev mode with compilers >= GCC 4.2
Thanks to jpeeler for alerting me of this


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123486 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-17 20:28:47 +00:00
Mark Michelson 6a9a22f32f Add the same fix from revision 123271 to container_destruct_debug.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123456 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-17 20:19:49 +00:00
Steve Murphy bb20ef7017 Changes to list peers and users in alpha. order, as per a reasonable request in 12494. Due to changes in trunk to use the astobj2 i/f in the sip channel driver, the order of the entries in the config file was lost, thus the output was in a random order, but no longer.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123448 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-17 20:17:20 +00:00
Steve Murphy c23e5fea96 This solves a crash in the cdr_tds module on 'stop gracefully', for situations where 'settings' is not set to a pointer
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123446 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-17 20:00:36 +00:00
Russell Bryant 5aeb6a6cbb Fix the check against the max supported rate
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123393 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-17 19:00:14 +00:00
Tilghman Lesher bb0dbfa520 Merged revisions 123391 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r123391 | tilghman | 2008-06-17 13:56:53 -0500 (Tue, 17 Jun 2008) | 3 lines

Fix 3 more places where failure to lock the structure could cause the wrong lock to be
unlocked.  (Closes issue #12795)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123392 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-17 18:57:45 +00:00
Tilghman Lesher 6d5b1d76ab If we don't match registrar when destroying a context, it can cause a crash.
(closes issue #12835)
 Reported by: ys
 Patches: 
       pbx.c.diff uploaded by ys (license 281)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123358 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-17 18:23:01 +00:00
Mark Michelson 8c6184f0da Merged revisions 123333 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r123333 | mmichelson | 2008-06-17 13:09:16 -0500 (Tue, 17 Jun 2008) | 11 lines

Cisco BTS sends SIP responses with a tab between the Cseq number and
SIP request method in the Cseq: header. Asterisk did not handle this
properly, but with this patch, all is well.

(closes issue #12834)
Reported by: tobias_e
Patches:
      12834.patch uploaded by putnopvut (license 60)
Tested by: tobias_e


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123334 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-17 18:09:54 +00:00
Mark Michelson 0283469cfc Merged revisions 123274 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r123274 | mmichelson | 2008-06-17 10:56:55 -0500 (Tue, 17 Jun 2008) | 12 lines

davidw pointed out that the holdtime calculation used by
app_queue does not use "boxcar" filtering as the comments
say. The term "boxcar" means that the number of samples used
to calculate stays constant, with new samples replacing the
oldest ones. The queue holdtime calculation uses all holdtime
samples collected since the queue was loaded, so the comment
has been changed to be accurate.

(closes issue #12781)
Reported by: davidw


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123275 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-17 15:57:43 +00:00
Russell Bryant 8b1646163d Merged revisions 123271 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r123271 | russell | 2008-06-17 10:48:31 -0500 (Tue, 17 Jun 2008) | 4 lines

Fix a memory leak in astobj2 that was pointed out by seanbright.  When a container
got destroyed, the underlying bucket list entry for each object that was in the
container at that time did not get free'd.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123272 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-17 15:52:13 +00:00
Jeff Peeler c837af5e28 Fix some (more) variables that were forgotten to be renamed, related to 117658
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123238 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-16 23:05:18 +00:00
Doug Bailey 2690378411 Clean up code that handles fsk mwi message generation by pulling it from do_monitor and creating its own thread.
Added RP-AS mwi message generation using patches from meneault as a basis. 

(closes issue #8587)
Reported by: meneault
Tested by: meneault



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123203 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-16 21:42:46 +00:00
Tilghman Lesher ddfac77569 Oopsie, breakage
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123201 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-16 21:31:43 +00:00
Jeff Peeler 121c046ba5 Fix some variables that were forgotten to be renamed, related to 117658
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123166 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-16 21:15:12 +00:00
Steve Murphy f4c85ebd22 (closes issue #12689)
Reported by: ys

Many thanks to ys for doing the research on this problem.
I didn't think it would be best to unlock the contexts
and then relock them after the remove_extension2() call,
so I added an extra arg to remove_extension2() and set it
appropriately in each call. There were not that many.

I considered forcing the code to lock the contexts before
the call to remove_extension2(), but that would require
a slightly greater degree of changes, especially since
the find_context_locked is local to pbx.c

I did a simple sanity test to make sure the code doesn't
mess things up in general.




git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123165 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-16 20:43:46 +00:00