Commit Graph

2131 Commits

Author SHA1 Message Date
Tilghman Lesher 94d71436ec 1. Rename 'maxmessage' to 'maxsecs' to differentiate from 'maxmsg'.
2. Rename 'minmessage' to 'minsecs' for parity.
3. Make 'maxsecs' a per-user option, in addition to global.
(Issue # 8624)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@49075 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-31 04:54:20 +00:00
Olle Johansson 253e1daa49 From coding guidelines:
Comments should explain what the code does, not when something was changed
  or who changed it. If you have done a larger contribution, make sure
  that you are added to the CREDITS file.




git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48984 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-27 16:58:03 +00:00
Joshua Colp b3ca8342fd Merged revisions 48966 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r48966 | file | 2006-12-26 00:20:08 -0500 (Tue, 26 Dec 2006) | 2 lines

Get rid of a needless memory allocation and only create a conference structure in find_conf_realtime if data was read from realtime. (issue #8669 reported by robl)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48967 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-26 05:23:25 +00:00
Luigi Rizzo 09f75aa6dc rename the structs struct tone_zone_sound and struct tone_zone
defined in indications.h to ind_tone_zone_sound and ind_tone_zone,
to avoid conflicts with the structs with the same names
defined in tonezone.h

Hope i haven't missed any instance.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48958 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-25 06:38:09 +00:00
Luigi Rizzo 5727170842 improve readability of a few macros.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48857 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-22 10:35:20 +00:00
Luigi Rizzo 51f9566199 make sms_hexdump() thread safe;
restructure and reduce indentation on some blocks.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48844 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-21 23:33:44 +00:00
Luigi Rizzo 250c74d10c make isodate thread-safe
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48832 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-21 22:15:03 +00:00
Luigi Rizzo 99359a4b27 - use the standard option parsing routines;
- document existing but undocumented parameters to send a message
  (untested but unchanged;

- ad a new option p(N) to set the initial message delay to N ms
  so this can be adapted from the dialplan to various countries;
 



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48825 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-21 22:03:54 +00:00
Luigi Rizzo fbe6afd136 put generator functions next to each other.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48768 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-21 19:52:18 +00:00
Steve Murphy 7b338004bf a quick fix to app_sms.c to get rid of cursed compiler warnings so I can compile under --enable-dev-mode
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48767 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-21 19:44:20 +00:00
Luigi Rizzo 1080c61d04 reduce indentation
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48752 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-21 18:54:17 +00:00
Luigi Rizzo 067573020d restructure a block to reduce nesting
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48750 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-21 18:35:22 +00:00
Luigi Rizzo 1ce6943f4f Add a bit of documentation on this code, including pointers
to relevant documents and comment on timing issues.

Initial merge of the code in

	http://bugs.digium.com/view.php?id=8586

by Filippo Grassilli (Hyppo) to support
the SMS Protocol 2.

In this commit i have tried to minimize the diffs, so further
code cleanup will come in subsequent commits.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48736 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-21 16:50:26 +00:00
Joshua Colp 1546495afc Clean up app_page
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48639 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-20 04:32:59 +00:00
Joshua Colp e54265a914 Merged revisions 48637 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r48637 | file | 2006-12-19 21:56:09 -0500 (Tue, 19 Dec 2006) | 2 lines

vms doesn't exist on non-IMAP storage builds.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48638 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-20 02:58:13 +00:00
Luigi Rizzo 6ef9c2a16c more formatting cleanup.
Move some code into a function sms_compose1() in preparation
for supporting protocol 2 as well.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48599 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-20 00:13:23 +00:00
Luigi Rizzo 21556620d0 formatting and code cleanup.
Still a lot of copy&pasted code here...



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48598 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-19 23:56:08 +00:00
Joshua Colp 75b125b96e Merged revisions 48596 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r48596 | file | 2006-12-19 18:04:30 -0500 (Tue, 19 Dec 2006) | 2 lines

Pass 'vms' pointer to record_and_review so it is then passed to the IMAP store file function. (issue #8614 reported by punknow)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48597 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-19 23:05:57 +00:00
Luigi Rizzo 8a26d19b7c start documenting this code.
On passing, fix the bogus datalen on outgoing frames
just fixed in 1.4 rev.48583



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48588 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-19 21:29:55 +00:00
Luigi Rizzo 83f52ed5e2 better name for struct dial_localuser.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48581 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-19 16:36:45 +00:00
Luigi Rizzo a755ec928a introduce a temporary variable for tmp->chan to shorten expressions.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48575 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-19 09:58:40 +00:00
Luigi Rizzo 9c81431c93 stop what i think is a memory leak in case Dial fails to
connect to a channel.

Before committing to 1.4 i would like some other people to
review and test this fix - thanks.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48574 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-19 09:33:57 +00:00
Luigi Rizzo 9d4531d636 move a large block related to privacy handling to a separate function.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48573 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-19 09:15:23 +00:00
Luigi Rizzo ccebf3511c convert the final clients of ast_build_string to use ast_str_*()
Now the only module left using it is chan_sip.c



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48559 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-18 15:38:50 +00:00
Luigi Rizzo 18e5017634 replace ast_build_string() with ast_str_*();
simplify __queues_show()



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48550 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-17 22:47:30 +00:00
Joshua Colp 00a02844ba Merged revisions 48401 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r48401 | file | 2006-12-11 23:13:48 -0500 (Mon, 11 Dec 2006) | 2 lines

Use S_OR in my previous app_voicemail. This is the way it should have been done.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48402 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-12 04:14:50 +00:00
Matt O'Gorman a395bd7c1d Merged revisions 48396 via svnmerge from
https://svn.digium.com/svn/asterisk/branches/1.4

................
r48396 | mogorman | 2006-12-11 16:11:35 -0600 (Mon, 11 Dec 2006) | 12 lines

Merged revisions 48394 via svnmerge from 
https://svn.digium.com/svn/asterisk/branches/1.2

........
r48394 | mogorman | 2006-12-11 15:55:43 -0600 (Mon, 11 Dec 2006) | 4 lines

app_externalivr needs a real silence file, and additional
changes to add silence files into core instead of extra
patch provided by bug 8177 with minor additions.

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48397 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-11 22:31:20 +00:00
Joshua Colp c393e8f664 Merged revisions 48391 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r48391 | file | 2006-12-11 16:31:23 -0500 (Mon, 11 Dec 2006) | 2 lines

Return non-existant callerid handling to that which it was before. In 1.4 and trunk callerid can be allocated but not have any contents so we have to use ast_strlen_zero before passing it to the relevant functions. (issue #8567 reported by pabelanger)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48392 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-11 21:35:28 +00:00
Joshua Colp c0c1c35e9a Merged revisions 48379 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r48379 | file | 2006-12-11 00:30:01 -0500 (Mon, 11 Dec 2006) | 2 lines

Use the correct API call to say a device state changed. (Yes, I'm a nub.)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48380 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-11 05:34:53 +00:00
Joshua Colp f5c2b80787 Merged revisions 48377 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r48377 | file | 2006-12-10 23:57:38 -0500 (Sun, 10 Dec 2006) | 2 lines

Don't access the conference structure after it has been freed.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48378 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-11 05:01:37 +00:00
Tilghman Lesher d670858735 Merged revisions 48375 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r48375 | tilghman | 2006-12-10 18:47:21 -0600 (Sun, 10 Dec 2006) | 13 lines

Merged revisions 48374 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r48374 | tilghman | 2006-12-10 18:33:59 -0600 (Sun, 10 Dec 2006) | 5 lines

When doing a fork() and exec(), two problems existed (Issue 8086):
1) Ignored signals stayed ignored after the exec().
2) Signals could possibly fire between the fork() and exec(), causing Asterisk
signal handlers within the child to execute, which caused nasty race conditions.

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48376 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-11 00:52:19 +00:00
Russell Bryant 5824af9cbc Resolve some pointer signedness compiler warnings in app_osplookup, and
constify a bunch of usage strings for CLI commands.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48307 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-06 07:39:39 +00:00
TransNexus OSP Development d905761eac 1. Change to remove the compiling warning: "app_osplookup.c:2169: warning: initialization discards qualifiers from pointer target type"
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48266 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-05 14:33:21 +00:00
Tilghman Lesher 02a66bee1d Merged revisions 48254 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r48254 | tilghman | 2006-12-04 19:41:02 -0600 (Mon, 04 Dec 2006) | 2 lines

Oops, forgot to release the odbc handle

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48255 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-05 01:46:14 +00:00
Tilghman Lesher 1256ac0519 Merged revisions 48252 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r48252 | tilghman | 2006-12-04 19:34:34 -0600 (Mon, 04 Dec 2006) | 14 lines

Merged revisions 48251 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r48251 | tilghman | 2006-12-04 19:26:08 -0600 (Mon, 04 Dec 2006) | 6 lines

If the recording in the database is too large, it will fail to retrieve with
an mmap error.  Not too sure why this doesn't happen when we put it in the
database, also, but since that doesn't seem to be broken, I'm not going to fix
it (at least until someone reports it).  Solution is to ask for the file in
smaller chunks.  (Bug 8385)

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48253 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-05 01:39:53 +00:00
Jason Parker 05261e30e9 Merged revisions 48248 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r48248 | qwell | 2006-12-04 15:48:41 -0600 (Mon, 04 Dec 2006) | 2 lines

Fix an issue which didn't allow unavail/greet/busy/etc messages from being saved into ODBC (and probably IMAP).

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48249 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-04 21:49:38 +00:00
Olle Johansson cf628af83d Doxygenification
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48206 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-02 14:07:20 +00:00
Kevin P. Fleming 359a553961 Merged revisions 48193 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r48193 | kpfleming | 2006-12-01 17:37:28 -0600 (Fri, 01 Dec 2006) | 10 lines

Merged revisions 48192 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r48192 | kpfleming | 2006-12-01 17:30:59 -0600 (Fri, 01 Dec 2006) | 2 lines

if Dial() is going to send music-on-hold to the calling party, it has to send PROGRESS first to ensure that the reverse audio path has been setup first (BE-106)

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48194 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-01 23:39:59 +00:00
Joshua Colp 1cc4009bc6 Merged revisions 48115 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r48115 | file | 2006-11-29 16:05:17 -0500 (Wed, 29 Nov 2006) | 2 lines

Use MAILTMPLEN instead of sizeof in mm_login. (issue #8420 reported by slimey)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48116 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-29 21:07:14 +00:00
Joshua Colp 62157d2839 Merged revisions 48101 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r48101 | file | 2006-11-28 23:26:53 -0500 (Tue, 28 Nov 2006) | 2 lines

Don't crash if the mailstream was not created.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48102 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-29 04:28:21 +00:00
Joshua Colp 8017bc6e6f Merged revisions 48054 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r48054 | file | 2006-11-27 13:06:50 -0500 (Mon, 27 Nov 2006) | 10 lines

Merged revisions 48053 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r48053 | file | 2006-11-27 13:03:57 -0500 (Mon, 27 Nov 2006) | 2 lines

Use the proper function to get the new message count instead of always using the filesystem. (issue #8421 reported by slimey)

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48056 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-27 18:10:59 +00:00
Luigi Rizzo bbba4e5a20 better fix for the previous bug.
In general this code needs a deep revision, because the body of
do_forward() deletes/overwrites the output channel without freeing
the resouce in some cases, and without notifying the caller.

Also, on FreeBSD with MALLOC_OPTIONS set i am seeing various panics
(duplicate freee etc.)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47881 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-21 11:53:06 +00:00
Luigi Rizzo 64a9c28c3b do not ast_hangup() on a NULL channel.
In the original code this would happen in the case of
	o->forwards >=  AST_MAX_FORWARDS

Likely an 1.2/1.4 isse as well - please someone have a look,
while I am hunting a few more similar panics now.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47880 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-21 11:07:30 +00:00
Tilghman Lesher e78c50a201 Merged revisions 47864-47865 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r47864 | tilghman | 2006-11-20 14:01:58 -0600 (Mon, 20 Nov 2006) | 2 lines

Oops, merge missed release of odbc object

........
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47866 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-20 20:04:11 +00:00
Joshua Colp af51be05a6 Merged revisions 47850 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r47850 | file | 2006-11-20 10:51:37 -0500 (Mon, 20 Nov 2006) | 2 lines

Use a separate variable in the channel structure to store the context that the channel was dialed from. (issue #8382 reported by jiddings)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47851 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-20 15:55:58 +00:00
Steve Murphy 6dcb17baaf This update fulfils the request of bug 7109, which claimed the language arg to ast_stream_and_wait() was redundant. Almost all calls just used chan->language, and seeing how chan is the first argument, this certainly seems redundant. A change of language could just as easily be done by simply changing the channel language before calling.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47821 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-17 23:18:51 +00:00
Jason Parker 54d44e9b00 Add ability to notify an external application/script that the voicemail password was,
while also still changing the password "internally".

Issue 7371, initial patch by pdunkel, with rewrite/config comments by me.
Additional modifications (yay bitmask) by pdunkel.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47814 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-17 21:51:42 +00:00
Jason Parker a1a37dddfe Add ability to add custom queue log via manager interface.
Issue 7806, patch by alexrch, with slight modifications by me.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47806 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-17 20:46:36 +00:00
Jason Parker 938c4bdc29 Merged revisions 47782 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r47782 | qwell | 2006-11-16 17:19:46 -0600 (Thu, 16 Nov 2006) | 2 lines

Fix a couple of typos.  Initially pointed out by mrobinson.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47783 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-16 23:20:52 +00:00
Joshua Colp 9a40c9c4f2 Merged revisions 47748 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r47748 | file | 2006-11-16 12:52:48 -0500 (Thu, 16 Nov 2006) | 2 lines

Don't unreference the SLA object if there is no SLA object in the devicestate callback. (issue #8354 reported by loloski)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47749 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-16 17:53:58 +00:00