Commit Graph

5564 Commits

Author SHA1 Message Date
Russell Bryant 0dbd863733 Merged revisions 152539 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r152539 | russell | 2008-10-29 00:23:51 -0500 (Wed, 29 Oct 2008) | 7 lines

Fix an incorrect usage of sizeof()

(closes issue #13795)
Reported by: andrew53
Patches:
	chan_sip_sizeof.patch uploaded by andrew53 (license 519)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152569 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-29 05:34:26 +00:00
Tilghman Lesher e9d96775ad Only re-add the io port if it was closed, otherwise reload causes a memory
leak.
(closes issue #13785)
 Reported by: eliel
 Patches: 
       chan_mgcp.c.patch uploaded by eliel (license 64)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152442 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-28 21:38:26 +00:00
Jeff Peeler 33f576f1a1 Merged revisions 152286 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r152286 | jpeeler | 2008-10-27 18:28:49 -0500 (Mon, 27 Oct 2008) | 2 lines

Buffer policy setting for half is not needed.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152287 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-27 23:31:39 +00:00
Tilghman Lesher ae991d086e Merged revisions 152215 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r152215 | tilghman | 2008-10-27 16:32:00 -0500 (Mon, 27 Oct 2008) | 6 lines
  
  Inherit ALL elements of CallerID across a local channel.
  (closes issue #13368)
   Reported by: Peter Schlaile
   Patches: 
         20080826__bug13368.diff.txt uploaded by Corydon76 (license 14)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152216 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-27 21:34:04 +00:00
Olle Johansson 0fdde26109 Trying to fix the user/peer matching correctly. This will need some testing before
getting merged into 1.6.1


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152020 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-26 10:23:01 +00:00
Olle Johansson 9137733e11 Moving more variables to the sip_cfg structure, as I have some future ideas for the usage of that structure.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152019 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-26 09:45:17 +00:00
Olle Johansson 31a9f1e6f0 Doxygen changes and some formatting.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151980 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-26 09:19:19 +00:00
Olle Johansson 5aa23add8c Adding a small new feature.
Setting _SIPFROMDOMAIN in a channel will set the domain we use for the URI in the outbound call leg.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151739 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-23 15:30:16 +00:00
BJ Weschke d7422c975e revert the changes in issue #13705 - it's being re-opened as while the results fixed the complaint in the issue, it introduced other more undesirable issues than what was already reported
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151642 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-22 20:45:03 +00:00
Mark Michelson 0748be1052 Change some logical ands to bitwise ands and add
messages alerting that a channel is being ignored
if the PROC_DAHDI_NOCHAN option is set in process_dahdi.

(closes issue #13759)
Reported by: smurfix
Patches:
      dahdi.patch uploaded by smurfix (license 547)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151600 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-22 20:05:14 +00:00
Russell Bryant 89e0def9f9 Print out the right var in the log message
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151555 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-22 17:45:05 +00:00
Russell Bryant ca14f718d7 Fix this check to use the proper variable (the result from get_in_brackets)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151554 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-22 17:44:05 +00:00
Mark Michelson cfa9531311 The logic of a strncasecmp call was reversed.
(closes issue #13706)
Reported by: andrew53
Patches:
      sip_notify_from_rfc3265.patch uploaded by andrew53 (license 519)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151512 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-22 15:08:25 +00:00
Mark Michelson 97dac2d91a Make the sip_standard_port function more granular by allowing separate
type and port arguments. This is necessary because when building our From
and Contact headers, we need to be absolutely sure that we are placing our
source port there and not the peer's source port.

(closes issue #12761)
Reported by: asbestoshead
Patches:
      patch-chan-sip-contact-port.txt uploaded by asbestoshead (license 455)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151464 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-21 23:54:41 +00:00
Mark Michelson f4561c0e46 Get this compiling in dev-mode
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151439 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-21 23:31:17 +00:00
Mark Michelson 2c55dcf8a8 If a peer uses any transport other than UDP, then MWI will
fail for that peer since sip_alloc will allocate a sip_pvt with
a default transport of UDP. This change resets the socket type
immediately after allocating the sip_pvt in sip_send_mwi_from_peer,
so that the proceeding call to create_addr_from_peer does not fail
right away. The socket data from the peer is properly copied to
the sip_pvt in create_addr_from_peer.

(closes issue #13710)
Reported by: andrew53
Patches:
      sip_notify_use_tcp.patch uploaded by andrew53 (license 519)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151428 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-21 23:27:45 +00:00
Mark Michelson bceb0845e6 When attempting to resolve hostnames, we need to be sure
to remove any parameters from the string so that name
resolution succeeds.

(closes issue #13727)
Reported by: fnordian
Patches:
      resolvewithouturiparameter.patch uploaded by fnordian (license 110)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151420 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-21 23:08:56 +00:00
BJ Weschke 5a6a59c84b Fix configuration parsing so type=friend still identifies "friend" as a peer even though it is now a legacy configuration verb.
(closes issue #13705)
 reported by: blitzrage
 patched by: bweschke



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151327 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-21 11:02:08 +00:00
Kevin P. Fleming 1ddc834b39 cleaup of the TCP/TLS socket API:
1) rename 'struct server_args' to 'struct ast_tcptls_session_args', to follow coding guidelines

2) make ast_make_file_from_fd() static and rename it to something that indicates what it really is for (again coding guidelines)

3) rename address variables inside 'struct ast_tcptls_session_args' to be more descriptive (dare i say it... coding guidelines)

4) change ast_tcptls_client_start() to use the new 'remote_address' field of the session args for the destination of the connection, and use the 'local_address' field to bind() the socket to the proper source address, if one is supplied

5) in chan_sip, ensure that we pass in the PP address we are bound to when creating outbound (client) connections, so that our connections will appear from the correct address



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151101 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-19 19:11:28 +00:00
Michiel van Baak 6f860c262d dont segfault when placing a call to a line that has no registered device.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151060 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-19 13:10:50 +00:00
Olle Johansson 235d4159f6 Adding changes from train and flight back home from SIPit23 in Lannion, France.
- Additional comments on TCP/TLS implementation
- Some additions for new drafts/rfcs (no new functionality really, mostly documentation)
- Other random small fixes


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151019 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-19 07:20:40 +00:00
Matthew Fredrickson 3e83151375 Merge in patch for #13454. Includes CallRereouting dialplan application, option for discard of remote hold messages, and using the alternate logical channel mapping in Q.SIG instead of the default physical channel mapping.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150640 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-17 17:25:58 +00:00
Tilghman Lesher 6450b7c4da Make helper call a little safer (suggested by Russell on IRC)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150635 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-17 17:09:03 +00:00
Tilghman Lesher b3bb9564d3 Fix the FRACK! warnings in chan_iax2 when POKE/LAGRQ packets are not answered.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150580 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-17 16:34:29 +00:00
Olle Johansson e3ea5c3c36 Adding some additional thoughts on configuration changes to TCP/TLS
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150510 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-17 08:42:44 +00:00
Michiel van Baak 59d9255977 Break up skinny.conf into seperate sections for
devices and lines.

(closes issue #13412)
Reported by: wedhorn
Patches:
      config-restruct-v4.diff uploaded by wedhorn (license 30)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150426 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-17 06:00:28 +00:00
Mark Michelson 32ef7bedd3 Add an IAXregistry manager command. See doc/manager_1_1.txt
for more details of this command.

(closes issue #13326)
Reported by: ib2
Patches:
      bug13326_trunk_20080822.diff uploaded by snuffy (license 35)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150311 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-17 00:18:01 +00:00
Mark Michelson 1b1efebf4b After a long discussion on #asterisk-bugs, it seems kind of
odd that a channel would be named after the originating port. 
For endpoints that always include ":5060" as part
of the From: header, it will mean that you have a ton of
channels with names like "SIP/5060-3ea38a8b."

I am boldly moving forward with this change in trunk, but I'm
not touching other branches with this one since this definitely
would qualify as a behavior change. If there is a problem with
this commit, and I haven't seen the obvious reason why you'd want
to name the channel after the port from which the call originated,
then please feel free to revert this



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150307 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-17 00:13:35 +00:00
Mark Michelson d8d6d5e35b Remove an odd redundant comparison
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150253 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-16 22:30:23 +00:00
Mark Michelson 4d983e34cf INVITES with proxy auth were sent with a different branch
than what was in the invite_branch of a sip_pvt, meaning
that if a CANCEL were sent later, the branch in the CANCEL
would not match the branch in the latest INVITE sent out, leading
to some endpoints responding to the CANCEL with a 481.

(closes issue #13714)
Reported by: fnordian
Patches:
      invite_branch.patch uploaded by fnordian (license 110)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150207 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-16 20:57:18 +00:00
Richard Mudgett de9c5d4c42 Merged revisions 150124 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r150124 | rmudgett | 2008-10-16 10:56:06 -0500 (Thu, 16 Oct 2008) | 1 line
  
  Fix memory leak found by customer
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150125 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-16 16:04:45 +00:00
Kevin P. Fleming 2f3193ec70 ensure that type=peer entries are only matched on IP/port, not on name (after oej audits all the calls to find_peer() to make sure that forcenamematch is set correctly in each case)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150052 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-16 15:02:10 +00:00
Olle Johansson 11a94d5b01 Doxygen addition
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150051 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-16 15:00:30 +00:00
Olle Johansson 1d2ef991e2 Add some notes on problems with the TCP/TLS implementation
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150008 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-16 13:52:23 +00:00
Kevin P. Fleming 4ca2b3836a return this logic to where it used to be, *after* the dialog->needdestroy flag has been determined to be set; otherwise, we generate these debug messages every time we inspect every active dialog
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@149981 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-16 13:28:56 +00:00
Kevin P. Fleming 1e56eb7e87 some additional debugging tools added at SIPit23:
- move all setting of 'needdestroy' on dialog structures into the history

- report all tags involved when a pedantic check fails on a REFER



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@149964 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-16 13:23:23 +00:00
Mark Michelson e701f8ee2d Make the sip_proxy struct reference counted. This is
necessary to allow for a sip_pvt to maintain a reference
to a sip_peer's outboundproxy even after the peer has
been freed.

(closes issue #13700)
Reported by: fnordian
Patches:
      13700.patch uploaded by putnopvut (license 60)
Tested by: fnordian



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@149802 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-15 20:55:42 +00:00
Olle Johansson 216673ad76 Adding a note about a missing part of "kill-the-user" - I got lost in the Ao2 world...
We're going to try to get time to fix this and kpfleming believes that there's code in ao2 
so that we can solve it...


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@149542 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-15 13:52:13 +00:00
Kevin P. Fleming f00735b317 Merged revisions 149452 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r149452 | kpfleming | 2008-10-15 12:30:40 +0200 (Wed, 15 Oct 2008) | 3 lines
  
  fix some problems when parsing SIP messages that have the maximum number of headers or body lines that we support
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@149487 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-15 11:26:36 +00:00
Olle Johansson 7fa8f65425 Fixing sytax errors ;-)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@149342 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-15 07:45:09 +00:00
Mark Michelson 63b894e391 Merged revisions 149266 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r149266 | mmichelson | 2008-10-14 18:43:58 -0500 (Tue, 14 Oct 2008) | 4 lines

Change this warning to an error message. Suggestion
comes from Sean Bright. Thanks Sean!


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@149271 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14 23:44:44 +00:00
Mark Michelson 83663de0ed Merged revisions 149207 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r149207 | mmichelson | 2008-10-14 18:10:26 -0500 (Tue, 14 Oct 2008) | 9 lines

Call register_peer_exten even in the case that the peer's
IP/port does not change.

(closes issue #13309)
Reported by: dimas
Patches:
      v2-13309.patch uploaded by dimas (license 88)


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@149208 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14 23:15:04 +00:00
Tilghman Lesher d5837ba8c2 Add additional memory debugging to several core APIs, and fix several memory
leaks found with these changes.
(Closes issue #13505, closes issue #13543)
Reported by: mav3rick, triccyx
 Patches: 
       20081001__bug13505.diff.txt uploaded by Corydon76 (license 14)
 Tested by: mav3rick, triccyx


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@149199 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14 22:38:06 +00:00
Mark Michelson c6caf2a06f Merged revisions 149130 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r149130 | mmichelson | 2008-10-14 15:49:02 -0500 (Tue, 14 Oct 2008) | 7 lines

Don't allow reserved characters to be used in register
lines in sip.conf.

(closes issue #13570)
Reported by: putnopvut


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@149131 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14 21:08:48 +00:00
Mark Michelson 4d9965856b Merged revisions 148912 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r148912 | mmichelson | 2008-10-14 12:33:38 -0500 (Tue, 14 Oct 2008) | 9 lines

Deadlock prevention in chan_local.

(closes issue #13676)
Reported by: tacvbo
Patches:
      13676.patch uploaded by putnopvut (license 60)
Tested by: tacvbo


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148913 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14 17:38:06 +00:00
Joshua Colp f230048cd3 Fix reference count issue that Russell brought up in SIP MWI NOTIFY support. Bump the reference count up before we add it to the scheduler, duh.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148867 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14 15:00:41 +00:00
Kevin P. Fleming 6ccc37dec9 fix some references to the owner of a private structure that may not be present
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148754 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14 11:31:40 +00:00
Kevin P. Fleming b616f924c6 this structure should be static
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148737 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14 10:32:01 +00:00
Kevin P. Fleming 90e01fcb0b ensure that *all* fields in the req structure are cleared out before reusing it; has_to_tag was not cleared, which caused the second incoming call over a TCP socket to fail if pedantic checking was enabled
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148695 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14 09:31:50 +00:00
Olle Johansson 7877ed93bb Adding some clarifications
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148679 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14 09:16:59 +00:00