Commit graph

13065 commits

Author SHA1 Message Date
Joshua Colp
a565584d05 Fix memory issue that crept up with Russell's testing. It is *not* proper to free the frame we get in ast_write.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81858 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-06 22:34:44 +00:00
Russell Bryant
bc8ac382b8 fix the build ... oops
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81849 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-06 22:32:03 +00:00
Russell Bryant
7c1b18f8ec Merged revisions 81832 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r81832 | russell | 2007-09-06 17:28:57 -0500 (Thu, 06 Sep 2007) | 16 lines

(closes issue #9724, closes issue #10374)
Reported by: kenw
Patches:
      9724.txt uploaded by russell (license 2)
Tested by: kenw, russell

Resolve a deadlock that occurs when doing a SIP transfer to parking.  

I come across this type of deadlock fairly often it seems.  It is very important
to mind the boundary between the channel driver and the core in respect to the
channel lock and the channel-pvt lock.  Channel drivers lock to lock the
pvt and then the channel once it calls into the core, while the core will do
it in the opposite order.  The way this is avoided is by having channel drivers
either release their pvt lock while calling into the core, or such as in this
case, unlocking the pvt just long enough to acquire the channel lock.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81839 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-06 22:30:15 +00:00
Jason Parker
bde7d34c0e Merged revisions 81826 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r81826 | qwell | 2007-09-06 17:05:02 -0500 (Thu, 06 Sep 2007) | 1 line

We added COPTS for ASTCFLAGS additions, but not LDOPTS for ASTLDFLAGS.  This adds LDOPTS
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81827 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-06 22:06:17 +00:00
Joshua Colp
5af36757cd Initialize iax_frames variable to NULL, keeps valgrind happy.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81814 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-06 21:01:10 +00:00
Russell Bryant
b068a17e60 Add EXTENSION_STATE() function that can retrieve the state of an extension that
has a hint.

(closes issue #10635, adamgundy)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81813 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-06 20:54:07 +00:00
Russell Bryant
905f15d0b0 s/DEVSTATE/DEVICE_STATE/
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81785 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-06 20:27:53 +00:00
Russell Bryant
fa0536aab9 Rename the DEVSTATE() function to DEVICE_STATE() to better conform to how other
functions are named.
(inspired by issue #10635)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81784 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-06 20:27:26 +00:00
Russell Bryant
65b4a88c60 Merge HINT() dialplan function from my sandbox branch into trunk. This function
will let you retrieve the list of devices or name associated with a hint.
(inspired by issue #10635)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81783 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-06 20:24:18 +00:00
Joshua Colp
f614bc7004 (closes issue #10377)
Reported by: mvanbaak
Patches:
      chan_skinny_info.diff uploaded by mvanbaak (license 7)
Add skinny show device, skinny show line, and skinny show settings CLI commands.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81782 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-06 20:16:02 +00:00
Russell Bryant
235417dbd0 Fix the syntax of declaring a hint with a name to be compatible with trunk
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81781 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-06 20:05:50 +00:00
Jason Parker
9f865889a2 Merged revisions 81778 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r81778 | qwell | 2007-09-06 14:59:07 -0500 (Thu, 06 Sep 2007) | 2 lines

This should fix a build issue that people building against uClibc were seeing with the addition of astobj2

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81779 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-06 20:00:08 +00:00
Joshua Colp
8c8979936d Merged revisions 81776 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r81776 | file | 2007-09-06 16:40:37 -0300 (Thu, 06 Sep 2007) | 7 lines

(closes issue #10122)
Reported by: stevefeinstein
Patches:
      meetme-unmute-manager.diff uploaded by qwell (license 4)
Tested by: stevefeinstein
After looking over the code I agree with Qwell. Setting the file descriptor to conference each time just causes a fight back and forth.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81777 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-06 19:43:20 +00:00
Philippe Sultan
da620112de Merged revisions 81743 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r81743 | phsultan | 2007-09-06 18:56:29 +0200 (Thu, 06 Sep 2007) | 1 line

Various string length fixes. Removed an unused variable in aji_client structure (context)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81745 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-06 17:00:58 +00:00
Tilghman Lesher
cd9c418200 Incorporate the ability to log output of safe_asterisk to syslog (closes issue #9882)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81744 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-06 16:57:20 +00:00
Matthew Fredrickson
c61d954422 Patch on 10575. Add support for unequipped CIC (UCIC) message as well as improve some of our CIC flags in chan_zap
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81742 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-06 16:38:54 +00:00
Mark Michelson
ba8c1b5243 Merged revisions 81713 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r81713 | mmichelson | 2007-09-06 11:25:40 -0500 (Thu, 06 Sep 2007) | 6 lines

Fixes an issue where valid DTMF had to be pressed twice to exit a queue if a member's phone
was ringing.

(closes issue #10655, reported by strider2k, patched by me)


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81730 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-06 16:31:30 +00:00
Luigi Rizzo
8e62c6c4d0 various changes to the documentation, and redefinition of
ao2_hash_fn and ao2_callback_fn typedefs, in preparation
to more cleanup of the _search_flags

Please do not merge this change to 1.4 yet - there are no
functional changes anyways.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81712 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-06 15:43:49 +00:00
Mark Michelson
6d61ac8cc2 Merged revisions 81682 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r81682 | mmichelson | 2007-09-06 10:20:36 -0500 (Thu, 06 Sep 2007) | 5 lines

Fixes a memory leak

(closes issue #10658, reported and patched by Ivan)


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81683 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-06 15:21:45 +00:00
Philippe Sultan
cbbfbb65e8 Merged revisions 81650 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r81650 | phsultan | 2007-09-06 16:20:54 +0200 (Thu, 06 Sep 2007) | 3 lines

According to both RFC 3920 - section 9.1.2 - and Google's XMPP server
complaint, if set, the 'from' attribute must be set to the user's full
JID.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81651 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-06 14:24:29 +00:00
Mark Michelson
e9548619cf Not having this epoll specific code in wait_for_answer was causing app_queue to infinitely loop.
This makes it so it doesn't. Thanks to file for pointing out where the problem was and showing
a similar function in app_dial as an example of how to fix it.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81632 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-05 21:59:52 +00:00
Tilghman Lesher
9169ac8ef4 Merged revisions 81569 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r81569 | tilghman | 2007-09-05 12:18:24 -0500 (Wed, 05 Sep 2007) | 2 lines

Solaris x86 compatibility fix

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81631 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-05 21:45:19 +00:00
Dwayne M. Hubbard
0075b2d632 added ZAPATELLERSTATUS to app_zapateller
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81601 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-05 20:58:48 +00:00
Russell Bryant
8bcfddc8ec Merged revisions 81599 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r81599 | russell | 2007-09-05 15:53:41 -0500 (Wed, 05 Sep 2007) | 11 lines

Fix an issue that can occur when you do an attended transfer to parking.  If
you complete the transfer before the announcement of the parking spot finishes,
then the channel being parked will hear the remainder of the announcement.
These changes make it so that will not happen anymore.

Basically, res_features sets a flag on the channel is playing the announcement
to so that the file streaming core knows that it needs to watch out for a
channel masquerade, and if it occurs, to abort the announcement.

(closes BE-182)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81600 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-05 20:58:19 +00:00
Tilghman Lesher
01c1449d98 Add two more generated files (requested by mvanbaak via irc)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81568 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-05 16:48:43 +00:00
Jason Parker
d72ea80a00 Doxygen cleanups/fixes.
Closes issue #10654, patch by snuffy


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81560 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-05 16:31:39 +00:00
Mark Michelson
504f8a09af Weird. When I merged my changes from 1.4, they merged into the wrong function.
This should fix the build for trunk.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81535 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-05 15:32:58 +00:00
Mark Michelson
2b60033542 Merged revisions 81525 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r81525 | mmichelson | 2007-09-05 10:19:47 -0500 (Wed, 05 Sep 2007) | 4 lines

Fixing the build...



........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81526 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-05 15:23:57 +00:00
Jason Parker
9a46a17c27 Merged revisions 81523 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

(closes issue #10651)
........
r81523 | qwell | 2007-09-05 10:14:30 -0500 (Wed, 05 Sep 2007) | 5 lines

Do not try to unregister a NULL channel tech.
Also changed load_module function to use defines rather than numbers for return values.

Issue 10651, patch by rbraun_proformatique, with additions by me.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81524 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-05 15:16:50 +00:00
Mark Michelson
3d62457e96 Merged revisions 81520 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r81520 | mmichelson | 2007-09-05 10:03:22 -0500 (Wed, 05 Sep 2007) | 6 lines

Reverting behavior of QUEUE_MEMBER_COUNT to only count members who are logged in
and available.

(related to issue #10652, reported by wuwu)


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81522 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-05 15:04:50 +00:00
Steve Murphy
dcb85e2456 this set of changes fixes issue # 10643 by keeping track of the last object defined in a file, and attaching any accumulated comments to that object (category header or variable declaration). The file_save routine also had to be upgraded to output these trailing comments. Config.h was modified to include the trailing comment list on categories and variables.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81519 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-05 14:47:45 +00:00
Joshua Colp
3e56df5076 Blocked revisions 81492 via svnmerge
........
r81492 | file | 2007-09-05 10:11:48 -0300 (Wed, 05 Sep 2007) | 4 lines

(closes issue #10650)
Reported by: tacvbo
Only print out that the spy was removed while holding the spy lock.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81493 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-05 13:13:02 +00:00
Joshua Colp
1df4047b4a Finish up commit from revision 81452 by removing last remnants of strlcat/strlcpy checks.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81459 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-05 00:53:14 +00:00
Jason Parker
046424a96d Merged revisions 81455 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

(closes issue #10634)
........
r81455 | qwell | 2007-09-04 15:54:51 -0500 (Tue, 04 Sep 2007) | 4 lines

Rather than attempt to play a file, we can just check whether it exists.

Issue 10634, patch by me, testing by pabelanger, sanity checked by bweschke

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81456 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-04 20:59:04 +00:00
Jason Parker
a087396798 Merged revisions 81453 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

(closes issue #10644)
........
r81453 | qwell | 2007-09-04 14:56:06 -0500 (Tue, 04 Sep 2007) | 4 lines

Change default followme config file to point to the correct files.

Issue 10644, patch by pabelanger

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81454 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-04 19:56:46 +00:00
Russell Bryant
664d1d879b Don't check for and include strlcpy and strlcat in editline. We also include
them directly in Asterisk.  For platforms that need them (like my mac), you
will get a linker error due to the functions being included twice.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81452 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-04 19:51:37 +00:00
Russell Bryant
9bda1c5a94 Merged revisions 81448 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r81448 | russell | 2007-09-04 13:37:44 -0500 (Tue, 04 Sep 2007) | 4 lines

Remove the typedefs on ao2_container and ao2_iterator.  This is simply because
we don't typedef objects anywhere else in Asterisk, so we might as well make
this follow the same convention.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81449 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-04 18:40:07 +00:00
Russell Bryant
782b8ca0c9 logger.h depends on options.h, so go ahead and include it
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81445 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-04 18:02:02 +00:00
Kevin P. Fleming
96206c9289 Merged revisions 81442 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r81442 | kpfleming | 2007-09-04 11:40:39 -0500 (Tue, 04 Sep 2007) | 2 lines

there is no point in sending 401 Unauthorized to a UAS that sent us a properly-formatted Authentication header with the expected username and nonce but an incorrect response (which indicates the shared secret does not match)... instead, let's send 403 Forbidden so that the UAS doesn't retry with the same authentication credentials repeatedly

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81443 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-04 16:41:14 +00:00
Joshua Colp
944352251d (closes issue #10633)
Reported by: pabelanger
Patches:
      extensions.ael.sample.patch uploaded by pabelanger (license 224)
Update extensions.ael.sample with voicemail and | changes.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81441 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-04 14:28:13 +00:00
Joshua Colp
3213f6dc2d Merged revisions 81439 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r81439 | file | 2007-09-04 11:23:18 -0300 (Tue, 04 Sep 2007) | 6 lines

(closes issue #10632)
Reported by: jamesgolovich
Patches:
      asterisk-iaxfirmwareleak.diff.txt uploaded by jamesgolovich (license 176)
Fix memory leak when unloading chan_iax2. The firmware files were not being freed.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81440 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-04 14:25:21 +00:00
Joshua Colp
352fd9d942 Merged revisions 81437 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r81437 | file | 2007-09-04 10:46:23 -0300 (Tue, 04 Sep 2007) | 4 lines

(closes issue #10476)
Reported by: mdu113
Only look for the end of a digit when waiting for a digit. This in turn disables emulation in the core.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81438 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-04 13:47:33 +00:00
Joshua Colp
611d112eb7 Merged revisions 81435 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r81435 | file | 2007-09-04 10:10:56 -0300 (Tue, 04 Sep 2007) | 7 lines

(closes issue #10610)
Reported by: john
Patches:
      dns.c.patch uploaded by john (license 218)
Tested by: mvanbaak
Don't return a match if no SRV record actually exists.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81436 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-04 13:11:49 +00:00
Russell Bryant
51af103a79 Merged revisions 81433 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r81433 | russell | 2007-09-03 13:57:53 -0500 (Mon, 03 Sep 2007) | 5 lines

Remove a couple of calls to ast_string_field_free_pools() on peers in error
handling blocks in the code for building peers.  The peer object destructor
does this and doing it twice will cause a crash.
(closes issue #10625, reported by and patched by pnlarsson)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81434 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-03 18:59:08 +00:00
Tilghman Lesher
3305af34d6 Once we get past the file checks, we're loading, so clear the FILEUNCHANGED flag (fixes #include) (closes issue #10629)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81432 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-03 18:01:58 +00:00
Tilghman Lesher
314d4e6048 Merged revisions 81415 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r81415 | tilghman | 2007-08-31 14:16:52 -0500 (Fri, 31 Aug 2007) | 2 lines

The IF() function was not allowing true values that had embedded colons (closes issue #10613)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81431 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-03 03:01:31 +00:00
Tilghman Lesher
87044d37a0 We shouldn't use a filename blindly without checking to make sure it's unused first
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81430 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-02 14:37:53 +00:00
Mark Michelson
1bfe10997b Merged revisions 81426 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r81426 | mmichelson | 2007-09-01 01:02:06 -0500 (Sat, 01 Sep 2007) | 4 lines

Making match_by_addr into ao2_match_by_addr and making it available
everywhere since it could be a handy callback to have


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81427 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-01 06:03:22 +00:00
Russell Bryant
5872c6d757 Merged revisions 81418 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r81418 | russell | 2007-08-31 16:27:49 -0500 (Fri, 31 Aug 2007) | 2 lines

Remove references to a debugging parameter that does not exist

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81419 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-08-31 21:29:25 +00:00
Mark Michelson
a748fc6647 Merged revisions 81416 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r81416 | mmichelson | 2007-08-31 14:48:55 -0500 (Fri, 31 Aug 2007) | 6 lines

Fixed broken behavior of a reload on realtime queues. Prior to this patch, if a reload was issued and
a realtime queue had callers waiting in it, then the queue would be removed from the queue list, but it would
not actually be freed (in fact, a debug message warning about a memory leak would come up). With this patch,
reloads do not touch realtime queues at all.


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81417 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-08-31 19:50:26 +00:00