Commit Graph

15259 Commits

Author SHA1 Message Date
Jason Parker fe65716e15 If somebody enters a digit during ast_stream_and_wait, the return value is the digit, which we need to use later.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114149 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-15 20:27:04 +00:00
Steve Murphy 5b4222c9de These changes:
a. fix a self-found problem with SPAWN-ing an extension,
      where matches were not being found
   b. correct some wording in a comment
   c. Add some debug for future debugging.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114146 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-15 19:59:50 +00:00
Sean Bright 98c789ad12 I'm not sure why, but "this" bothers me. Ba dum dum.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114143 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-15 17:54:38 +00:00
Jason Parker b9bb0749d1 Shorten the mac address pattern, since some phones use different identifiers (such as the i2050 softphone).
(closes issue #12398)
Reported by: c_hans
Patches:
      chan_unistim_svn.diff uploaded by c (license 460)
Tested by: c_hans


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114141 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-15 17:21:58 +00:00
Jason Parker c2d0b572bf Merged revisions 114138 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114138 | qwell | 2008-04-15 12:17:18 -0500 (Tue, 15 Apr 2008) | 7 lines

Update Digium autosupport script, for more useful information.

(closes issue #12452)
Reported by: angler
Patches:
      autosupport.diff uploaded by angler (license 106)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114139 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-15 17:17:37 +00:00
Jason Parker f6cfccbc07 Merged revisions 114133 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114133 | qwell | 2008-04-15 11:18:08 -0500 (Tue, 15 Apr 2008) | 8 lines

Allow autofill to work in the general section of queues.conf.
Additionally, don't try to (re)set options when they have empty values in realtime (all unset columns would have an empty value).

(closes issue #12445)
Reported by: atis
Patches:
      12445-autofill.diff uploaded by qwell (license 4)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114134 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-15 16:18:38 +00:00
Jason Parker efb767e432 Convert several DEBUG logs into ast_debug.
(closes issue #12444)
Reported by: IgorG
Patches:
      channel_c_debug.diff uploaded by IgorG (license 20)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114131 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-15 15:20:47 +00:00
Terry Wilson 91de4e9cea Need a new buffer for each loop
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114127 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-14 19:58:52 +00:00
Terry Wilson 6d34b5fafe Don't unref user twice on failure. Also, when adding sorted list of users, it is best to check the entry already in the list for a "next" entry instead of the newly created entry...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114124 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-14 19:12:27 +00:00
Jason Parker 6e6d6f2e10 Merged revisions 114120 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114120 | qwell | 2008-04-14 13:31:57 -0500 (Mon, 14 Apr 2008) | 7 lines

The call_token on the pvt can occasionally be NULL, causing a crash.

If it is NULL, we can skip this channel, since it can't the one we're looking for.

(closes issue #9299)
Reported by: vazir

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114121 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-14 18:34:17 +00:00
Mark Michelson 0270776ca5 Merged revisions 114117 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114117 | mmichelson | 2008-04-14 12:41:03 -0500 (Mon, 14 Apr 2008) | 11 lines

Increase the retry count when attempting to show channels. This apparently
cleared an issue someone was seeing when attempting to show channels when
the load was high.

(closes issue #11667)
Reported by: falves11
Patches:
      11677.txt uploaded by russell (license 2)
Tested by: falves11


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114118 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-14 17:42:20 +00:00
Tilghman Lesher e7daf63fd8 Make tab-completion work for all cases
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114115 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-14 16:32:59 +00:00
Mark Michelson df7cb6b30b Merged revisions 114112 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114112 | mmichelson | 2008-04-14 11:24:22 -0500 (Mon, 14 Apr 2008) | 9 lines

If the datastore has been moved to another channel due to a masquerade, then
freeing the datastore here causes an eventual double free when the new channel
hangs up. We should only free the datastore if we were able to successfully remove
it from the channel we are referencing (i.e. the datastore was not moved).

(closes issue #12359)
Reported by: pguido


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114113 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-14 16:25:09 +00:00
Joshua Colp 6fad8249f5 During hangup it is possible for p->chan or p->owner to be NULL, so just return what the channel is bridged to instead of what they are *really* bridged to. Thanks Matt Nicholson!
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114109 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-14 15:36:02 +00:00
Mark Michelson 9ddc843fbe Merged revisions 114106 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114106 | mmichelson | 2008-04-14 09:58:02 -0500 (Mon, 14 Apr 2008) | 5 lines

Save a local copy of the generate callback prior to unlocking the channel in
case the generate callback goes NULL on us after the channel is unlocked. Thanks
to Russell for pointing this need out to me.


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114107 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-14 15:01:36 +00:00
Joshua Colp c5d0ca23f0 Merged revisions 114103 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114103 | file | 2008-04-14 11:52:46 -0300 (Mon, 14 Apr 2008) | 4 lines

It is possible for the remote side to say they want T38 but not give any capabilities.
(closes issue #12414)
Reported by: MVF

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114104 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-14 14:53:33 +00:00
Joshua Colp 5fff9c7304 Merged revisions 114100 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114100 | file | 2008-04-14 10:52:49 -0300 (Mon, 14 Apr 2008) | 4 lines

Don't change the SSRC when a new source comes into play, this might happen quite often and depending on the remote side... they might not like this.
(closes issue #12353)
Reported by: dimas

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114101 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-14 13:53:33 +00:00
Tilghman Lesher c716e8de53 Add tab command-line completion
(Closes issue #12428)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114098 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-14 02:55:41 +00:00
Tilghman Lesher dc3e185e96 Use ast_mkdir instead of mkdir
(Closes issue #12430)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114096 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-13 14:35:43 +00:00
Matthew Fredrickson 5110d3bc69 Make sure linkset is locked exiting ss7_start_call
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114093 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-12 16:21:29 +00:00
Matthew Fredrickson f9960bc748 Make sure we start incoming calls on SS7 with echo cancellation enabled. Also make sure when completing a COT we call ss7_start_call with the proper locks held. Lastly, make sure if we fail to get a channel from zt_new that we don't assume it's there.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114092 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-12 16:13:25 +00:00
Tilghman Lesher 7c26320110 If any field is not null, but has no default, then it must be set or the insert will fail.
(Closes issue #12285)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114090 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-11 23:26:56 +00:00
Tilghman Lesher 0dd46a6bf0 Make the sample config match the contributed LDAP schema
(Closes issue #12421)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114088 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-11 23:21:54 +00:00
Tilghman Lesher 7128ba0bb8 Use the correct function for free'ing objects, and maybe we won't crash.
(closes issue #12163)
 Reported by: gservat
 Patches: 
       20080411__bug12163.diff.txt uploaded by Corydon76 (license 14)
 Tested by: gservat


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114085 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-11 23:12:16 +00:00
Terry Wilson 4bc75c9a55 Merged revisions 114083 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114083 | twilson | 2008-04-11 17:32:51 -0500 (Fri, 11 Apr 2008) | 7 lines

Several places in the code called find_callno() (which releases the lock on the pvt structure) and then immediately locked the call and did things with it. Unfortunately, the call can disappear between the find_callno and the lock, causing Bad Stuff(tm) to happen.

Added find_callno_locked() function to return the callno withtout unlocking for instances that it is needed.

(issue #12400)
Reported by: ztel

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114084 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-11 22:48:52 +00:00
Terry Wilson ef8007f630 Make sure that ${LINE} is set even if linenumber is not set in users.conf
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114080 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-11 22:23:34 +00:00
Doug Bailey 9a1b485100 Change the number of line keys per registration from 2 to 1
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114077 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-11 22:09:04 +00:00
Jason Parker c7e913ed3f Blocked revisions 114072 via svnmerge
Already fixed here.

........
r114072 | qwell | 2008-04-11 16:35:16 -0500 (Fri, 11 Apr 2008) | 4 lines

It's possible that a channel can have an async goto on the successful execution of an application as well.

Closes issue #12172.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114073 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-11 21:39:44 +00:00
Terry Wilson e276ccea11 Fix the fact that global_variables 1) weren't being updated on reload (thanks for the report, Doug), and 2) weren't actually being appended to the list of profile variables because build_profile was called before the list was populated. Also needed to free the contents returned by load_file().
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114067 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-11 21:04:46 +00:00
Mark Michelson e409a129af Merged revisions 114063 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114063 | mmichelson | 2008-04-11 10:44:28 -0500 (Fri, 11 Apr 2008) | 11 lines

Fix a race condition that may happen between a sip hangup
and a "core show channel" command. This patch adds locking
to prevent the resulting crash.

(closes issue #12155)
Reported by: tsearle
Patches:
      show_channels_crash2.patch uploaded by tsearle (license 373)
Tested by: tsearle


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114064 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-11 15:49:35 +00:00
Tilghman Lesher d304a88457 Errors are all greater than 0
(closes issue #12422)
 Reported by: nito
 Patches: 
       res_config_ldap_result_check_patch.diff uploaded by nito (license 340)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114061 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-11 14:54:22 +00:00
Mark Michelson 115d5024a1 Merged revisions 114051 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114051 | mmichelson | 2008-04-10 15:59:49 -0500 (Thu, 10 Apr 2008) | 3 lines

Fix 1.4 build when LOW_MEMORY is enabled.


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114052 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-10 22:02:32 +00:00
Joshua Colp a08c4b2064 A 'b' option has been added which causes chan_local to return the actual channel that is behind it when queried. This is useful for transfer scenarios as the actual channel will be transferred, not the Local channel. If you have been using Local channels as queue members and having issues when the agent did a blind transfer this option may solve the issue.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114049 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-10 20:28:40 +00:00
Mark Michelson d13b45564b Merged revisions 114045 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114045 | mmichelson | 2008-04-10 14:55:33 -0500 (Thu, 10 Apr 2008) | 6 lines

Be sure that we're not about to set bridgepvt NULL prior to dereferencing it.

(closes issue #11775)
Reported by: fujin


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114046 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-10 19:58:36 +00:00
Tilghman Lesher 954fea4d10 The hydra grows yet another head...
(closes issue #12401)
 Reported by: davevg
 Patches: 
       astcli.diff2 uploaded by davevg (license 209)
 Tested by: davevg, Corydon76


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114042 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-10 19:04:29 +00:00
Jason Parker 51c92a4644 Merged revisions 114035 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114035 | qwell | 2008-04-10 12:26:10 -0500 (Thu, 10 Apr 2008) | 10 lines

Only try to prefix language if we are not using an absolute path (suffix it otherwise).

en/var/lib/asterisk/sounds/blah.gsm is a very silly path.

(closes issue #12379)
Reported by: kuj
Patches:
      12379-absolutepath.diff uploaded by qwell (license 4)
Tested by: kuj, qwell

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114036 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-10 17:27:16 +00:00
Joshua Colp 528617e77b Blocked revisions 114032 via svnmerge
........
r114032 | file | 2008-04-10 12:58:39 -0300 (Thu, 10 Apr 2008) | 6 lines

Forgot the 1.4 branch for russian language fix.
(closes issue #12404)
Reported by: IgorG
Patches:
      voicemail_ru_hardcoded-v1.patch uploaded by IgorG (license 20)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114033 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-10 15:59:13 +00:00
Joshua Colp 43de3860ea Merged revisions 114029 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114029 | file | 2008-04-10 12:09:04 -0300 (Thu, 10 Apr 2008) | 6 lines

Create the directory where name recordings will go if it does not exist.
(closes issue #12311)
Reported by: rkeene
Patches:
      12311-mkdir.diff uploaded by qwell (license 4)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114030 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-10 15:10:47 +00:00
Joshua Colp c9338b76ee Don't hardcode ru into the digits filename so that languageprefix can work.
(closes issue #12404)
Reported by: IgorG
Patches:
      voicemail_ru_hardcoded-v1.patch uploaded by IgorG (license 20)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114027 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-10 14:53:19 +00:00
Joshua Colp 4a21c5dd22 Fix spelling of existent in a few places.
(closes issue #12409)
Reported by: candlerb


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114024 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-10 13:45:45 +00:00
Joshua Colp a4e73acaf8 Merged revisions 114021 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114021 | file | 2008-04-10 10:27:11 -0300 (Thu, 10 Apr 2008) | 6 lines

Don't add custom URI options if they don't exist OR they are empty.
(closes issue #12407)
Reported by: homesick
Patches:
      uri_options-1.4.diff uploaded by homesick (license 91)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114022 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-10 13:28:30 +00:00
Mark Michelson 9bd9421c83 Fix a crash that happened due to accessing free'd memory
(closes issue #12396)
Reported by: tcalosi
Patches:
      12396.patch uploaded by putnopvut (license 60)
	  Tested by: tcalosi


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113980 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-09 22:32:32 +00:00
Mark Michelson 88cc98ea94 Merged revisions 113927 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r113927 | mmichelson | 2008-04-09 15:54:31 -0500 (Wed, 09 Apr 2008) | 8 lines

We need to set the persistant_route [sic] parameter for the sip_pvt
during the initial INVITE, no matter if we're building the route set from
an INVITE request or response.

(closes issue #12391)
Reported by: benjaminbohlmann
Tested by: benjaminbohlmann

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113928 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-09 20:56:14 +00:00
Tilghman Lesher ded5ec5b5d Merged revisions 113874 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r113874 | tilghman | 2008-04-09 13:57:33 -0500 (Wed, 09 Apr 2008) | 4 lines

If the [csv] section does not exist in cdr.conf, then an unload/load sequence
is needed to correct the problem.  Track whether the load succeeded with a
variable, so we can fix this with a simple reload event, instead.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113875 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-09 19:00:40 +00:00
Joshua Colp 0351ef6e6e Enable enough RTP bridging to allow P2P to work.
(closes issue #11901)
Reported by: pj


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113840 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-09 18:05:40 +00:00
Jason Parker e735c70ce1 Fix a small file handle "leak" pointed out by jjshoe on #asterisk.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113838 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-09 17:56:07 +00:00
Mark Michelson 28bd5d88c1 There was a subtle logical difference between 1.4 and trunk with regards to how timeouts
were handled. In 1.4, if the absolute timeout were reached on a call, no matter what
the return value of ast_spawn_extension was, the pbx would attempt to go to the 'T'
extension or hangup otherwise. The rearrangement of this function in trunk made this check
only happen in the case that ast_spawn_extension returned 0. If ast_spawn_extension returned
1, then the fact that the timeout expired resulted in a no-op, and would cause an infinite
loop to occur in __ast_pbx_run. This change fixes this problem. Now timeouts will
behave as they did in 1.4

(closes issue #11550)
Reported by: pj
Tested by: putnopvut



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113836 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-09 17:48:33 +00:00
Jason Parker d314fd5336 Move all messages wrapped in skinnydebug from debug to verbose.
(closes issue #12224)
Reported by: DEA
Patches:
      chan_skinny-debug-log.txt uploaded by DEA (license 3)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113834 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-09 17:41:09 +00:00
Joshua Colp 230d9d1465 Merged revisions 113784 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r113784 | file | 2008-04-09 13:50:45 -0300 (Wed, 09 Apr 2008) | 4 lines

If we receive an AUTHREQ from the remote server and we are unable to reply (for example they have a secret configured, but we do not) then queue a hangup frame on the Asterisk channel. This will cause the channel to hangup and a HANGUP to be sent via IAX2 to the remote side which is the proper thing to do in this scenario.
(closes issue #12385)
Reported by: viraptor

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113785 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-09 16:52:04 +00:00
Tilghman Lesher 7e91279cfc Mark recent additions from #11954 and #12254
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113752 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-09 16:23:30 +00:00