Commit graph

3706 commits

Author SHA1 Message Date
Russell Bryant
33aa72d592 Resolve compiler warnings on FreeBSD.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@253538 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-20 11:43:08 +00:00
Leif Madsen
4e53643fd4 Change usage of pipe to comma in UserEvent docs.
Change the example usage of pipe as a separator to comma in the UserEvent
documentation.

(closes issue #16961)
Reported by: jlpedrosa

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@253345 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-18 17:52:35 +00:00
Tilghman Lesher
ae5a398322 Mask out previous arguments on each nested invocation of Gosub.
(closes issue #16758)
 Reported by: wdoekes
 Patches: 
       20100316__issue16758.diff.txt uploaded by tilghman (license 14)
 
Review: https://reviewboard.asterisk.org/r/561/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@252976 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-16 23:49:35 +00:00
Sean Bright
fb7adfa6d1 Resolve a crash in SLATrunk when the specified trunk doesn't exist.
Reported by philipp64 in #asterisk-dev.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@252623 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-15 21:55:44 +00:00
Tilghman Lesher
148e5afcd1 Don't override a user option with the global option.
(closes issue #16849)
 Reported by: ip-rob
 Patches: 
       20100311__issue16849.diff.txt uploaded by tilghman (license 14)
 Tested by: ip-rob


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251989 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-12 19:43:23 +00:00
Tilghman Lesher
d38d930ed5 Because ExecIf needs to reprocess arguments, it's best if we don't remove quotes during parsing.
(closes issue #16905)
 Reported by: ip-rob
 Patches: 
       20100303__issue16905.diff.txt uploaded by tilghman (license 14)
 Tested by: ip-rob


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251884 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-11 21:07:07 +00:00
Tilghman Lesher
74be58a31f If the argument to the system application is quoted, ensure we remove the quotes before trying to execute.
(closes issue #16842)
 Reported by: ip-rob
 Patches: 
       20100310__issue16842.diff.txt uploaded by tilghman (license 14)
 Tested by: ip-rob


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251877 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-11 20:25:02 +00:00
Alec L Davis
ba80d2172f Add supporting code for app-directory pause option.
Since 1.6.1 CLI help reports that option p(n) 'initial pause' is available.
Supporting code was never implemented.

(closes issue #16751)
Reported by: alecdavis
Patches: 
      directory_pause.trunk.diff.txt uploaded by alecdavis (license 585)
Tested by: alecdavis

Review: https://reviewboard.asterisk.org/r/481/



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251779 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-11 07:03:51 +00:00
Leif Madsen
08fa8a6e5f Be less ambiguous in Record() app docs.
For some reason the documentation for the 'k' application in trunk
and 1.6.2 is different than 1.6.0 and 1.6.1, so I'm setting them all
to match. The wording in 1.6.2 and trunk was ambiguous, so you could
interpret the wording the mean that recording would continue upon hangup
indefinitely, or you could interpret it to mean that the recorded
data would not be discarded upon hangup. This change makes it clear
we mean the latter, and not the former.

Came from a discussion in #asterisk on IRC.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251680 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-10 20:53:43 +00:00
Jeff Peeler
976400a61e Fix app_followme playing wrong sound files.
Fixes regression introduced in 140167 that uses the wrong variable names.

(closes issue #16930)
Reported by: ianc
Patches: 
      fix_reload_followme.diff uploaded by ianc (license 998)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250979 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-05 19:10:47 +00:00
Tilghman Lesher
6d166a9af9 Missing quote in ODBC query.
(closes issue #16953)
 Reported by: elguero
 Patches: 
       app_voicemail-odbc-syntax-fix.diff uploaded by elguero (license 37)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250913 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-05 04:37:36 +00:00
Richard Mudgett
73ef4b8daf Removed cdrflags from ast_channel structure.
Only chan_dahdi set a value in cdrflags.  Everyone else just copied it
around the system.  Noone cared about any value it may have contained.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250565 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-03 19:38:06 +00:00
Matthew Nicholson
8ef8706944 Updated CHANGES file to mention res_fax and res_fax_spandsp.
Also fixed MODULEINFO depends and conflicts for app_fax, res_fax, and res_fax_spandsp.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250302 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-03 15:39:45 +00:00
David Vossel
b5c98d640a adds 'p' option to PickupChan
The 'p' option allows the PickupChan app to pickup
a ringing phone by looking for the first match to a
partial channel name rather than requiring a full match.

(closes issue #16613)
Reported by: syspert
Patches:
      pickipbycallid.patch uploaded by syspert (license 938)
      pickupbycallerid_v2.patch uploaded by dvossel (license 671)
Tested by: dvossel, syspert




git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250141 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-02 21:58:03 +00:00
Leif Madsen
ecfa2dcb2e Fix literal values wrapped in documentation.
(closes issue #16145)
Reported by: tilghman

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249950 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-02 19:49:48 +00:00
Alec L Davis
2866c664b8 revert ability to exit echo app
caused a regression, as only supported VOICE, not VIDEO etc.

(issue #16880)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249947 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-02 19:39:58 +00:00
Leif Madsen
06041ea28d Fix several XML documentation validate errors.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249892 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-02 19:02:56 +00:00
Jeff Peeler
717599a61f fix build by checking result of symlink in test_voicemail_vmsayname
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249891 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-02 18:31:05 +00:00
Jeff Peeler
bb3792a8a7 Add new application VMSayName for use with voicemail.
VMSayName that will play the recorded name of the voicemail user if it exists, 
otherwise will play the mailbox number. A unit test has been written to verify
correct functionality called test_voicemail_vmsayname.

(closes issue #14973)
Reported by: ghjm

Review: https://reviewboard.asterisk.org/r/530/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249889 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-02 18:22:05 +00:00
Alec L Davis
9257e8573b fixes ability to exit echo app
when called from a ISDN channel, null frames prevent '#' exit.
Now only echo back VOICE and DTMF frames

(issue #16880)
Reported by: alecdavis
Patches: 
      echo_exit.diff.txt uploaded by alecdavis (license 585)
Tested by: alecdavis



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249801 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-02 07:38:56 +00:00
Sean Bright
b4b7d16f6f Merged revisions 249671 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r249671 | seanbright | 2010-03-01 14:35:01 -0500 (Mon, 01 Mar 2010) | 11 lines
  
  Fix crash in app_voicemail related to message counting.
  
  We were passing a 'struct inprocess **' and treating it like a 'struct inprocess *'
  causing a segfault.
  
  (closes issue #16921)
  Reported by: whardier
  Patches:
        20100301_issue16921.patch uploaded by seanbright (license 71)
  Tested by: whardier
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249672 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-01 19:36:30 +00:00
Tilghman Lesher
dac8ccd89e Constify a bit of app_voicemail, to make ODBC and IMAP compile once again.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249623 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-01 18:36:06 +00:00
Tilghman Lesher
3b94cadaf9 Fix unit test that Alec Davis broke.
(closes issue #16927)
 Reported by: alecdavis


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249491 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-28 20:50:01 +00:00
Alec L Davis
40ee6ed4f0 make unit test check for NULL folder, which then defaults to INBOX
previous test, gave false level of assurance that code was healthy.

(issue #16927)
Reported by: alecdavis
Patches: 
      based on app_voicemail_test.diff.txt uploaded by alecdavis (license 585)

Tested by: alecdavis


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249449 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-28 16:36:45 +00:00
Tilghman Lesher
a6fd85250d Properly document voicemail API documents. Also fix a crash reported via the -dev list.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249405 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-28 07:10:22 +00:00
Tilghman Lesher
e20c28078e Cleanups to fix bugs in the VM count API functions.
- Urgent voicemails were not attached, because the attachment code looked in the wrong folder.
- Urgent voicemails were sometimes counted twice when displaying the count of new messages.
- Backends were inconsistent as to which voicemails each API counted.
- Unit tests added to verify behavior in the future.

(closes issue #15654)
 Reported by: tomo1657
 Patches: 
       20100225__issue15654.diff.txt uploaded by tilghman (license 14)
 Tested by: tilghman

(closes issue #16448)
 Reported by: hevad

Review: https://reviewboard.asterisk.org/r/525/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249187 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-26 18:41:57 +00:00
David Vossel
48134df655 fixes Queue with C option crash
(closes issue #16475)
Reported by: okrief
Patches:
      queue_crash.diff uploaded by dvossel (license 671)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@247736 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-18 20:58:41 +00:00
Mark Michelson
c54f8ced1b Merged revisions 247168 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r247168 | mmichelson | 2010-02-17 10:24:17 -0600 (Wed, 17 Feb 2010) | 3 lines
  
  Make sure that when autofill is disabled that callers not in the front of the queue cannot place calls.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@247169 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-17 16:24:54 +00:00
Tilghman Lesher
22b144cef4 Change the blanket rules to delete .lastclean on all CFLAGS menuselect targets to be more particular.
This change builds upon the recent change to menuselect to add 'touch_on_change'
as an attribute of both categories and members.  This should allow only the most
invasive defines to cause a complete rebuild, while defines which only affect a
subset of modules will only cause a rebuild of that smaller set.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@246789 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-16 00:52:45 +00:00
TransNexus OSP Development
034a79c303 Updated doc for OSP lookup application.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@246382 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-12 08:30:05 +00:00
David Vossel
fa156c067d Merged revisions 246115 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r246115 | dvossel | 2010-02-10 11:44:20 -0600 (Wed, 10 Feb 2010) | 8 lines
  
  fixes random deadlock in app_queue with use_weight during reload
  
  (closes issue #16677)
  Reported by: tim_ringenbach
  Patches:
        app_queue_use_weight_deadlock.diff uploaded by tim ringenbach (license 540)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@246116 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-10 17:49:34 +00:00
Tilghman Lesher
2d6f0c4607 Ensure frames are only freed once.
(closes issue #16361)
 Reported by: vlad
 Patches: 
       20100208__issue16361.diff.txt uploaded by tilghman (license 14)
 Tested by: kenny, bloodoff, misaksen


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@245729 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-09 18:06:30 +00:00
Kevin P. Fleming
3760672f40 Don't offer MMR or JBIG transcoding during T.38 negotiation.
After further discussion with Steve Underwood, we should not (yet) be offering
to receive MMR or JBIG transcoded streams from T.38 endpoints. A future spandsp
release will support those features, and then they can be enabled during
negotiation



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@245680 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-09 16:24:52 +00:00
Tilghman Lesher
dd1c5f27ee Properly respect GOSUB_RESULT as to what to do with the master channel.
Previously, we would parse GOSUB_RESULT, but not actually do anything with it.
Also, allow GOSUB_RETVAL to be inherited back across a peer/master channel.

(closes issue #16687)
 Reported by: bklang
 Patches: 
       app_dial-preserve-gosub_retval.patch uploaded by bklang (license 919)
       (with modifications)

(closes issue #16686)
 Reported by: bklang
 Patches: 
       app_dial-respect-gosub_result.patch uploaded by bklang (license 919)
       (with modifications)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@244393 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-02 20:32:29 +00:00
Tilghman Lesher
81762bf4c7 Merged revisions 244242 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r244242 | tilghman | 2010-02-01 17:13:44 -0600 (Mon, 01 Feb 2010) | 11 lines
  
  Backup and restore original textfile, for prosthesis (gerund of prepend).
  
  Also, fix menuselect such that changing voicemail build options correctly
  causes rebuild.
  
  (closes issue #16415)
   Reported by: tomo1657
   Patches: 
         prepention.patch uploaded by tomo1657 (license 484)
         (with modifications by me to backport to 1.4)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@244243 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-01 23:16:12 +00:00
Jeff Peeler
0f7c1a8cc9 Merged revisions 243691 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r243691 | jpeeler | 2010-01-27 14:35:56 -0600 (Wed, 27 Jan 2010) | 5 lines
  
  Revert 243570, I should have looked at this closer. Will reopen the issue, but
  am leaving the review closed as the change was pointless.
  
  (issue #16488)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@243693 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-27 20:37:33 +00:00
Jeff Peeler
7e20456f3a Merged revisions 243570 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r243570 | jpeeler | 2010-01-27 12:47:34 -0600 (Wed, 27 Jan 2010) | 9 lines
  
  Extend announcement URL used with Queue from 80 chars to PATH_MAX.
  
  (closes issue #16488)
  Reported by: syspert
  Patches: 
        soundfilelen.pacth-2 uploaded by syspert (license 938)
  
  Review: https://reviewboard.asterisk.org/r/475/
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@243571 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-27 18:49:52 +00:00
David Ruggles
0375f18c9f Code clean up in app_senddtmf
Pushes code clean up done in app_externalivr back
into app_senddtmf

Review: https://reviewboard.asterisk.org/r/473/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@243346 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-26 20:49:57 +00:00
David Ruggles
4c49e70ec5 Add send DTMF feature to ExternalIVR app
Implemented a new command 'D' that allows client
IVRs to send DTMF digits to the channel.

(closes issue #16615)
Reported by: thedavidfactor

Review: https://reviewboard.asterisk.org/r/465/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@242357 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-22 16:20:43 +00:00
Tilghman Lesher
873989db91 Enable SendText to send strings in encoded format.
See http://lists.digium.com/pipermail/asterisk-users/2010-January/243462.html


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241364 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-19 22:41:36 +00:00
David Ruggles
174cd3c65c Add notification of interrupted file
Add file information to data element of T event so
the file information is sent to the client when it is
interrupted. Previously only notification of pending
files that were dropped was sent

(closes issue #16147)
Reported by: thedavidfactor
Tested by: thedavidfactor

Review: https://reviewboard.asterisk.org/r/449/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240969 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-18 17:41:44 +00:00
David Vossel
8d8800072e fixes spelling error. s/memeber/member
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240842 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-18 15:52:55 +00:00
Tilghman Lesher
e8a6d2995e Add pickup event to AMI. Also, fix AMI documentation.
(closes issue #16431)
 Reported by: syspert
 Patches: 
       20100112__issue16431.diff.txt uploaded by tilghman (license 14)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240421 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-15 21:04:34 +00:00
Tilghman Lesher
f94e723a27 Make sure that the limit is N, not N - 1.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240419 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-15 20:58:19 +00:00
Tilghman Lesher
6bc1fc7240 Merged revisions 240414 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r240414 | tilghman | 2010-01-15 14:52:27 -0600 (Fri, 15 Jan 2010) | 15 lines
  
  Disallow leaving more than maxmsg voicemails.
  This is a possibility because our previous method assumed that no messages are
  left in parallel, which is not a safe assumption.  Due to the vmu structure
  duplication, it was necessary to track in-process messages via a separate
  structure.  If at some point, we switch vmu to an ao2-reference-counted
  structure, which would eliminate the prior noted duplication of structures,
  then we could incorporate this new in-process structure directly into vmu.
  (closes issue #16271)
   Reported by: sohosys
   Patches: 
         20100108__issue16271.diff.txt uploaded by tilghman (license 14)
         20100108__issue16271__trunk.diff.txt uploaded by tilghman (license 14)
         20100108__issue16271__1.6.0.diff.txt uploaded by tilghman (license 14)
   Tested by: jsutton
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240415 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-15 20:54:24 +00:00
Sean Bright
e612d87695 Convert a few places to use ast_calloc_with_stringfields where applicable.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240368 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-15 18:21:50 +00:00
David Vossel
03529837cc add silence gen to wait apps
asterisk.conf's 'transmit_silence' option existed before
this patch, but was limited to only generating silence
while recording and sending DTMF.  Now enabling the
transmit_silence option generates silence during wait
times as well.

To achieve this, ast_safe_sleep has been modified to
generate silence anytime no other generators are present
and transmit_silence is enabled.  Wait apps not using
ast_safe_sleep now generate silence when transmit_silence
is enabled as well.

(closes issue #16524)
Reported by: kobaz

(closes issue #16523)
Reported by: kobaz
Tested by: dvossel

Review: https://reviewboard.asterisk.org/r/456/



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239712 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-13 16:31:14 +00:00
TransNexus OSP Development
912d4da476 Updated XML doc for OSP.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239624 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-13 07:00:13 +00:00
David Vossel
0a6c0ee1f7 cli 'queue show' formatting fix. queue name was truncated over 12 characters
(closes issue #16078)
Reported by: RoadKill
Patches:
      quequename_limit.patch uploaded by ppyy (license 906)
Tested by: dvossel


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@238361 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-07 18:58:23 +00:00
Jeff Peeler
c6e038ba16 Fix misreverting from 177158.
(closes issue #15725)
Reported by: shanermn
Patches: 
      v1-15725.patch uploaded by dimas (license 88)
Tested by: shanermn


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@238181 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-06 20:37:18 +00:00