Commit Graph

234 Commits

Author SHA1 Message Date
David Vossel c26c190711 Asterisk media architecture conversion - no more format bitfields
This patch is the foundation of an entire new way of looking at media in Asterisk.
The code present in this patch is everything required to complete phase1 of my
Media Architecture proposal.  For more information about this project visit the link below.
https://wiki.asterisk.org/wiki/display/AST/Media+Architecture+Proposal

The primary function of this patch is to convert all the usages of format
bitfields in Asterisk to use the new format and format_cap APIs.  Functionally
no change in behavior should be present in this patch.  Thanks to twilson
and russell for all the time they spent reviewing these changes.

Review: https://reviewboard.asterisk.org/r/1083/



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@306010 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-02-03 16:22:10 +00:00
Russell Bryant 63d10a1b1c Comment out a rule that likes to run implicitly unnecessarily, breaking builds
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@267445 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-03 14:48:09 +00:00
Russell Bryant bb4c55c347 try to fix some random chan_h323 compilation failures
After some debugging, the random chan_h323 build failures appear to be due
to complications introduced by some chan_h323 specific build stuff getting
triggered during a clean.  Simplify this by moving the h323 clean commands
down into channels/makefile.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@267352 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-02 22:46:37 +00:00
Mark Michelson c5be9d2247 Print openh323 log to the Asterisk console.
(closes issue #17109)
Reported by: under
Patches:
      logstream.diff uploaded by under (license 914)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@265451 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-24 22:05:15 +00:00
Tilghman Lesher d8e0c58437 Expand codec bitfield from 32 bits to 64 bits.
Reviewboard: https://reviewboard.asterisk.org/r/416/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@227580 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-04 14:05:12 +00:00
David Vossel dcfe69ec64 fixes some memory leaks and redundant conditions
(closes issue #15269)
Reported by: contactmayankjain
Patches:
      patch.txt uploaded by contactmayankjain (license 740)
      memory_leak_stuff.trunk.diff uploaded by dvossel (license 671)
Tested by: contactmayankjain, dvossel




git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201678 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-06-18 16:37:42 +00:00
Sean Bright f51bb019bb Update references to bugs.digium.com and reviewboard.digium.com to the new URLs.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@197824 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-05-28 21:50:27 +00:00
Tilghman Lesher b6d2a4a7a8 Make H.323 compile with FDLEAK detection code enabled
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@191219 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-04-29 23:06:56 +00:00
Jeff Peeler 2f8da7106d Make chan_h323 respect packetization settings and fix small reload issue.
Previously, packetization settings were ignored and now they are not. A new
config option 'autoframing' has been added to mirror the way chan_sip handles
it. Turning on the autoframing option (available both as a global option or per
peer) overrides the local settings with the remote packetization settings.
Testing was performed with varying packetization levels with the following
codecs: ulaw, alaw, gsm, and g729.

Also, an unrelated config reload issue has been fixed in the case of the config
file not changing.

(closes issue #12415)
Reported by: pj
Patches:
      2009012200_h323packetization.diff.txt uploaded by mvanbaak (license 7), 
      modified by me


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@189993 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-04-22 19:23:49 +00:00
Russell Bryant 3ec3742a97 Fix build error when chan_h323 is not being built.
(reported by cai1982 in #asterisk-dev)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@184910 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-03-30 13:55:44 +00:00
Jeff Peeler d22073161f Add some code removed by mistake from commit 182722 that works around a file
descriptor leak in versions of PWLib prior to 1.12.0.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@183028 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-03-18 21:18:27 +00:00
Jeff Peeler 9dc40485f2 Allow H.323 Plus library to be used in addition to the OpenH323 library
Chan_h323 can now be compiled against both the previously supported versions of
OpenH323 as well as the current H.323 Plus (version 1.20.2). The configure
script has been modified to look in the default install location of h323 to
hopefully help avoid using the environment variables OPENH323DIR and PWLIBDIR.
Also, the CLI command "h323 show version" has been added which indicates which
version of h323 is in use.

(closes issue #11261)
Reported by: vhatz
Patches:
      asterisk-1.6.0.6-h323plus.patch uploaded by jthurman (license 614)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@182722 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-03-17 20:47:31 +00:00
Jeff Peeler 58cf8b69da Fix malloc debug macros to work properly with h323.
The main problem here was that cstdlib was undefining free thereby causing the
proper debug macros to not be used. ast_h323.cxx has been changed to call
ast_free instead to avoid the issue. 

A few other issues were addressed:
- There were a few instances of functions improperly passing ast_free instead
of ast_free_ptr.
- Some clean up was done to avoid the debug macros intentionally being redefined.
(copied below from Kevin's commit, appreciate the help)
- disable astmm.h from doing anything when STANDALONE is defined, which is used
by the tools in the utils/ directory that use parts of Asterisk header files in
hackish ways; also ensure that utils/extconf.c and utils/conf2ael.c are
compiled with STANDALONE defined.

(closes issue #13593)
Reported by: pj



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@181135 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-03-11 04:06:44 +00:00
Jeff Peeler c8fe75da36 Modify h323 to build against PTLib as well as the older PWLib
Several changes in PTLib have occurred requiring build time detection. Changes
accounted for include the library name change, config option change, install
location change, and a boolean type change which is handled by ast_ptlib.h.
Also, the sed check has been modified to properly work with autoconf >= 2.62.

(closes issue #14224)
Reported by: bergolth
Patches:
      asterisk-autoconf-sed.patch uploaded by bergolth (license 661)
      asterisk-pwlib-v3.patch uploaded by bergolth (license 661)
Tested by: jpeeler


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@177162 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-02-18 20:11:57 +00:00
Sean Bright e1f941d7f6 Mostly just whitespace, but also convert 'CVS' to 'SVN' in a couple
places and fix a few typos I found in the CODING_GUIDELINES.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@167061 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-12-31 23:07:14 +00:00
Russell Bryant 808a5fda59 Fix a couple more build issues related to ast_str_opaque
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@164309 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-12-15 17:21:38 +00:00
Tilghman Lesher 28534ea921 Swap "static" and "const", so that "static" appears at the beginning of each
declaration (suppresses a warning).
(closes issue #13070)
 Reported by: gknispel_proformatique
 Patches: 
       asterisk_trunk_const_static.patch uploaded by gknispel (license 261)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@130697 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-14 15:44:07 +00:00
Brett Bryant d185405755 Janitor project to convert sizeof to ARRAY_LEN macro.
(closes issue #13002)
Reported by: caio1982
Patches:
      janitor_arraylen5.diff uploaded by caio1982 (license 22)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@129045 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-08 16:40:28 +00:00
Joshua Colp 0894cae92c Merged revisions 117081 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r117081 | file | 2008-05-19 12:22:10 -0300 (Mon, 19 May 2008) | 6 lines

Make chan_h323 work with pwlib 1.12.0
(closes issue #12682)
Reported by: bamby
Patches:
      pwlib_nopipe.diff uploaded by bamby (license 430)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117082 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-19 15:24:44 +00:00
Joshua Colp 369af0f291 Merged revisions 103823 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r103823 | file | 2008-02-19 16:28:08 -0400 (Tue, 19 Feb 2008) | 6 lines

Send CallerID Name in setup message.
(closes issue #11241)
Reported by: tusar
Patches:
      h323id_as_callerid_name.patch uploaded by tusar (license 344)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@103824 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-19 20:31:15 +00:00
Joshua Colp 564e0815b6 Include the compatibility header file in ast_h323.cxx for compatibility reasons.
(closes issue #11311)
Reported by: falves11


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89447 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-20 14:49:32 +00:00
Joshua Colp fc0853c7bc Minor change so chan_h323 builds again.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89086 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-07 17:45:31 +00:00
Russell Bryant ee7a6c0851 Merged revisions 81383 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r81383 | russell | 2007-08-30 10:38:29 -0500 (Thu, 30 Aug 2007) | 3 lines

Add missing checks for the PTRACING define.
(closes issue #10559, paravoid)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81384 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-08-30 15:40:18 +00:00
Paul Cadach 3e5e0f5f00 Merged revisions 53131 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r53131 | pcadach | 2007-02-03 02:02:55 -0800 (Сбт, 03 Фев 2007) | 1 line

Remove quote from H.323 vendor string because due to compatibilities with
Nortel Meridian CS1000 reported at www.voip-info.org
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@53132 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-03 10:12:20 +00:00
Paul Cadach 1ed8fb571f Merged revisions 44684 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r44684 | pcadach | 2006-10-07 20:39:34 +0600 (Сбт, 07 Окт 2006) | 1 line

Propagate caller's transfer capability too
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44686 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-07 14:48:32 +00:00
Paul Cadach eb7f97f2d6 Merged revisions 44283,44286 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r44283 | pcadach | 2006-10-04 00:30:48 +0600 (Срд, 04 Окт 2006) | 1 line

Fix preparation of type and presentation of calling number
........
r44286 | pcadach | 2006-10-04 00:42:20 +0600 (Срд, 04 Окт 2006) | 1 line

Change default presentation indicator to "user provided not screened" if octet 3a missed in CallingPartyNumber IE
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44287 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-03 18:47:38 +00:00
Paul Cadach 6c273d37cc Merged revisions 44034,44042-44043 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r44034 | pcadach | 2006-09-30 02:43:13 +0600 (Сбт, 30 Сен 2006) | 1 line

Fake display name by called number on incoming calls (until passing connected number/connected name is not implemented)
........
r44042 | pcadach | 2006-09-30 03:05:43 +0600 (Сбт, 30 Сен 2006) | 1 line

Set TON/PRESENTATION information more carefully when no CallingNumber IE available
........
r44043 | pcadach | 2006-09-30 03:09:10 +0600 (Сбт, 30 Сен 2006) | 1 line

Compile first, please
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44044 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-29 21:13:46 +00:00
Paul Cadach 925708f307 Merged revisions 44022 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r44022 | pcadach | 2006-09-30 01:06:55 +0600 (Сбт, 30 Сен 2006) | 3 lines

Properly pass TON/PRESENTATION information - original
H323Connection::SendSignalSetup() destroys Q.931 fields.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44024 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-29 19:13:26 +00:00
Paul Cadach ee4141c375 Merged revisions 44009 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r44009 | pcadach | 2006-09-30 00:30:34 +0600 (Сбт, 30 Сен 2006) | 1 line

Pass TON/PRESENTATION information too
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44010 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-29 18:35:44 +00:00
Paul Cadach 134a9ac96d Merged revisions 43918 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r43918 | pcadach | 2006-09-28 23:34:19 +0600 (Чтв, 28 Сен 2006) | 1 line

Extend call establishment timeout
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43920 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-28 17:36:33 +00:00
Paul Cadach 5bfa99306f Merged revisions 43877 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r43877 | pcadach | 2006-09-28 21:56:21 +0600 (Чтв, 28 Сен 2006) | 1 line

Fix compiler warning
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43888 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-28 16:01:48 +00:00
Paul Cadach 2719c20e4e Merged revisions 43861-43862 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r43861 | pcadach | 2006-09-28 18:47:23 +0600 (Чтв, 28 Сен 2006) | 1 line

Put attribute tag at correct place
........
r43862 | pcadach | 2006-09-28 18:58:22 +0600 (Чтв, 28 Сен 2006) | 1 line

Force remote side to start media on outgoing PROGRESS message
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43863 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-28 13:02:30 +00:00
Paul Cadach 47a0e0807c Merged revisions 43635,43843-43844,43846 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r43635 | pcadach | 2006-09-26 03:26:12 +0600 (Втр, 26 Сен 2006) | 1 line

Fix ASN1 description of non-standard Cisco extensions
........
r43843 | pcadach | 2006-09-28 12:01:37 +0600 (Чтв, 28 Сен 2006) | 1 line

Don't treat unknown control frames as voice
........
r43844 | pcadach | 2006-09-28 12:02:45 +0600 (Чтв, 28 Сен 2006) | 1 line

Don't warn on HOLD/UNHOLD control frames
........
r43846 | pcadach | 2006-09-28 16:51:21 +0600 (Чтв, 28 Сен 2006) | 1 line

Do not open transmit channel until TCS is received
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43853 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-28 11:12:58 +00:00
Paul Cadach 9cf1f14ed5 Handle HOLD/RETRIEVE notifications
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43845 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-28 10:41:38 +00:00
Paul Cadach c479c25182 Support for negotiation and receiption of Cisco's RTP DTMF
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43597 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-25 09:03:14 +00:00
Paul Cadach 66e1d206f5 Disable fastStart if requested by remote side
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43590 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-25 07:50:25 +00:00
Paul Cadach d62390a65c DTMF mode is bitmask, not valued field
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43574 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-24 18:53:44 +00:00
Paul Cadach aec46b99f5 Define Cisco RTP capability
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43573 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-24 18:19:56 +00:00
Paul Cadach ecdfdb6ecb Specify non-standard data independedly on OpenH323's codec name (it can be easily changed)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43572 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-24 18:16:44 +00:00
Paul Cadach 258f1082ec Define DTMF payload types
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43571 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-24 18:12:35 +00:00
Paul Cadach 747f091a77 Use own factory for our OpalMediaFormats too
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43496 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-22 19:56:07 +00:00
Paul Cadach 50ed891da2 Fix our capability's factory
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43495 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-22 19:54:20 +00:00
Paul Cadach ccdbf69318 Add missing include
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43472 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-22 04:54:41 +00:00
Paul Cadach d2b0446c90 Declare our own media formats to not rely on OpenH323 configuration
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43432 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-21 19:07:13 +00:00
Paul Cadach 5acd11f180 Introduce Cisco G.726-32 capability (g726aal2 form)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43429 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-21 18:48:53 +00:00
Paul Cadach e57d521462 Split capability definitions into own source file
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43354 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-20 19:21:15 +00:00
Paul Cadach aa92ebffea Remove unnecessary (long time ago commented out) code
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43350 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-20 18:08:42 +00:00
Paul Cadach a704e298e7 Fix missed extension replacement
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43347 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-20 17:48:52 +00:00
Paul Cadach 84946195e9 Change file naming to be conform OpenH323 rules
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43345 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-20 17:45:25 +00:00
Joshua Colp 1ce4a427d3 Merge in latest round of chan_h323 changes. These are all isolated to chan_h323 so meh.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43331 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-20 16:24:00 +00:00