Mark Michelson
7415c3ee1e
Found a grievous logical error in get_vm_state_by_imapuser.
...
The imapuser being passed in was never getting compared to imapusers of any of the vm_states
in the vmstates list.
I also found some places in the code where I used my typical brace style and changed it to match
the typical Asterisk brace style.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@72670 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-29 20:02:00 +00:00
Luigi Rizzo
ad42dfe1dd
move variable declarations to the beginning of a block.
...
Not applicable to previous branches.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@72457 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-28 19:02:31 +00:00
Luigi Rizzo
a0011053d6
move variable declarations to the beginning of a block.
...
Not applicable to previous branches
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@72455 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-28 18:59:19 +00:00
Joshua Colp
150c77c901
Merged revisions 72381 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
................
r72381 | file | 2007-06-27 19:25:12 -0400 (Wed, 27 Jun 2007) | 10 lines
Merged revisions 72378 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r72378 | file | 2007-06-27 19:24:01 -0400 (Wed, 27 Jun 2007) | 2 lines
Update documentation to clarify variable usage with MixMonitor. (issue #9494 reported by netoguy)
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@72382 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-27 23:26:46 +00:00
Joshua Colp
7b60d29f68
Merged revisions 72328 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
................
r72328 | file | 2007-06-27 18:45:49 -0400 (Wed, 27 Jun 2007) | 10 lines
Merged revisions 72327 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r72327 | file | 2007-06-27 18:43:11 -0400 (Wed, 27 Jun 2007) | 2 lines
Fix issue where queue log events might be missing. (issue #7765 reported by mtryfoss)
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@72330 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-27 22:48:15 +00:00
Mark Michelson
5310385315
Added ability to customize which buttons control forward, reverse, pause, and stop during message playback.
...
(closes issue 9474, reported and patched by jaroth with modifications by me)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@72329 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-27 22:47:08 +00:00
Mark Michelson
4596af13fc
Adding feature to support the storage and retrieval of voicemail greetings using IMAP storage.
...
This feature may be turned on by adding imapgreetings=yes to the general section of voicemail.conf
voicemail.conf.sample has details on the options added.
As a result, IMAP storage now has RETRIEVE and DISPOSE macros defined.
In addition to the IMAP greeting changes, I also have added an enum for the voicemail folders
and so now the code should be easier to understand and maintain when it comes to this area.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@72232 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-27 19:50:21 +00:00
Jason Parker
37ebf4da54
Merged revisions 72182 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r72182 | qwell | 2007-06-27 13:36:56 -0500 (Wed, 27 Jun 2007) | 4 lines
Fix another problem in voicemail with missing symbols.
Issue 10074, patch by kryptolus, extended to include #if 0'd blocks (just in case)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@72183 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-27 18:37:44 +00:00
Mark Michelson
a333f7a474
Merged revisions 71953 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r71953 | mmichelson | 2007-06-26 18:02:09 -0500 (Tue, 26 Jun 2007) | 4 lines
Removing a pointless line. This variable was already set earlier and between then and this
line, there is no way that the values on the right side of the assignment could have changed.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@71954 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-26 23:03:09 +00:00
Mark Michelson
27654c6a76
The variable msgnum was being overwritten if IMAP storage was enabled.
...
Put necessary #ifndef's around the line which would overwrite.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@71952 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-26 22:45:16 +00:00
Mark Michelson
49c22c3c04
Create directory if it does not exist.
...
(Closes issue 10061, Reported and patched by eliel)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@71914 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-26 20:34:46 +00:00
Mark Michelson
e7ca771f95
Merged revisions 71877 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r71877 | mmichelson | 2007-06-26 14:00:05 -0500 (Tue, 26 Jun 2007) | 11 lines
A few changes, the ultimate goal of which is to keep better track of the number of messages
that a mailbox currently has. A description of the changes:
1. Changed the "updated" field of the vm_state struct to act more as a binary semaphore than a
counting semaphore, since its current implementation made the inboxcount function not work properly.
This change falls in line with a change made by UPenn with their IMAP setup and helps to sync our changes with theirs.
2. Eliminated some redundant calls to get_vm_state_by_mailbox inside leave_voicemail
3. Use the play_folder variable to keep track of the number of old and new messages in a mailbox as the messages are deleted
4. Added an increment to the number of new messages that was not there previously in the leave_voicemail function
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@71883 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-26 19:06:47 +00:00
Mark Michelson
6dc12782c7
Merged revisions 71796 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r71796 | mmichelson | 2007-06-26 10:47:31 -0500 (Tue, 26 Jun 2007) | 5 lines
Fixing bug where the authuser was mistakenly pulled from the mailbox string instead
of the IMAP user.
(closes issue 10054, reported and patched by jaroth)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@71797 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-26 15:50:11 +00:00
Tilghman Lesher
17892ed419
Merged revisions 71751 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
................
r71751 | tilghman | 2007-06-26 07:27:47 -0500 (Tue, 26 Jun 2007) | 10 lines
Merged revisions 71750 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r71750 | tilghman | 2007-06-26 07:25:58 -0500 (Tue, 26 Jun 2007) | 2 lines
Issue 10062 - Trying to move a message without selecting one first results in memory corruption
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@71752 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-26 12:30:59 +00:00
Mark Michelson
de47fc6c47
In my commit earlier today, I accidentally left a prototype that isn't defined.
...
This gets rid of that prototype.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@71721 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-25 23:18:19 +00:00
Russell Bryant
ab56fcce5c
Allow compilation off app_voicemail with IMAP_STORAE against a system installed
...
version of the c-client library. (issue #10047 , jcollie)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@71688 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-25 19:20:07 +00:00
Mark Michelson
3f3a8af232
Using inboxcount instead of countmessages.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@71630 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-25 16:13:26 +00:00
Russell Bryant
80166c6de8
Conversions to ast_debug()
...
(issue #9984 , patches from eliel and dimas)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@71338 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-24 18:51:41 +00:00
Tilghman Lesher
0296bd9957
Issue 9970 - Ensure directory exists before trying to write an output file
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@71268 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-24 16:20:18 +00:00
Tilghman Lesher
e2f71e8937
Code cleanups
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@71190 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-22 19:53:57 +00:00
Jason Parker
68ac7f7633
Merged revisions 71068 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
................
r71068 | qwell | 2007-06-22 10:00:30 -0500 (Fri, 22 Jun 2007) | 12 lines
Merged revisions 71065 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r71065 | qwell | 2007-06-22 09:52:18 -0500 (Fri, 22 Jun 2007) | 4 lines
Fix a few silly usages of ast_playstream() - it only ever returns 0...
Issue 10035
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@71069 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-22 15:03:32 +00:00
Tilghman Lesher
a1bc823136
Issue 9990 - New API ast_mkdir, which creates parent directories as necessary (and is faster than an outcall to mkdir -p)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@71040 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-22 04:35:12 +00:00
Joshua Colp
9a3ddbac93
Merged revisions 70899 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
................
r70899 | file | 2007-06-21 17:40:19 -0400 (Thu, 21 Jun 2007) | 10 lines
Merged revisions 70898 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r70898 | file | 2007-06-21 17:37:55 -0400 (Thu, 21 Jun 2007) | 2 lines
Don't explode if the gain option is specified without a value. (issue #9274 reported by mfarver)
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@70900 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-21 21:41:45 +00:00
Mark Michelson
5bad80449e
Merged revisions 70808 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r70808 | mmichelson | 2007-06-21 14:49:44 -0500 (Thu, 21 Jun 2007) | 4 lines
When volgain is used don't leave a temporary file behind.
(Closes Issue 8514, Reported and patched by ulogic, code reviewed by Jason Parker)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@70809 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-21 19:54:40 +00:00
Russell Bryant
cc41da6de9
Merge changes from team/russell/sla_reload
...
* Add support for the reload of sla.conf
(closes issue #9481 , patch by me)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@70783 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-21 18:40:20 +00:00
Russell Bryant
ffa9367f7b
Merged revisions 70726 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r70726 | russell | 2007-06-21 10:21:16 -0500 (Thu, 21 Jun 2007) | 2 lines
Remove a couple of duplicate unlocks
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@70728 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-21 15:23:36 +00:00
Joshua Colp
142c6f45d8
Merged revisions 70677 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r70677 | file | 2007-06-21 09:58:36 -0400 (Thu, 21 Jun 2007) | 2 lines
Fix building with ODBC storage enabled. (issue #10025 reported by denisgalvao)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@70678 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-21 14:00:47 +00:00
Mark Michelson
21422fd78c
Removed an extraneous debug message I'd left in my previous commit
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@70611 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-20 23:31:42 +00:00
Tilghman Lesher
396a37eba8
Fix trunk brokenness; also, optimize application registration
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@70610 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-20 23:31:08 +00:00
Steve Murphy
2462d5ab4f
Cleaning up a small disaster I created earlier
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@70607 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-20 23:26:07 +00:00
Steve Murphy
57526b35cc
As per 9228, now app_queue should have the proper machinery to do gosubs.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@70531 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-20 21:38:49 +00:00
Mark Michelson
3803718a8f
Main fix: Fixing a bug which caused VoiceMailMain to always report that
...
you had 0 messages when using IMAP storage.
Secondary fixes: adding locks to list access in several places
Big thanks to Russell Bryant for helping out with this.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@70530 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-20 21:31:26 +00:00
Tilghman Lesher
ce2c52d519
Merged revisions 70445 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
................
r70445 | tilghman | 2007-06-20 14:29:23 -0500 (Wed, 20 Jun 2007) | 10 lines
Merged revisions 70444 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r70444 | tilghman | 2007-06-20 14:25:54 -0500 (Wed, 20 Jun 2007) | 2 lines
Issue 9997 - Timelimit times out the wrong channel
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@70446 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-20 19:30:31 +00:00
Tilghman Lesher
704c756c4a
Merge work to make U(...) option work for Dial
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@70358 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-20 17:35:08 +00:00
Tilghman Lesher
d260399bc1
Oops, shouldn't have taken that last shortcut (also add some checks)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@70291 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-20 13:00:45 +00:00
Tilghman Lesher
344f8d40a8
Another method of doing local variables, hopefully a little closer to what codefreeze had in mind
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@70272 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-20 05:47:05 +00:00
Tilghman Lesher
2586a090a8
Local variables for codefreeze
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@70253 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-20 04:36:23 +00:00
Steve Murphy
866bbaa515
Via bug9228, no way to create macros via AEL, and some of the apps allow you to call macros..., I modded the apps that allow macro calls to allow gosubs calls also, to make them AEL compliant.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@70161 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-19 23:36:34 +00:00
Joshua Colp
f804f5d2ed
Merged revisions 69895 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
................
r69895 | file | 2007-06-19 09:55:25 -0400 (Tue, 19 Jun 2007) | 10 lines
Merged revisions 69894 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r69894 | file | 2007-06-19 09:54:03 -0400 (Tue, 19 Jun 2007) | 2 lines
Perform an extra hangup check just in case. (issue #9589 reported by bcnit)
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@69896 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-19 13:56:37 +00:00
Mark Michelson
a434fa668b
Undoing my last commit. I misread the code before.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@69809 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-18 23:28:10 +00:00
Mark Michelson
2265686e33
Cleaned up a section where there were two consecutive identical if statements.
...
Combined the bodies of the two into one if. I blame svn merging for this.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@69808 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-18 23:26:08 +00:00
Brett Bryant
7573042f95
Fixed issue where 'stop gracfeully' was hanging ...
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@69807 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-18 22:23:51 +00:00
Tilghman Lesher
30600f053f
Janitor for ast_localtime
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@69745 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-18 17:48:56 +00:00
Russell Bryant
43658278ff
Merged revisions 69702 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r69702 | russell | 2007-06-18 11:35:02 -0500 (Mon, 18 Jun 2007) | 6 lines
To prevent 92138749238754 more reports of "I have unixodbc installed, but
still can't build *_odbc.so!", check for ltdl directly, instead of just listing
it as another library to include in the unixodbc check in the configure script.
This also makes ltdl show up as a dependency in menuselect so people know what
to go install. (related to issue #9989 , patch by me)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@69703 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-18 16:35:51 +00:00
Joshua Colp
84e624ff23
Merged revisions 69558 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
................
r69558 | file | 2007-06-15 15:23:45 -0400 (Fri, 15 Jun 2007) | 2 lines
Add support for setting the maximum length of acceptable DTMF in SpeechBackground.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@69559 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-15 19:25:11 +00:00
Russell Bryant
4b5a71e9d0
Merged revisions 69518 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r69518 | russell | 2007-06-15 10:27:34 -0500 (Fri, 15 Jun 2007) | 5 lines
The SLATRUNK_STATUS variable indicated "SUCCESS" for both an answer of the
incoming call on the trunk, or if the trunk reached its ring timeout.
This patch changes the variable to say "RINGTIMEOUT" in that case.
(issue #9973 , reported by n00dle, patch by me)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@69519 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-15 15:36:45 +00:00
Russell Bryant
b179e2155f
Convert uses of strdup() to ast_strdup()
...
(issue #9983 , eliel)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@69436 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-14 23:01:01 +00:00
Kevin P. Fleming
5fdba27ea2
Merged revisions 69392 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r69392 | kpfleming | 2007-06-14 16:50:40 -0500 (Thu, 14 Jun 2007) | 2 lines
use ast_localtime() in every place localtime_r() was being used
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@69405 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-14 22:09:20 +00:00
Russell Bryant
ab6fa304a4
Add support for the tw language in voicemail
...
(issue #9964 , ljmid)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@69348 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-14 21:02:19 +00:00
Russell Bryant
055d82cbce
Add a massive set of changes for converting to use the ast_debug() macro.
...
(issue #9957 , patches from mvanbaak, caio1982, critch, and dimas)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@69327 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-14 19:39:12 +00:00