Luigi Rizzo
89c2e53eb0
formatting cleanup
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89523 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-22 04:19:04 +00:00
Luigi Rizzo
51391e6b09
shuffle a little bit the content of header files to reduce dependencies.
...
In this commit:
- move the ast_register/unregister_app functions to module.h
to avoid the need to include pbx.h for the simpler apps;
- move the ast_group structure to channel.h to remove the
dependency of app.h on linkedlists.h
Note, this is a long process that I am doing in small steps.
The main difficulty is that now for each subsystem we
have a single header (e.g. channel.h) included by the subsystem
provider (usually one file, e.g. channel.c) and by its clients
(dozens of them, e.g. we have some 70+ apps and 30+ functions).
This requires the clients to include all the extra headers
required by the provider (eg. lock.h, linkedlists.h, definitions
of substructures...) even though many of the clients would be
just happy with opaque struct declarations and function prototypes.
The long term plan is to eventually rectify this structure
so that the compilation can become faster, and also APIs
are more stable.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89522 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-22 03:50:04 +00:00
Luigi Rizzo
200f9c633b
remove some useless includes
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89521 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-22 02:30:58 +00:00
Luigi Rizzo
ea2c54859d
more removal of redundant headers
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89519 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-22 02:07:33 +00:00
Luigi Rizzo
b1fe2d85d3
remove redundant headers
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89518 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-22 01:39:06 +00:00
Luigi Rizzo
dd10b6d37e
more removal of fcntl.h and other system headers
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89517 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-22 01:13:46 +00:00
Luigi Rizzo
3fc2646808
remove a number of #include <fcntl.h> which are either
...
useless or done elsewhere
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89516 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-22 01:03:02 +00:00
Luigi Rizzo
730e4eaca4
implement the split of file.h and mod_format.h
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89515 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-22 00:53:49 +00:00
Luigi Rizzo
8ad9122aa8
Add a specific header for providers of file and format handling routines,
...
moving here structs and function declarations formerly in file.h
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89514 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-22 00:53:13 +00:00
Steve Murphy
86476c607f
closes issue #11285 , where an unload of a module that creates a dialplan context, causes a crash when you do a 'dialplan show' of that context. This is because the registrar string is defined in the module, and the stale pointer is traversed. The reporter offered a patch that would always strdup the registrar string, which is practical, but I preferred to destroy the created contexts in each module where one is created. That seemed more symmetric. There were only 6 place in asterisk where this is done: chan_sip, chan_iax2, chan_skinny, res_features, app_dial, and app_queue. The two apps destroyed the context, but left the contexts. All is fixed now and unloads should be dialplan friendly.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89513 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 23:54:12 +00:00
Luigi Rizzo
7e8835e0d7
remove another set of redundant #include "asterisk/options.h"
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89512 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 23:24:55 +00:00
Luigi Rizzo
e0ff5fef5c
remove a bunch of useless #include "options.h"
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89511 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 23:09:02 +00:00
Matthew Fredrickson
27dc9e7c70
Remove unneccessary explicit case for BRI
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89510 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 22:37:25 +00:00
Matthew Fredrickson
9f0859d19d
Take some debug code out :-)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89509 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 22:34:45 +00:00
Luigi Rizzo
2142ad6be8
add a missing return
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89508 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 22:20:36 +00:00
Matthew Fredrickson
0643a7ccff
Add BRI support to chan_zap
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89507 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 22:07:55 +00:00
Luigi Rizzo
6dfc36b639
enable support for stack backtrace for stuff built in utils/
...
(this was present in the main tree but forgotten here).
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89506 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 21:30:24 +00:00
Steve Murphy
55e03ad681
closes issue #11290 ; the proposed patch was a good guess, and would solve the bug to some extent, but was really masking the real issue, that there were bad entries in the table. This fix removes the condition that the hashtab updates be done on exten removal only when the pattern_tree was present, which is silly. The operations that apply to the pattern tree are instead made conditional. Also, threw back in routines that kpfleming deleted because of probs in the 64-bit world. Tested on both 32 and 64-bit machines (compile). Tested the reload problem with over 20 reloads, and no problems. If you find more problems, please reopen 11290.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89505 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 20:38:00 +00:00
Terry Wilson
ff6b2ad8de
Simplify comparison in parking fix
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89504 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 20:22:40 +00:00
Mark Michelson
ffa8035212
Merged revisions 89495 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r89495 | mmichelson | 2007-11-21 13:27:51 -0600 (Wed, 21 Nov 2007) | 3 lines
Fix a small error I made in my previous commit
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89496 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 19:28:43 +00:00
Mark Michelson
9c275b0e51
Merged revisions 89493 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r89493 | mmichelson | 2007-11-21 13:24:22 -0600 (Wed, 21 Nov 2007) | 5 lines
Changing an inaccurate debug message to be less inaccurate. Under the circumstances, this
message would always report that there were 0 members available, even though that may not be true.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89494 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 19:27:22 +00:00
Terry Wilson
348025fd0b
Merged revisions 89491 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r89491 | twilson | 2007-11-21 12:59:27 -0600 (Wed, 21 Nov 2007) | 4 lines
If a channel gets masqueraded in the middle of a park, don't play the
announcement to the masqueraded channel, and dial back to the original
channel on timeout.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89492 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 19:20:33 +00:00
Russell Bryant
cb67c91cb0
Remove obsolete OLD_DSP_ROUTINES code. Also, remove the FAX_DETECT define and
...
only do the calculations if fax detection is enabled on the dsp.
(closes issue #11331 )
Reported by: dimas
Patches:
dsp.patch uploaded by dimas (license 88)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89490 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 18:52:19 +00:00
Tilghman Lesher
1c295be7a0
Change Read to set READSTATUS as an indication of the result
...
Also, some cleanup to CHANGES.
Reported by: michael-fig
Patch by: michael-fig,tilghman
(Closes issue #11004 )
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89489 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 18:38:18 +00:00
Russell Bryant
192252ec58
fix a small gramatical error in a comment
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89488 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 18:24:23 +00:00
Mark Michelson
3851bc9789
There existed about a 1 in 4 billion chance that reading from /dev/urandom
...
would return LONG_MIN (1 in 9 quintillion if using 64-bit longs). Since there
is no positive equivalent of LONG_MIN, the result of labs() in this case is
unpredictable. This fixes that situation.
(closes issue #11336 , reported and patched by sperreault)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89487 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 18:19:22 +00:00
Russell Bryant
6d8d66e9e7
Fix some code that was supposed to ensure that a buffer was terminated, but was
...
writing to the wrong byte. Also, remove some non-thread safe test code.
(closes issue #11317 )
Reported by: IgorG
Patches:
unistim-2.patch uploaded by IgorG (license 20)
- additional changes by me
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89484 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 16:24:17 +00:00
Mark Michelson
29ad24e37a
I introduced a deadlock avoidance into 1.4, which I attempted to port to trunk as well.
...
Unfortunately, since trunk uses read/write locks for the context lock, it means that I have
actually *introduced* a deadlock condition since they are not recursive. Removing this change
for now and will look into introducing a different one.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89483 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 16:08:12 +00:00
Kevin P. Fleming
3826d15993
move these forward declarations back to asterisk.h where they belong... even though asterisk.h includes compat.h, these declarations have nothing to do with the being platform-compatible and are directly related to being part of Asterisk
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89482 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 16:07:11 +00:00
Kevin P. Fleming
296fe3e1fb
get this to actually compile...
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89481 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 15:45:56 +00:00
Kevin P. Fleming
34ed13becd
remove some debugging code that doesn't compile on 64-bit platforms
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89480 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 15:29:39 +00:00
Steve Murphy
837b8ef417
OOOps! All the debug stuff I inserted was accidentally committed. I hereby revert it.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89479 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 15:17:12 +00:00
Steve Murphy
4670e38aac
closes issue #11265 ; Thanks to snuffy for his work on neatening up the code and removing duplicated code.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89478 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 15:11:43 +00:00
Luigi Rizzo
83eabfda55
remove this file, it is not used anywhere.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89477 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 08:28:27 +00:00
Luigi Rizzo
9d7ddb3c63
add missing paths.h
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89476 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 01:35:30 +00:00
Luigi Rizzo
2ff174e62e
add check for video4linux
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89475 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 01:29:45 +00:00
Steve Murphy
8e90425a6c
A free in add_pri was ultimately the source of the grief we were having with parking. This set of changes fixes that problem, and introduces some more error messages, and puts debugs into ifdefs for what could be short-term usage. Txs to Terry W. for his help, guidance, and especially patience.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89474 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 01:09:47 +00:00
Luigi Rizzo
04e1e0069f
more header removal/normalization
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89473 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 00:23:49 +00:00
Luigi Rizzo
b4ab6b5652
X11 checks (at least some - for other platforms with
...
unusual X11 locations you might need to add more directories)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89472 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 00:22:41 +00:00
Russell Bryant
6335b4b30d
Merge changes from team/russell/sla_trunk_moh ...
...
* Added the ability to specify the music on hold class used to play into the
conference when there is only one member and the M option is used.
* Added the ability to specify a music on hold class to play instead of ringing
for the SLATrunk application.
(patched by me, and tested internally)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89470 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 00:21:38 +00:00
Luigi Rizzo
49b022aee2
complete support for X11
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89469 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 00:20:08 +00:00
Tilghman Lesher
cbfc6dcbea
Make trunk build again
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89468 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-20 23:29:33 +00:00
Tilghman Lesher
8f4fb30cfe
Add support for new recorded character sounds
...
Closes issue #5208
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89467 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-20 23:28:57 +00:00
Luigi Rizzo
a23c055c3d
move asterisk/paths.h outside asterisk.h and into those files
...
who really need it.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89466 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-20 23:16:15 +00:00
Luigi Rizzo
915b97d300
move internal function declarations to include/asterisk/_private.h
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89465 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-20 22:18:21 +00:00
Russell Bryant
2626c511da
i got a little carried away with commas ...
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89464 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-20 19:29:08 +00:00
Kevin P. Fleming
4d522da4aa
switch compile-time option checking to string storage mode in this branch too
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89463 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-20 19:28:10 +00:00
Russell Bryant
90296ccdfe
fix the zaptel configure script check
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89460 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-20 19:11:18 +00:00
Luigi Rizzo
776c73ed5e
the 'version' is now $7 not $6
...
(wait a bit before regenerating configure, i have more changes)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89459 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-20 18:20:25 +00:00
Mark Michelson
dda649ead2
Merged revisions 89457 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r89457 | mmichelson | 2007-11-20 11:50:31 -0600 (Tue, 20 Nov 2007) | 9 lines
According to comments in main/pbx.c, it is essential that if we are going to lock
the conlock as well as the hints lock, it must be locked in that respective order.
In order to prevent a potential deadlock, we need to lock the conlock prior to
locking the hints lock in ast_hint_state_changed (see the call stack example on
issue #11323 for how this can happen).
(closes issue #11323 , reported by eelcob, suggestion for patch by eelcob, patch by me)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89458 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-20 17:59:00 +00:00