Commit Graph

3256 Commits

Author SHA1 Message Date
Mark Michelson 7a554a7386 Merged revisions 158053 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r158053 | mmichelson | 2008-11-20 11:33:06 -0600 (Thu, 20 Nov 2008) | 12 lines

Make sure to set the hangup cause on the calling channel in the case
that ast_call() fails. For incoming SIP channels, this was causing
us to send a 603 instead of a 486 when the call-limit was reached on
the destination channel.

(closes issue #13867)
Reported by: still_nsk
Patches:
      13867.diff uploaded by putnopvut (license 60)
Tested by: blitzrage


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158066 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-20 17:39:06 +00:00
Mark Michelson 9e1283e160 Add a space to the output
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157940 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-19 23:30:42 +00:00
Mark Michelson de5ba432da Add a RES_NOT_DYNAMIC case for the CLI command
'queue remove member'



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157939 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-19 23:29:14 +00:00
Kevin P. Fleming 81a16aa982 make some corrections to the ast_agi_register_multiple(), ast_agi_unregister_multiple() and ast_agi_fdprintf() API calls to be consistent with API guidelines
also, move UPGRADE.txt to UPGRADE-1.6.txt and make the new UPGRADE.txt contain information about upgrading between Asterisk 1.6 releases



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157706 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-19 12:42:19 +00:00
Mark Michelson 6c554e4996 Fix the logic for when delete=yes when IMAP storage
is in use so that the message is deleted from both
local and IMAP storage.

(closes issue #13642)
Reported by: jaroth
Patches:
      deleteyes.patch uploaded by jaroth (license 50)




git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157562 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-18 23:28:23 +00:00
Jeff Peeler 53f3870ed3 Merged revisions 157365 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r157365 | jpeeler | 2008-11-18 13:13:33 -0600 (Tue, 18 Nov 2008) | 6 lines

(closes issue #13899)
Reported by: akkornel

This fix is the result of a bug fix in ast_app_separate_args r124395. If an argument does not exist it should always be set to a null string rather than a null pointer.


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157366 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-18 19:16:00 +00:00
Mark Michelson d91f1df3e0 Merged revisions 157305 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r157305 | mmichelson | 2008-11-18 12:25:55 -0600 (Tue, 18 Nov 2008) | 12 lines

Fix a crash in the end_bridge_callback of app_dial and
app_followme which would occur at the end of an attended
transfer. The error occurred because we initially stored
a pointer to an ast_channel which then was hung up due
to a masquerade.

This commit adds a "fixup" callback to the bridge_config
structure to allow for end_bridge_callback_data to be
changed in the case that a new channel pointer is needed
for the end_bridge_callback.


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157306 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-18 18:31:08 +00:00
Tilghman Lesher 1287486dbf Can't use items duplicated off the stack frame in an element returned from
a function: in these cases, we have to use the heap, or garbage will result.
(closes issue #13898)
 Reported by: alecdavis
 Patches: 
       20081114__bug13898__2.diff.txt uploaded by Corydon76 (license 14)
 Tested by: alecdavis


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157253 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-17 22:25:06 +00:00
Mark Michelson cf6c66de65 Fix some refcounting in app_queue.c and change the
hashing used by app_queue.c to be case-insensitive.
This is accomplished by adding a new case-insensitive
hashing function.

This was necessary to prevent bad refcount errors
(and potential crashes) which would occur due to the
fact that queues were initially read from the config
file in a case-sensitive manner. Then, when a user
issued a CLI command or manager action, we allowed
for case-insensitive input and used that input to 
directly try to find the queue in the hash table. The result
was either that we could not find a queue that was input or
worse, we would end up hashing to a completely bogus value
based on the input.

This commit resolves the problem presented in
issue #13703. However, that issue was reported against
1.6.0. Since this fix introduces a behavior change, I am
electing to not place this same fix in to the 1.6.0 or 1.6.1
branches, and instead will opt for a change which does not
change behavior.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@156883 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-14 16:53:38 +00:00
Mark Michelson ea9955dd2a Merged revisions 156816 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r156816 | mmichelson | 2008-11-14 09:18:59 -0600 (Fri, 14 Nov 2008) | 10 lines

If the prompt to reenter a voicemail password timed out, it
resulted in the password not being saved, even if the input matched
what you gave when first prompted to enter a new password. This is
because the return value of ast_readstring was checked, but not checked
properly.

This bug was discovered by Jared Smith during an Asterisk training course.
Thanks for reporting it!


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@156817 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-14 15:20:03 +00:00
Tilghman Lesher c4fe83046b Merged revisions 156755 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r156755 | tilghman | 2008-11-13 18:41:37 -0600 (Thu, 13 Nov 2008) | 6 lines
  
  ast_waitfordigit() requires that the channel be up, for no good logical
  reason.  This prevents While/EndWhile from working within the "h"
  extension.
  Reported by: jgalarneau (for ABE C.2)
  Fixed by: me
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@156756 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-14 00:43:13 +00:00
Eliel C. Sardanons a22928b853 Introduce XML documentation for:
- MeetMe()
  - MeetMeCount()
  - MeetMeChannelAdmin()
  - MeetMeAdmin()
  - SLAStation()
  - SLATrunk()

- Add an attribute to optionlist 'hasparams' with the same functionality as the one
we have in <parameter> and <argument> (the DTD was updated)
- Fix a leak when getting an attribute while parsing an <optionlist>.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@156575 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-13 15:46:06 +00:00
Tilghman Lesher 10afda33c7 Merged revisions 156386 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r156386 | tilghman | 2008-11-12 15:18:57 -0600 (Wed, 12 Nov 2008) | 5 lines
  
  When using call limits under 1 second, infinite call lengths are allowed,
  instead.
  (closes issue #13851)
   Reported by: ruddy
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@156388 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-12 21:34:51 +00:00
Tilghman Lesher 221998f4d4 Merged revisions 156294 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r156294 | tilghman | 2008-11-12 13:26:45 -0600 (Wed, 12 Nov 2008) | 6 lines
  
  If the SLA thread is not started, then reload causes a memory leak.
  (closes issue #13889)
   Reported by: eliel
   Patches: 
         app_meetme.c.patch uploaded by eliel (license 64)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@156295 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-12 19:28:22 +00:00
Jeff Peeler 611e737463 Merged revisions 156289 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r156289 | jpeeler | 2008-11-12 13:10:12 -0600 (Wed, 12 Nov 2008) | 3 lines

For whatever reason, gcc only warned me about the possible use of an uninitialized variable when compiling 1.6.1. 


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@156290 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-12 19:11:15 +00:00
Jeff Peeler f7aaa011b6 Merged revisions 156178 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r156178 | jpeeler | 2008-11-12 11:53:44 -0600 (Wed, 12 Nov 2008) | 8 lines

(closes issue #13173)
Reported by: pep

This change adds an announce_thread responsible for playing announcements to an existing conference. This allows all announcing to be immediately stopped if necessary but more importantly allows other threads that need to play something to not block. There are multiple benefits to this, but the actual bug is for solving the scenario for a channel to be unusable after hang up for the entire duration of the parting announcement. The parting announcement can be extremely long depending on what the user recorded upon joining the conference.

Reviewed by Russell on Review Board:
http://reviewboard.digium.com/r/25/

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@156228 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-12 18:32:46 +00:00
Mark Michelson a9e84c1e51 Merged revisions 156167 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r156167 | mmichelson | 2008-11-12 11:38:33 -0600 (Wed, 12 Nov 2008) | 7 lines

When doing some tests, I was having a crash at the end of every call
if an attended transfer occurred during the call. I traced the cause to
the CDR on one of the channels being NULL. murf suggested a check in
the end bridge callback to be sure the CDR is non-NULL before proceeding,
so that's what I'm adding.


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@156169 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-12 17:41:56 +00:00
Sean Bright 48522988ab In order to move away from nested function use, some changes to the recently introduced
ast_channel_search_locked need to be made.  Specifically, the caller needs to be able to
pass arbitrary data which in turn is passed to the callback.  This patch addresses all
of the nested functions currently in asterisk trunk.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@155590 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-09 01:59:59 +00:00
Sean Bright 9ef09ad1d4 Merged revisions 155553 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r155553 | seanbright | 2008-11-08 20:08:07 -0500 (Sat, 08 Nov 2008) | 6 lines

Use static functions here instead of nested ones.  This requires a small
change to the ast_bridge_config struct as well.  To understand the reason
for this change, see the following post:

    http://gcc.gnu.org/ml/gcc-help/2008-11/msg00049.html

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@155554 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-09 01:27:00 +00:00
Sean Bright 30d1744ffc Add ability to pass arbitrary data to the ao2_callback_fn (called from
ao2_callback and ao2_find).  Currently, passing OBJ_POINTER to either
of these mandates that the passed 'arg' is a hashable object, making
searching for an ao2 object based on outside criteria difficult.

Reviewed by Russell and Mark M. via ReviewBoard:
    http://reviewboard.digium.com/r/36/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@155401 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-07 22:39:30 +00:00
Sean Bright 8a25d59bf8 Fix some whitespace.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154926 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-05 22:22:37 +00:00
Sean Bright 6ac794074e Update a couple places to use the new ast_channel_search_locked API call.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154923 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-05 22:19:22 +00:00
Eliel C. Sardanons 34e094726e Add TestClient() and TestServer() applications XML
documentation.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154801 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-05 19:17:32 +00:00
Eliel C. Sardanons 5fd54b0fe1 Add more [see also] references based on TFOT.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154798 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-05 18:50:02 +00:00
Eliel C. Sardanons 45e6c880cd Add Macro(), MacroExit(), MacroExclusive() and
MacroIf() applications XML documentation.

(closes issue #13699)
Reported by: snuffy
Patches:
      bug13699_20081016.diff uploaded by snuffy (license 35)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154796 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-05 18:46:29 +00:00
Eliel C. Sardanons 990a6bebe8 Add more SeeAlso references based on TFOT.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154647 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-05 14:37:07 +00:00
Eliel C. Sardanons cb4ef23b12 - Add ParkAndAnnounce() application XML documentation.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154615 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-05 13:51:16 +00:00
Eliel C. Sardanons f18699be24 - Add more <see-also> based on TFOT.
- Add the 'filename' type to the see-also ref. To be able to reference a filename.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154578 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-05 13:07:29 +00:00
Eliel C. Sardanons d23dff9ca8 - Add some see-also references based on TFOT.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154542 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-05 12:13:57 +00:00
Eliel C. Sardanons 1402c25284 - Add Read() application XML documentation.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154507 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-05 11:26:40 +00:00
Eliel C. Sardanons 63930985a1 - Add FollowMe() application XML documentation.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154469 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-05 02:08:39 +00:00
Eliel C. Sardanons 0cd47929d4 - Add PlayTones() and StopPlayTones() applications XML documentation.
- Fix a dot that was outside of the <para> in the ForkCDR() XML documentation.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154467 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-05 01:44:04 +00:00
Tilghman Lesher 2cc8e25222 Slightly optimize ast_devstate_str and rename global functions devstate2str and config_text_file_save to have an ast_ prefix
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154260 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-04 18:47:20 +00:00
Eliel C. Sardanons a57a3cbf19 Add XML documentation for the ForkCDR() application.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154225 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-04 18:06:50 +00:00
Kevin P. Fleming 448562af93 improve configure script to remember the previous value of each dependency in build_tools/menuselect-deps, so that (once it has been written) menuselect can use this information to warn the user when a previously met dependency is no longer met
along the way, change tags used in configure script, menuselect-deps and code for various dependencies to be consistently named



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154151 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-04 15:07:54 +00:00
Tilghman Lesher b287a63971 Merged revisions 154066 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r154066 | tilghman | 2008-11-03 16:27:10 -0600 (Mon, 03 Nov 2008) | 5 lines
  
  Attempting to expunge a mailbox when the mailstream is NULL will crash Asterisk.
  (Closes issue #13829)
  Reported by: jaroth
  Patch by: me (modified jaroth's patch)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154072 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-03 22:28:12 +00:00
Eliel C. Sardanons 3873227e9d Add LOCAL() function XML documentation.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153947 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-03 17:11:22 +00:00
Eliel C. Sardanons 9167a2b5e1 Add XML documentation for:
- WaitForSilence()
   - WaitForNoise()
   - WaitForRing()
   - IVRDemo()
   - DBDel()
   - DBDeltree()

 (issue #13699)
 Reported by: snuffy
 Patches: 
       bug13699_20081016.diff uploaded by snuffy (license 35)
        (With minor changes)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153747 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-03 01:01:25 +00:00
Kevin P. Fleming a67790c6f5 instead of trying to forcibly load res_agi when app_stack is loaded (even if the administrator didn't want it loaded), use GCC weak symbols to determine whether it was loaded already or not; if it was loaded, then use it.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153709 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-02 23:34:39 +00:00
Kevin P. Fleming bd4eb070f3 bring over all the fixes for the warnings found by gcc 4.3.x from the 1.4 branch, and add the ones needed for all the new code here too
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153616 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-02 18:52:13 +00:00
Eliel C. Sardanons ee6a480a6c Add Flash() application XML documentation.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153543 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-02 05:10:22 +00:00
Eliel C. Sardanons cdc31b1e5b Fix a typo in the name of the application.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153541 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-02 04:57:02 +00:00
Sean Bright 39cbb89947 Another little one.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153472 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-02 02:57:27 +00:00
Russell Bryant 2baafa6156 fix a typo (thanks sean)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153470 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-02 02:55:25 +00:00
Russell Bryant 6f314f4d42 Fix various spelling and grammatical issues in documentation
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153468 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-02 02:50:33 +00:00
Russell Bryant d7742120e9 - Use a for loop instead of a while loop
- Get rid of an unnecessary variable


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153437 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-02 02:20:10 +00:00
Russell Bryant ad533bc62b Instead of doing a couple of strlen() calls each iteration of the loop, only do it once
at the beginning of the function


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153435 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-02 02:14:19 +00:00
Russell Bryant 5b168ee34b Merge changes from team/group/appdocsxml
This commit introduces the first phase of an effort to manage documentation of the
interfaces in Asterisk in an XML format.  Currently, a new format is available for
applications and dialplan functions.  A good number of conversions to the new format
are also included.

For more information, see the following message to asterisk-dev:

http://lists.digium.com/pipermail/asterisk-dev/2008-October/034968.html


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153365 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-01 21:10:07 +00:00
Mark Michelson d521ad9696 * Fixed timeout logic in the dialing API as setting timeouts
had no effect
* Updated dialing API documentation to indicate that timeouts
  are specified in milliseconds
* Added a new timeout argument to the Page application. If time
  expires, any endpoints which have not answered will be hung up.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153223 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-31 20:05:46 +00:00
Terry Wilson 5fe37e47c6 Recent CDR fixes moved execution of the 'h' exten into the bridging code, so variables that were set after ast_bridge_call was called would not show up in the 'h' exten. Added a callback function to handle setting variables, etc. from w/in the bridging code. Calls back into a nested function within the function calling ast_bridge_call
(closes issue #13793)
Reported by: greenfieldtech


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153181 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-31 18:55:33 +00:00