Luigi Rizzo
4ca8c0fc8d
s/pu->chan/chan in a few places;
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@20626 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-16 19:41:12 +00:00
Luigi Rizzo
36ea51ecd7
put some common code into functions (still more instances to be replaced)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@20625 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-16 19:26:57 +00:00
Luigi Rizzo
70109abc39
properly reindent a large block.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@20624 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-16 19:12:51 +00:00
Luigi Rizzo
e304a986fd
more readability fixes - localize some variables and invert
...
a condition in an 'if' statement to reduce the nesting depth.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@20623 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-16 19:05:19 +00:00
Luigi Rizzo
d29f8a677e
introduce a function to set context, extension and priority
...
replacing some common blocks of code (there are still a few
instances where it can be used)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@20598 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-16 18:49:46 +00:00
Luigi Rizzo
81ed862e67
minor readability fixes in preparation for more work on this file:
...
- replace nested 'if' with '&&'
- fix indentation
- annotate the end brace of some huge block
- remove useless parentheses
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@20597 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-16 18:37:01 +00:00
Joshua Colp
4657dc770c
We are shaking up trunk tonight! allow data dir to be specified (issue #6967 reported by tzafrir)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@20330 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-15 22:53:53 +00:00
Luigi Rizzo
e42087f5e3
- normalize for() loops to navigate through variables,
...
removing replicated var = var->next;
- remove a potential infinite loop and document the problem
- remove useless checks and document why
- mark XXX a possible bug (to be investigated)
- use ast_strlen_zero() instead of expanding it inline
- fix indentation in one place
- replace a nested 'if' with '&&'
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@20223 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-15 00:05:08 +00:00
Luigi Rizzo
d043954dc1
- remove some unnecessary casts and braces;
...
- add braces around a nested 'if'
- use S_OR and '?' to remove some duplicated function calls;
- replace nested 'if' with &&
- move out a common term in a sequence of 'if'
- add a comment on a potentially dangerous string manipulation
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@20196 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-14 23:20:29 +00:00
Luigi Rizzo
62712ea668
constification and code simplifications
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@20165 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-14 22:02:19 +00:00
Luigi Rizzo
6d574f36ca
partial fix of the module API to use the new method.
...
Still not complete as we need to take care of the usecount stuff.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@20104 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-14 19:35:37 +00:00
Luigi Rizzo
8d98d44e82
fix another svn merge bug
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@20076 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-14 18:45:08 +00:00
Luigi Rizzo
e43bc6634d
This rather large commit changes the way modules are loaded.
...
As partly documented in loader.c and include/asterisk/module.h,
modules are now expected to return all of their methods and flags
into a structure 'mod_data', and are normally loaded with RTLD_NOW
| RTLD_LOCAL, so symbols are resolved immediately and conflicts
should be less likely. Only in a small number of cases (res_*,
typically) modules are loaded RTLD_GLOBAL, so they can export
symbols.
The core of the change is only the two files loader.c and
include/asterisk/module.h, all the rest is simply adaptation of the
existing modules to the new API, a rather mechanical (but believe
me, time and finger-consuming!) process whose detail you can figure
out by svn diff'ing any single module.
Expect some minor compilation issue after this change, please
report it on mantis http://bugs.digium.com/view.php?id=6968
so we collect all the feedback in one place.
I am just sorry that this change missed SVN version number 20000!
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@20003 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-14 14:08:19 +00:00
Joshua Colp
5e43f18529
Updates to speech recognition API and dialplan utilities. Moved to using dialplan functions, and some other misc things.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19645 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-13 00:18:52 +00:00
Luigi Rizzo
7507309732
normalize code in preparation to module changes
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19189 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-11 10:01:00 +00:00
Joshua Colp
e4811a8248
Presenting a revised data stores and oh my, a generic speech recognition API! I wonder what we can do with this now...
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18979 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-10 23:29:50 +00:00
BJ Weschke
70e407c5be
Merged revisions 18866 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r18866 | bweschke | 2006-04-10 12:29:51 -0500 (Mon, 10 Apr 2006) | 2 lines
Don't say that we can pass an 'exten' argument in the documentation of Park() when we really cannot. #6902 (opsys)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18867 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-10 17:32:29 +00:00
Russell Bryant
f7c5aee2ad
remove a couple more unnecessary "out of memory" error messages
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18723 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-10 02:19:58 +00:00
Russell Bryant
7878538953
use ast_*alloc and don't create duplicated error messages.
...
... as stated in the coding guidelines.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18722 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-10 02:15:47 +00:00
Russell Bryant
9a5c7c75a3
Instead of using strncpy, use ast_copy_string. Also, in the case of copying a
...
constant string into a buffer that we know is big enough, don't use a length
limited copy at all, use strcpy.
... as stated in the coding guidelines.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18721 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-10 02:05:59 +00:00
Russell Bryant
d13bc3fc83
run the module through indent to fix the formatting issues that violate the
...
coding guidelines
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18704 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-10 02:01:39 +00:00
Russell Bryant
d203e9c6c0
add back braces that were removed in a recent commit that leave a bunch of
...
nested statements in a block without branches, which is a violation of the
coding guidelines.
As a matter of fact, this module violates the coding guidelines in multiple
ways that including formatting and code issues. In my opinion, this module
should not have been merged into the trunk in this form.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18693 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-10 01:51:47 +00:00
Olle Johansson
70f18e5f31
Issue 6917 - some cleanups for res_config_pgsql.c (mithraen)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18607 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-09 18:57:25 +00:00
Kevin P. Fleming
699f55071b
a few cleanups from the last commit
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18572 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-08 22:16:34 +00:00
Kevin P. Fleming
f10f427d49
since the module API is changing, it's a good time to const-ify the description() and key() return values
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18552 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-08 22:01:19 +00:00
Russell Bryant
af2609dfbe
fix bug in smdi config parsing (issue #6908 )
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18493 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-08 19:16:38 +00:00
Olle Johansson
7089dc1341
Issue #6899 - remove OSP support code from chan_sip.c and app_dial.c
...
- implement all functions through internal APIs in res_osp.c and app_osplookup.c
(homesick)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18369 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-07 19:11:22 +00:00
Luigi Rizzo
c3249e2cb4
normalize repeated instances of code as follows:
...
- if (res >= 0)
- return RESULT_SUCCESS;
- else
- return RESULT_FAILURE;
+ return (res >= 0) ? RESULT_SUCCESS : RESULT_FAILURE;
(we should probably create a macro for this,
#define RET(r) ((r) >= 0) ? RESULT_SUCCESS : RESULT_FAILURE)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@17899 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-06 16:17:04 +00:00
Luigi Rizzo
e5d48fd45f
use the new module interface for this module, but make it
...
of type MOD_0 as it exports symbols so it should be loaded as RTLD_GLOBAL.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@17860 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-06 15:10:29 +00:00
Olle Johansson
d75fed39ca
Issue #6893 - Compiler warnings for PostgreSQL ARA driver
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@17740 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-06 06:55:38 +00:00
Joshua Colp
1001cc0656
Unbreak res/Makefile (issue #6891 as reported by casper)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@17661 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-05 18:37:29 +00:00
Olle Johansson
ef6b50b706
Issue #5637 - Realtime driver for PostgreSQL (mguesdon)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@17628 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-05 17:46:09 +00:00
Tilghman Lesher
756c7cbb12
Bug 6873 - Finish moving from the non-threadsafe (and poor randomness) rand() to threadsafe ast_random()
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@17627 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-05 17:44:44 +00:00
Luigi Rizzo
6c232811c0
as discussed with Mark a few weeks ago, the 'newstack' argument
...
in pbx_exec is always 1 so it can be removed.
This change also takes away ast_exec_extension(), and lets all
switch functions (exists, canmatch, exec, matchmore) all use the same
prototype, which makes the code a bit cleaner.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@16558 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-03-30 21:29:39 +00:00
Joshua Colp
bf7f1ec0f8
Merged revisions 16534 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r16534 | file | 2006-03-30 13:55:28 -0400 (Thu, 30 Mar 2006) | 2 lines
Do not exceed the array size for maximum allowed moh files. (issue #6842 )
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@16535 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-03-30 17:58:16 +00:00
Luigi Rizzo
48864ab877
do not export the tzlock and the list head, and introduce a new method,
...
ast_walk_indications(), to walk through the list of indications.
The new method returns an unlocked record, which is no different from the
behaviour of other existing methods in indications.c
(i.e. they all need to be fixed, with refcounts or some similar
method).
Note that ast_walk_indications() uses the pointer argument only as a
search key, so its implementation is completely safe.
In turn, this change allows the removal of AST_MUTEX_DEFINE_EXPORTED.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@16532 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-03-30 17:10:11 +00:00
Olle Johansson
dfc9952986
Set default value of adsipark (import from 1.2)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@16347 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-03-30 01:35:56 +00:00
Luigi Rizzo
fb75d34e70
use ast_cli_complete() to largely simplify the command completion code.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@15852 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-03-28 23:06:46 +00:00
Luigi Rizzo
2326d0d499
Bring in the new loader code as described in mantis #4377
...
and updated to today's version.
The core of the patch is only two files, loader.c
and include/asterisk/module.h, with the other files
touched only to adapt non-standard usages of the
reference counts and localuser lists.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@15784 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-03-28 21:15:10 +00:00
Luigi Rizzo
0159823ede
Use the standard macros to manipulate usecount.
...
This is in preparation to the import of the new loader.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@15550 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-03-28 14:15:13 +00:00
Matt O'Gorman
a5ece3388a
Janitor work converting !ast_strlen_zero(a)?a:b
...
to S_OR functions. from bug note 6805 with minor
modifications.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@15283 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-03-27 19:31:54 +00:00
Mark Spencer
9164eac21a
Add micro-http server and abstract manager interface, make snmp not die
...
on reload.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@14953 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-03-25 23:50:09 +00:00
Kevin P. Fleming
b0ac62573a
revert loader changes that have clearly not undergone adequate testing before commit
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@14952 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-03-25 23:22:44 +00:00
Tilghman Lesher
bdd24455b4
Bug 4377 - Round 2 of the loader updates
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@14886 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-03-25 06:02:46 +00:00
Joshua Colp
539f8a6502
Merged revisions 14523 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r14523 | file | 2006-03-23 17:51:50 -0400 (Thu, 23 Mar 2006) | 2 lines
Issue #6764 - Return BUSY signal when other party is busy at Attended Transfer (Reported by mnachev)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@14525 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-03-23 22:00:11 +00:00
Russell Bryant
d56674b341
Merged revisions 13961 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r13961 | russell | 2006-03-21 13:21:47 -0500 (Tue, 21 Mar 2006) | 3 lines
fix crash when using the ParkAndAnnounce application. When using this application,
there will be no peer channel to play the parking announcement to. (issue #6756 )
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@13962 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-03-21 18:22:38 +00:00
Russell Bryant
9d2f8b284d
add a CLI command that allows conversion of files to other formats using
...
the Asterisk file format and codec translation modules (issue #6062 )
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@12962 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-03-14 19:50:27 +00:00
Olle Johansson
b4a0e2a8bb
- Formatting fix in musiconhold
...
- One extra doxygen comment in res_features
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@12842 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-03-14 07:09:57 +00:00
Tilghman Lesher
34f64d0891
Bug 6304 - Add Park command to the manager interface
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@12163 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-03-06 23:12:48 +00:00
Olle Johansson
9c35741e5f
Issue #6628 - Disable res_snmp on incompatible platforms until
...
we have a resolution for the conflict. (Corydon's patch)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@12011 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-03-06 10:46:36 +00:00